From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51F30C433F5 for ; Wed, 29 Sep 2021 11:54:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1BE996136A for ; Wed, 29 Sep 2021 11:54:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1BE996136A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yPaaVqBcDIe+qPw+uDith6g592hd3cXLrWkwMy0clvo=; b=mcV97BezE6Mz9/ cwah3Vof/xU+/j0RSVnK86/zKwgRhlq5PSctffEtm//mHzDJzhb9YanIUqJ39Dcd4oFlyNK2dQ+LL IntjkpzG8oHvpZS1hwtcyCooYtA/v5P2SgbqVi8xuTFVm2WL+dALbcdDL1FW1Ih2KJTIrvxNJYOK5 jN0B+EbBUhQS0uE5yDThwO3/2mQicbPVZBFR6ebllC+PL6EwrZobvhGbHRCLtlPRKo+ph64+h1WNI 2VQQOzU8b+KrgDo7ANr0UANRIp27bsO0eTIMyFsNjJomvQ9N3utc+rYm15M8clY3RKBk7UvrH0SBh OflxWQYKXLmVddFe2bFg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVY8g-00AtOV-5j; Wed, 29 Sep 2021 11:52:42 +0000 Received: from relay12.mail.gandi.net ([217.70.178.232]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVY8a-00AtNS-QE for linux-arm-kernel@lists.infradead.org; Wed, 29 Sep 2021 11:52:39 +0000 Received: (Authenticated sender: alexandre.belloni@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id E0EBE20000D; Wed, 29 Sep 2021 11:52:30 +0000 (UTC) Date: Wed, 29 Sep 2021 13:52:30 +0200 From: Alexandre Belloni To: Will McVicker Cc: Russell King , Krzysztof Kozlowski , Catalin Marinas , Will Deacon , Michael Turquette , Stephen Boyd , Sylwester Nawrocki , Tomasz Figa , Chanwoo Choi , Linus Walleij , Alessandro Zummo , John Stultz , Thomas Gleixner , Lee Jones , Geert Uytterhoeven , Saravana Kannan , kernel-team@android.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-rtc@vger.kernel.org Subject: Re: [PATCH v2 12/12] ARM: rtc: remove HAVE_S3C_RTC in favor of direct dependencies Message-ID: References: <20210928235635.1348330-1-willmcvicker@google.com> <20210928235635.1348330-13-willmcvicker@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210928235635.1348330-13-willmcvicker@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210929_045237_171488_E6A95C81 X-CRM114-Status: GOOD ( 23.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, I'd argue that the subject should be rtc: s3c: ... On 28/09/2021 23:56:29+0000, Will McVicker wrote: > The config HAVE_S3C_RTC is not really needed since we can simply just > add the dependencies directly to RTC_DRV_S3C. Also, one less config to > keep track of! > > Signed-off-by: Will McVicker Acked-by: Alexandre Belloni > --- > arch/arm/Kconfig | 1 - > arch/arm/mach-exynos/Kconfig | 1 - > arch/arm/mach-s5pv210/Kconfig | 1 - > arch/arm64/Kconfig.platforms | 1 - > drivers/rtc/Kconfig | 10 ++-------- > 5 files changed, 2 insertions(+), 12 deletions(-) > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index fc196421b2ce..5ed6b5de981e 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -475,7 +475,6 @@ config ARCH_S3C24XX > select GPIOLIB > select GENERIC_IRQ_MULTI_HANDLER > select HAVE_S3C2410_I2C if I2C > - select HAVE_S3C_RTC if RTC_CLASS > select NEED_MACH_IO_H > select S3C2410_WATCHDOG > select SAMSUNG_ATAGS > diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig > index 2ad19a08bf06..8b72a70b6c43 100644 > --- a/arch/arm/mach-exynos/Kconfig > +++ b/arch/arm/mach-exynos/Kconfig > @@ -19,7 +19,6 @@ menuconfig ARCH_EXYNOS > select HAVE_ARM_ARCH_TIMER if ARCH_EXYNOS5 > select HAVE_ARM_SCU if SMP > select HAVE_S3C2410_I2C if I2C > - select HAVE_S3C_RTC if RTC_CLASS > select PINCTRL > select PM_GENERIC_DOMAINS if PM > select S5P_DEV_MFC > diff --git a/arch/arm/mach-s5pv210/Kconfig b/arch/arm/mach-s5pv210/Kconfig > index 62b90dda571f..681823687018 100644 > --- a/arch/arm/mach-s5pv210/Kconfig > +++ b/arch/arm/mach-s5pv210/Kconfig > @@ -12,7 +12,6 @@ config ARCH_S5PV210 > select CLKSRC_SAMSUNG_PWM > select GPIOLIB > select HAVE_S3C2410_I2C if I2C > - select HAVE_S3C_RTC if RTC_CLASS > select PINCTRL > select SOC_SAMSUNG > help > diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms > index e44d5e9f5058..02c8637d3f09 100644 > --- a/arch/arm64/Kconfig.platforms > +++ b/arch/arm64/Kconfig.platforms > @@ -91,7 +91,6 @@ config ARCH_BRCMSTB > > config ARCH_EXYNOS > bool "ARMv8 based Samsung Exynos SoC family" > - select HAVE_S3C_RTC if RTC_CLASS > select PINCTRL > select PM_GENERIC_DOMAINS if PM > select SOC_SAMSUNG > diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig > index e1bc5214494e..7208eeb8459a 100644 > --- a/drivers/rtc/Kconfig > +++ b/drivers/rtc/Kconfig > @@ -1404,16 +1404,10 @@ config RTC_DRV_OMAP > This driver can also be built as a module, if so, module > will be called rtc-omap. > > -config HAVE_S3C_RTC > - bool > - help > - This will include RTC support for Samsung SoCs. If > - you want to include RTC support for any machine, kindly > - select this in the respective mach-XXXX/Kconfig file. > - > config RTC_DRV_S3C > tristate "Samsung S3C series SoC RTC" > - depends on ARCH_S3C64XX || HAVE_S3C_RTC || COMPILE_TEST > + depends on ARCH_EXYNOS || ARCH_S3C64XX || ARCH_S3C24XX || ARCH_S5PV210 || \ > + COMPILE_TEST > help > RTC (Realtime Clock) driver for the clock inbuilt into the > Samsung S3C24XX series of SoCs. This can provide periodic > -- > 2.33.0.685.g46640cef36-goog > -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel