From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 992C7C433EF for ; Thu, 30 Sep 2021 23:34:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5D84261ABB for ; Thu, 30 Sep 2021 23:34:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5D84261ABB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DN27A0enQ16eHcuQN7TDHQDH2NizV2k5Oyn9E7UmvFc=; b=fI/Zg2Q+q/G572 whhqAKMVqTSKaO0AL6TGPJyIwPH7WzW0Z/i5TGDnUT64qk13vzxlB8fDPEI8VZU/Nwxw0qlb/0CVO LNBx/C87vqiz/IpWj6g4Zcsfrwt1syb0x3jMNyfaQy9QP/cUIFRgr6UuvvqBNsI3Aexv3wk/+SwAz HX5SDa+dhHrB1Oy2vutriqHAlP/jiMciB/Ba2icOU+76/D8vb7nPJgHvMwy6KgMtOhtvJvG9jNBu1 jftsC5tvMt7TmC908abYWy7/CGYdBvSlscjvG72dKG2ai2sHjh7RCSvXC5d4gYYpgvNQqaDK+/br/ mv5QJrDYrKbk5q5c7QAg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mW5Wx-00G9wT-W6; Thu, 30 Sep 2021 23:32:00 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mW5Wt-00G9vz-Pm for linux-arm-kernel@lists.infradead.org; Thu, 30 Sep 2021 23:31:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=9gmdjG51P4sUtdlckZMNf2bN5+zN0n8cVhZkk4LzqwE=; b=pC5GRS0XWArGvEi55mbqERtVOh N39cL3bi9yU69ML2hwVJ6lOe3tLcxU7O827WLtiuL720YgiSe9kDsdVok9lzuD2BvtKu/R58bCI/Q MYdjTqAQIQ2WB73gZnYaDK+3pG5Qm/xwNDy25zsvvgUUv3CtLNCW0CYzJDdNpoYvb3HU=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1mW5Wa-0091JE-Nn; Fri, 01 Oct 2021 01:31:36 +0200 Date: Fri, 1 Oct 2021 01:31:36 +0200 From: Andrew Lunn To: Wong Vee Khee Cc: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S . Miller" , Jakub Kicinski , Maxime Coquelin , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Michael Sit Wei Hong , Wong Vee Khee Subject: Re: [PATCH net v1 1/1] net: stmmac: fix EEE init issue when paired with EEE capable PHYs Message-ID: References: <20210930064436.1502516-1-vee.khee.wong@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210930064436.1502516-1-vee.khee.wong@linux.intel.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210930_163155_886237_8FA09549 X-CRM114-Status: GOOD ( 16.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 30, 2021 at 02:44:36PM +0800, Wong Vee Khee wrote: > When STMMAC is paired with Energy-Efficient Ethernet(EEE) capable PHY, > and the PHY is advertising EEE by default, we need to enable EEE on the > xPCS side too, instead of having user to manually trigger the enabling > config via ethtool. > > Fixed this by adding xpcs_config_eee() call in stmmac_eee_init(). > > Fixes: 7617af3d1a5e ("net: pcs: Introducing support for DWC xpcs Energy Efficient Ethernet") > Cc: Michael Sit Wei Hong > Signed-off-by: Wong Vee Khee > --- > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > index 553c4403258a..981ccf47dcea 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > @@ -486,6 +486,10 @@ bool stmmac_eee_init(struct stmmac_priv *priv) > timer_setup(&priv->eee_ctrl_timer, stmmac_eee_ctrl_timer, 0); > stmmac_set_eee_timer(priv, priv->hw, STMMAC_DEFAULT_LIT_LS, > eee_tw_timer); > + if (priv->hw->xpcs) > + xpcs_config_eee(priv->hw->xpcs, > + priv->plat->mult_fact_100ns, > + true); > } /* Check if it needs to be deactivated */ if (!priv->eee_active) { if (priv->eee_enabled) { netdev_dbg(priv->dev, "disable EEE\n"); stmmac_lpi_entry_timer_config(priv, 0); del_timer_sync(&priv->eee_ctrl_timer); stmmac_set_eee_timer(priv, priv->hw, 0, eee_tw_timer); } mutex_unlock(&priv->lock); return false; } Don't you want to turn it of in here? Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel