From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78E89C433F5 for ; Fri, 1 Oct 2021 02:29:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 317E061A58 for ; Fri, 1 Oct 2021 02:29:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 317E061A58 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yznJi4OzCQPNu+gJE4+i9nkutkIAcirb1vYZJm1j6DU=; b=Saq4lD4CKKwulu kLgCE4BLZOu7PhoWy81nDKDZHP8GhzQAN3Rybl42JykZQrpZeC/e9Oe72xFrBuKdZAf0juT/tJDYr AKj9UzYP6o97ChXbPvH58R3uHOF7Oi9Q3Hapfjs8WvWjIAcUxCt1ubYzi1RdCwYOvIwOzLwnoDkIi ZTTvMqL0TcrzFjo0dAa5StnemtY/VxPPU9UkBkeOLXWziBy1Sv0Pq4MmZKYhMItMsBDhnKTfYKgKv vvB1d+YlvUiOcMJ7/bWwIdOrMoMS7AIPfcK7EYNS2f9TP696fq8vZAfh4tvUcz31SbBd9fe1ISNc4 9k+Gd0wGG0rJ5tXHMppg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mW8H0-00GT0X-7z; Fri, 01 Oct 2021 02:27:42 +0000 Received: from mail-pg1-x532.google.com ([2607:f8b0:4864:20::532]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mW8Gw-00GSzf-Ip for linux-arm-kernel@lists.infradead.org; Fri, 01 Oct 2021 02:27:40 +0000 Received: by mail-pg1-x532.google.com with SMTP id a73so5143556pge.0 for ; Thu, 30 Sep 2021 19:27:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=5Gsu3s/cPFpx5tYAdo48WldJH7gJHFENlkBX3ettNaE=; b=psZGAQbVmgnf6dmiIuFC+UvrGGv5BfchgcavgYaFajyp6xHhTTaKLxiTIxwf2KrIHo 3Hu1uPpZZyzYL3Na1yT1oHWHPUY76RJOhUP2kp3UKIrEtSNgLd/tWGXYlvrStK0aty4o y0d6Cy8+zjfuh0Tsde0lU0BzOGsuxflqbJ0wDuq1xyt4rIQlfll3BHN9JVDSIFoAPZQ1 pB1SsyShMXcVEcFyHPIYM6dCIZxCKTIGtRd/0N3X4SO/I5KqpuSGjGfBgamRpj/dOREU Kj80mHaOnmHjIvhaXqt6c6dgLPwrYoMMXmgk1tmAMxCOgMsv5Oet56gohdwPqXcGh7Ja Y4Rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=5Gsu3s/cPFpx5tYAdo48WldJH7gJHFENlkBX3ettNaE=; b=CREjVk6fcXo/nRA4raeylunqNhpSH5orlA7bICQ6IRMOAhXx6bd7VTuRt+6msV262J KEPQkrfXtn26VPzmhgl5DESp3jN6mRhknedCdu+PDNnapl6NjX98cd3iIXgcI+pP5Cmp 0PB2RbODjTIsjKjjVU423lWKgt4EeDpeLb7Dw9PAt6egFakhaAbjkxgLYJLBU763rVun R0uU+TpKlO5HNwR/CpzD4d6OChwQVhYrOj5q3jUNCgtojkaTAaa/XlPofVqiRJMWucI7 T/9dUMmoj0lVAnPA2KIJYAWHkDfxnsLLbg20+kCQ1IGYMkEJgYyZB0u5fVdS9G7/R9sj RqZQ== X-Gm-Message-State: AOAM532b390PXJvt//gPAUxBni0TfIQzSd5MaZA/ef47iRAhx9xOqE1l qnY1afX5R2tCOfm34Fo66A== X-Google-Smtp-Source: ABdhPJyMiCGNbtba0w/oYo9BAwgO8IzYD70Y1GaFdsq4wYzPZ4/2MrelTIeazLfzj+Ez4IzJzBeB1w== X-Received: by 2002:a63:555d:: with SMTP id f29mr7792019pgm.33.1633055253779; Thu, 30 Sep 2021 19:27:33 -0700 (PDT) Received: from piliu.users.ipa.redhat.com ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id y13sm3890061pjm.5.2021.09.30.19.27.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Sep 2021 19:27:31 -0700 (PDT) Date: Fri, 1 Oct 2021 10:27:24 +0800 From: Pingfan Liu To: Mark Rutland Cc: linux-arm-kernel@lists.infradead.org, "Paul E. McKenney" , Catalin Marinas , Will Deacon , Marc Zyngier , Joey Gouly , Sami Tolvanen , Julien Thierry , Thomas Gleixner , Yuichi Ito , linux-kernel@vger.kernel.org Subject: Re: [PATCHv3 2/3] arm64: entry: refactor EL1 interrupt entry logic Message-ID: References: <20210930131708.35328-1-kernelfans@gmail.com> <20210930131708.35328-3-kernelfans@gmail.com> <20210930140058.GD18258@lakrids.cambridge.arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210930140058.GD18258@lakrids.cambridge.arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210930_192738_668712_DE9C5DA4 X-CRM114-Status: GOOD ( 22.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 30, 2021 at 03:00:59PM +0100, Mark Rutland wrote: > On Thu, Sep 30, 2021 at 09:17:07PM +0800, Pingfan Liu wrote: > > From: Mark Rutland > > > > Currently we distinguish IRQ and definitely-PNMI at entry/exit time > > via the enter_el1_irq_or_nmi() and enter_el1_irq_or_nmi() helpers. In > > subsequent patches we'll need to handle the two cases more distinctly > > in the body of the exception handler. > > > > To make this possible, this patch refactors el1_interrupt to be a > > top-level dispatcher to separate handlers for the IRQ and PNMI cases, > > removing the need for the enter_el1_irq_or_nmi() and > > exit_el1_irq_or_nmi() helpers. > > > > Note that since arm64_enter_nmi() calls __nmi_enter(), which > > increments the preemt_count, we could never preempt when handling a > > PNMI. We now only check for preemption in the IRQ case, which makes > > this clearer. > > > > There should be no functional change as a result of this patch. > > > > Signed-off-by: Mark Rutland > > Cc: "Paul E. McKenney" > > Cc: Catalin Marinas > > Cc: Will Deacon > > Cc: Marc Zyngier > > Cc: Joey Gouly > > Cc: Sami Tolvanen > > Cc: Julien Thierry > > Cc: Thomas Gleixner > > Cc: Yuichi Ito > > Cc: Pingfan Liu > > Cc: linux-kernel@vger.kernel.org > > To: linux-arm-kernel@lists.infradead.org > > As a heads-up, you need to add your Signed-off-by tag when you post > patches from other people, even if you make no changes. See: > > https://www.kernel.org/doc/html/v5.14/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin > Oh, thanks and I realize it is a serious license issue. > Other than that, this looks fine to me. > Thank you very much. Regards, Pingfan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel