From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19644C433EF for ; Mon, 18 Oct 2021 17:41:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E0DB660F11 for ; Mon, 18 Oct 2021 17:41:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E0DB660F11 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mbopSABLDH7v1PLTmmjnvF+6BHuHFU++O4n28ySOVKg=; b=UYqjvgtJdxcs7u Pa89cL0eWB3XR/n74QPPNe60DgM4Any7Kbbtqa6IPVh1XJ2flJvBwEtReHQ5YMoB2SqYTe2pBDhKu 7TKMvR+GoFWmiEiaWcmjLo0maqzXNr8EzKmNtWU3V2BbrtTn3nAYz+BFU/bdAdo68ejI0PiTq2uDH hIG4hgraMu0VJPmoUCWnZjiDRhuFbq24H+V2DSoUL4C9bbQInsF/t8yruBC8OnxLEl4Ql+78v6zga NTncPgmBkkBVF3sYjUGLkx7MIbSKUF1KZ8PoJ2/sV0WZjn7gbaEk7aopIEjDaSNmgzQjbxPO8PcAP +90WLAO3YKFFABC383Sg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mcWcd-00GgLa-UR; Mon, 18 Oct 2021 17:40:28 +0000 Received: from mail-oi1-f175.google.com ([209.85.167.175]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mcWca-00GgKg-2c for linux-arm-kernel@lists.infradead.org; Mon, 18 Oct 2021 17:40:25 +0000 Received: by mail-oi1-f175.google.com with SMTP id r64so819262oih.8 for ; Mon, 18 Oct 2021 10:40:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=WjCdoPbhUwOU2BPjJvdVK3b+6xDTrV2zEbWC1uYUtaY=; b=MR2uFcnN1s9A/5GVlHOqeDjmvdzRhRNDkWi17Kgwpr0HOPUKSXy0WqWBCcQ2KPpksZ 6XGVung7QvIiYc3q1M/5Owcs3fhRNPWBkDS+CCapggw7MNMs62OCl6xXmgfQBo93KPnx p2eNRs9/6TM/m1PM33Tw38rcMPo3TnuWXekWEGz/vc+Q6O5St+9qiPfMg3aQgomAIHcJ Eancgmtsu4cClAlgauXQ4tKt72Ss2SBpgYjL6Qe7bwcDtIqe4Ahxla0TfkmPl/qLOyQm Z9P2vMduuanqNM7XFy3OX+iBQOIyPuBB4HUMEzibMNLjF0cmXb6FGAtoaFcRVTvs3G26 1hjw== X-Gm-Message-State: AOAM5321QNF0RcqVTZJSQ6rmWFumz5hMuBf0Ia1CJlbcAuAphpQHh67J DKHNXcUBIjSLJoR8Hd1j9g== X-Google-Smtp-Source: ABdhPJwoJ4rchmQWhDHqPkxTSK7hUZqnNUE76P6zsjk0M22Dwy50hrUbpkkDsR3nSNZfVB6NrdZXcA== X-Received: by 2002:a05:6808:5d5:: with SMTP id d21mr227760oij.104.1634578823296; Mon, 18 Oct 2021 10:40:23 -0700 (PDT) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id c3sm3189302otr.42.2021.10.18.10.40.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Oct 2021 10:40:22 -0700 (PDT) Received: (nullmailer pid 2625572 invoked by uid 1000); Mon, 18 Oct 2021 17:40:21 -0000 Date: Mon, 18 Oct 2021 12:40:21 -0500 From: Rob Herring To: Etienne Carriere Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sudeep Holla , Cristian Marussi , Vincent Guittot , devicetree@vger.kernel.org Subject: Re: [PATCH v3 1/2] dt-bindings: arm: Add OP-TEE transport for SCMI Message-ID: References: <20211018114046.25571-1-etienne.carriere@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211018114046.25571-1-etienne.carriere@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211018_104024_149987_973E39FD X-CRM114-Status: GOOD ( 20.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Oct 18, 2021 at 01:40:45PM +0200, Etienne Carriere wrote: > Introduce compatible "linaro,scmi-optee" for SCMI transport channel > based on an OP-TEE service invocation. The compatible mandates a > channel ID defined with property "linaro,optee-channel-id". > > Cc: devicetree@vger.kernel.org > Cc: Rob Herring > Signed-off-by: Etienne Carriere > --- > Changes since v2: > - Define mandatory property linaro,optee-channel-id > - Rebased on yaml description file > > Changes since v1: > - Removed modification regarding mboxes property description. > --- > .../bindings/firmware/arm,scmi.yaml | 44 +++++++++++++++++++ > 1 file changed, 44 insertions(+) > > diff --git a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > index 5c4c6782e052..12154ecc081b 100644 > --- a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > +++ b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml > @@ -38,6 +38,9 @@ properties: > The virtio transport only supports a single device. > items: > - const: arm,scmi-virtio > + - description: SCMI compliant firmware with OP-TEE transport > + items: > + - const: linaro,scmi-optee > > interrupts: > description: > @@ -83,6 +86,11 @@ properties: > description: > SMC id required when using smc or hvc transports > > + linaro,optee-channel-id: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + Channel id required when using OP-TEE transports > + > protocol@11: > type: object > properties: > @@ -195,6 +203,9 @@ patternProperties: > minItems: 1 > maxItems: 2 > > + linaro,optee-channel-id: > + maxItems: 1 Why is the same property in 2 different spots? That doesn't seem ideal. Unfortunately, you have to duplicate the definition. > + > required: > - reg > > @@ -226,6 +237,16 @@ else: > - arm,smc-id > - shmem > > + else: > + if: > + properties: > + compatible: > + contains: > + const: linaro,scmi-optee > + then: > + required: > + - linaro,optee-channel-id > + > examples: > - | > firmware { > @@ -340,7 +361,30 @@ examples: > reg = <0x11>; > #power-domain-cells = <1>; > }; > + }; > + }; > + > + - | > + firmware { > + scmi { > + compatible = "linaro,scmi-optee"; > + linaro,optee-channel = <0>; > + > + #address-cells = <1>; > + #size-cells = <0>; > + > + scmi_clk: protocol@14 { > + reg = <0x14>; > + #clock-cells = <1>; > + }; > + > + scmi_dvfs: protocol@13 { > + reg = <0x13>; > > + #clock-cells = <1>; > + linaro,optee-channel = <1>; > + shmem = <&cpu_scp_hpri0>; > + }; > }; > }; > > -- > 2.17.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel