From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59CCCC433F5 for ; Wed, 20 Oct 2021 00:45:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 08C8360FC2 for ; Wed, 20 Oct 2021 00:45:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 08C8360FC2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=O04KzoGXYRVF4CTU+HBoI21xG+VTiyVHnE4smtOml9Y=; b=TXl9GiaaHuokBV d2YDaX0P5S+BIvVBjwmd/oPnVzpZ0wDHlwScRAi51pDARWlwPHs9R+wYjhBXCrMfqLuXhQtY+cSvH GJGeIQrq7wtem8eOCVJG0UUmyrM9BoCXWjjbz2bliNpSx+UhIVbHBFoVWXi7hRykIABs8ARYuI/E5 IsKYCJbmQNPdVQlOIVJUFilcMenzQCCd1mKOOaCgI7zzbaL3aBnctv+1fQjeqU/uufsEMu341QZby oQnOhFnFtEvbxNHVREmzaHjyc0z5ukF7xqBXVI0YAbo8H46rYUxe/NWTFR91V1yCD14P8PlEnYyYs g4pUSaFAZJudha16vumQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mczi5-0034l1-Dr; Wed, 20 Oct 2021 00:44:01 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mczi1-0034kU-S1 for linux-arm-kernel@lists.infradead.org; Wed, 20 Oct 2021 00:43:59 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9992260FC2; Wed, 20 Oct 2021 00:43:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1634690637; bh=V4ph25lcqZI+SXf9l4Jn+tmIyHyFXeQV6USdcgKzILo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sXKg7H+2O9ebtqUXEQiwuP/ASR/7fX4uSbKPsxWNeildN8Ggq3dOv2DsIk0wEZNJn 0Qum17SoRf2DzkOVKd9gRWQhk7/+jXZxr957GJTvMKqDrmENweY5f1+O9gZhcjn8rk 4mTAOLlB2qfJfkXXYK5fcxqzGjSbgP4YALfwRzflxH9Q+XN4isCmeq1VkwgEKoEYm7 /fSOOINtb25AxtlLtwCbl5TbQl0s859Z+GhjTP6br4qg4bWMrf7RBpfajH5yfLG80i IZ424L7YP5lEJNnOCrsEfA5Q8XQ+nU1+AjHuhA6HMiZeW2/pR3v0RsPG5YRsBnRzYS HF3WLlrEmtMTQ== Date: Tue, 19 Oct 2021 17:43:51 -0700 From: Nathan Chancellor To: Nick Desaulniers Cc: Catalin Marinas , Will Deacon , llvm@lists.linux.dev, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Vincenzo Frascino , Arnd Bergmann Subject: Re: [PATCH v2 2/4] arm64: vdso32: drop test for -march=armv8-a Message-ID: References: <20211019223646.1146945-1-ndesaulniers@google.com> <20211019223646.1146945-3-ndesaulniers@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211019223646.1146945-3-ndesaulniers@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211019_174357_955992_BBC1D3E3 X-CRM114-Status: GOOD ( 15.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Oct 19, 2021 at 03:36:44PM -0700, Nick Desaulniers wrote: > As Arnd points out: > gcc-4.8 already supported -march=armv8, and we require gcc-5.1 now, so > both this #if/#else construct and the corresponding > "cc32-option,-march=armv8-a" check should be obsolete now. > > Link: https://lore.kernel.org/lkml/CAK8P3a3UBEJ0Py2ycz=rHfgog8g3mCOeQOwO0Gmp-iz6Uxkapg@mail.gmail.com/ > Suggested-by: Arnd Bergmann > Signed-off-by: Nick Desaulniers Reviewed-by: Nathan Chancellor > --- > arch/arm64/include/asm/vdso/compat_barrier.h | 7 ------- > arch/arm64/kernel/vdso32/Makefile | 8 +------- > 2 files changed, 1 insertion(+), 14 deletions(-) > > diff --git a/arch/arm64/include/asm/vdso/compat_barrier.h b/arch/arm64/include/asm/vdso/compat_barrier.h > index fb60a88b5ed4..3ac35f4a667c 100644 > --- a/arch/arm64/include/asm/vdso/compat_barrier.h > +++ b/arch/arm64/include/asm/vdso/compat_barrier.h > @@ -20,16 +20,9 @@ > > #define dmb(option) __asm__ __volatile__ ("dmb " #option : : : "memory") > > -#if __LINUX_ARM_ARCH__ >= 8 > #define aarch32_smp_mb() dmb(ish) > #define aarch32_smp_rmb() dmb(ishld) > #define aarch32_smp_wmb() dmb(ishst) > -#else > -#define aarch32_smp_mb() dmb(ish) > -#define aarch32_smp_rmb() aarch32_smp_mb() > -#define aarch32_smp_wmb() dmb(ishst) > -#endif > - > > #undef smp_mb > #undef smp_rmb > diff --git a/arch/arm64/kernel/vdso32/Makefile b/arch/arm64/kernel/vdso32/Makefile > index 89299a26638b..1407516e041e 100644 > --- a/arch/arm64/kernel/vdso32/Makefile > +++ b/arch/arm64/kernel/vdso32/Makefile > @@ -65,13 +65,7 @@ endif > # From arm vDSO Makefile > VDSO_CAFLAGS += -fPIC -fno-builtin -fno-stack-protector > VDSO_CAFLAGS += -DDISABLE_BRANCH_PROFILING > - > - > -# Try to compile for ARMv8. If the compiler is too old and doesn't support it, > -# fall back to v7. There is no easy way to check for what architecture the code > -# is being compiled, so define a macro specifying that (see arch/arm/Makefile). > -VDSO_CAFLAGS += $(call cc32-option,-march=armv8-a -D__LINUX_ARM_ARCH__=8,\ > - -march=armv7-a -D__LINUX_ARM_ARCH__=7) > +VDSO_CAFLAGS += -march=armv8-a > > VDSO_CFLAGS := $(VDSO_CAFLAGS) > VDSO_CFLAGS += -DENABLE_COMPAT_VDSO=1 > -- > 2.33.0.1079.g6e70778dc9-goog > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel