From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 437E2C433EF for ; Mon, 11 Oct 2021 16:25:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 063A760E8B for ; Mon, 11 Oct 2021 16:25:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 063A760E8B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=alien8.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qFkI4vVDRd7zmO3DSipKX/El2GtLztk8RDuEtAnsZic=; b=fhopUpPCpUeStJ HARb/RavOx0DD5/S0z2s+y6gCN0/8jSSPvE1hIynlFNQTjiPZqxfZ3ebqnnIqGg6MOeoWX8YBVTTE jqap2JZU2nIm3yNzNFpt5JdKei7tJsefbVQ4GwZdsdiIZPYKpC6EGfn5XL6+qGiGx/90MV8WjKhsg BmOUPqQfmmmvjR7Toexa6UbR0i9izIsqUNbC1pbDzrbPj7DN+M3risz2zz9fabww/lpVzrzk8XWLH W4dSbU5XmhXMQ+pV6RZSHIUb0Z8Y6KmYVIuP8V8vq1eQP7FNSLacRJnNkVN164+/OWx7kyFZL+JrM 5RmsXxyme43zZx/9/AAA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mZy5V-00A5WL-HU; Mon, 11 Oct 2021 16:23:41 +0000 Received: from mail.skyhub.de ([2a01:4f8:190:11c2::b:1457]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mZy5R-00A5Vk-3J for linux-arm-kernel@lists.infradead.org; Mon, 11 Oct 2021 16:23:38 +0000 Received: from zn.tnic (p200300ec2f08bb0030636ca0dab1dbfc.dip0.t-ipconnect.de [IPv6:2003:ec:2f08:bb00:3063:6ca0:dab1:dbfc]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 9BC1A1EC03CA; Mon, 11 Oct 2021 18:23:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1633969414; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=tSm9jf94PmL4XEwSBV/yP6piPnrq638nfyV8/qTI/6g=; b=UvABe+xtZyBfGqYegcgX4vWmRppTbCWJlWGD+yTluNiWmN3LKRfqxkzzRqlXBHDgSKsNlO guAQYlPXfsGLf1BPOjfFep9JmROjWUlcffiTSUht0sLz9reByfmhpmrLs0428FdknBo2rN sDmWBWMFM6jyR9c4mE2Ogxk5F7iU9pg= Date: Mon, 11 Oct 2021 18:23:35 +0200 From: Borislav Petkov To: Liguang Zhang Cc: "Rafael J. Wysocki" , Len Brown , James Morse , Tony Luck , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] ACPI / APEI: restore interrupt before panic in sdei flow Message-ID: References: <20211011151028.105215-1-zhangliguang@linux.alibaba.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211011151028.105215-1-zhangliguang@linux.alibaba.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211011_092337_322333_88566982 X-CRM114-Status: GOOD ( 10.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Oct 11, 2021 at 11:10:28PM +0800, Liguang Zhang wrote: > We use ACPI_HEST_NOTIFY_SOFTWARE_DELEGATED Notify type for ras event. > > In ATF: > ehf_activate_priority() > dispatch sdei() > ehf_deactivate_priority() > > If ras error severity is fatal, panic was called in sdei(), > ehf_deactivate_priority was not called. we should restore interrupt before panic > otherwise kdump will trigger error. I have *absolutely* no clue what this commit message is trying to tell me - sorry you'd have to try again. Maybe structuring it this way, would help: -- Problem is A. It happens because of B. Fix it by doing C. (Potentially do D). For more detailed info, see Documentation/process/submitting-patches.rst, Section "2) Describe your changes". Also, to the tone, from Documentation/process/submitting-patches.rst: "Describe your changes in imperative mood, e.g. "make xyzzy do frotz" instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy to do frotz", as if you are giving orders to the codebase to change its behaviour." Also, do not talk about what your patch does - that should hopefully be visible in the diff itself. Rather, talk about *why* you're doing what you're doing. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel