From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D601C433EF for ; Tue, 12 Oct 2021 14:11:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EDD6860EFE for ; Tue, 12 Oct 2021 14:10:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org EDD6860EFE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1LrADSnvDkdM+IapMIHYqmmhrFQXxQy659uBV09m7FU=; b=WK8AFVSt1UxsM3 bnpAeV3wdaK0U08ms8tPzN6L+ddZYzxu2JZhAoxqDc266V5PEB8YiVknQZwckhN+XN2iLaxeka0oK fcYLf+pIIC6C/RXSiWZ5NjVxA97yyGwVnbqQZuE1dFZ4xlKNS2hJf9DzFpLwHBlBJ3XZnhDYpVmCC AJjzD17MeDzuP+myGz+juvpxT0mRBaHoBvYR9vf0OGxxu59sZbpkV4VJjUk47kFccFxrM6A/IMGii jPyLhOwy2ZlSumYUmNEeNgwHyObfhrXbHkuxLdhV5VYf1bOIHEVcRTyVCnTiYjO3e6Gsrvco2yd6i +lSxERF9UMXE55XgpIXQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1maISd-00D8bl-5u; Tue, 12 Oct 2021 14:08:55 +0000 Received: from mail-oo1-f49.google.com ([209.85.161.49]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1maISY-00D8ZA-Ay for linux-arm-kernel@lists.infradead.org; Tue, 12 Oct 2021 14:08:51 +0000 Received: by mail-oo1-f49.google.com with SMTP id w9-20020a4adec9000000b002b696945457so5939857oou.10 for ; Tue, 12 Oct 2021 07:08:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=RMaXnYUhymrRYD9WfHd3vRjeCksk/ibqC+WFGIs70ao=; b=rhqnu57M9af+k5yNeKezLZguBEUyl5I8QV0BGFBPOkPEC21KBKdj8QUP02Wu4x+sCB y/ifQZP3haIdponup9ogbsIyOw2sR3/b4dgi0j/HuXnQHO3xxTV44wuk7mmCtGXJqFYd Q4XJRJGw3+clQAX+jaf1spwRCDHtaHUgNcV+sFzaeeMSPwFE/kdD6Qketn1KiG5CNTJh BqBpSdsEhNwfQSJ7sS5J/tDWTT8xk1MlkpyFlTKld3EQ4ByyM/JtP+dtm9fjDiG5l47W lBbb2zwxpiv+O5gLuxZF04hA6JUSUImPgOn0GsLfm8hUpEEg4WFlfpOBn79F7D67VeiV Nj6w== X-Gm-Message-State: AOAM530SzxXeEFzJ6PTmKBSfapXZGd8HIxUX5qnYGCqjxQkkg3hnHTdg RDeQhxNBUZ/lVq/mcHsWpQ== X-Google-Smtp-Source: ABdhPJzTJvvGTrmKrIm34n8gw9Ui7MkZ61v7NTftC8k97j3d2O33sg9Q7kkFkw07M9HEOZAz1PN20w== X-Received: by 2002:a4a:2a51:: with SMTP id x17mr23507999oox.21.1634047723952; Tue, 12 Oct 2021 07:08:43 -0700 (PDT) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id e11sm2330094oii.0.2021.10.12.07.08.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Oct 2021 07:08:43 -0700 (PDT) Received: (nullmailer pid 2731186 invoked by uid 1000); Tue, 12 Oct 2021 14:08:42 -0000 Date: Tue, 12 Oct 2021 09:08:42 -0500 From: Rob Herring To: Maxime Ripard Cc: Chen-Yu Tsai , Jernej =?utf-8?Q?=C5=A0krabec?= , Frank Rowand , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-sunxi@lists.linux.dev, "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org, Linus Walleij Subject: Re: [RESEND v2 1/4] dt-bindings: bluetooth: broadcom: Fix clocks check Message-ID: References: <20210924072756.869731-1-maxime@cerno.tech> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210924072756.869731-1-maxime@cerno.tech> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211012_070850_409389_27992717 X-CRM114-Status: GOOD ( 24.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Sep 24, 2021 at 09:27:53AM +0200, Maxime Ripard wrote: > The original binding was mentioning that valid values for the clocks and > clock-names property were one or two clocks from extclk, txco and lpo, > with extclk being deprecated in favor of txco. > > However, the current binding lists a valid array as extclk, txco and > lpo, with either one or two items. > > While this looks similar, it actually enforces that all the device trees > use either ["extclk"], or ["extclk", "txco"]. That doesn't make much > sense, since the two clocks are said to be equivalent, with one > superseeding the other. > > lpo is also not a valid clock anymore, and would be as the third clock > of the list, while we could have only this clock in the previous binding > (and in DTs). > > Let's rework the clock clause to allow to have either: > > - extclk, and mark it a deprecated > - txco alone > - lpo alone > - txco, lpo > > While ["extclk", "lpo"] wouldn't be valid, it wasn't found in any device > tree so it's not an issue in practice. > > Similarly, ["lpo", "txco"] is still considered invalid, but it's > generally considered as a best practice to fix the order of clocks. > > Cc: "David S. Miller" > Cc: Jakub Kicinski > Cc: netdev@vger.kernel.org > Reviewed-by: Linus Walleij > Reviewed-by: Rob Herring > Signed-off-by: Maxime Ripard > --- > .../bindings/net/broadcom-bluetooth.yaml | 17 +++++++++++++++-- > 1 file changed, 15 insertions(+), 2 deletions(-) I've applied this and the rest of the series. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel