From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6754AC433EF for ; Tue, 12 Oct 2021 18:19:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3745560C4B for ; Tue, 12 Oct 2021 18:19:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3745560C4B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZJLhLFgcxduWmsvAga6cz0CgKPdTzpr0evKE4+WZ79o=; b=os51+IZSVH9LQn dxN/jLMuDE1NFEi+AOcSxXYIh3VDEYcQstOrjPlJolCTWZRCHr1VR47lhSP4Eg5inhM4DdaBMkBE2 zJZm568KXIim2T72Vwc05UZQ9Yem2uQ+TKUyw/mnyoz2w/PJMPRovam5Afc9YnMApPeLbPuQ6cJCw OSEmdRK9xStj5xK48NdXkPNvnN2fZOqMuwZm5JcIp+Adr8UXv5uPuvdiGSV3BEIBFi+eYStgvi0Vi JloFKNGYxIyunXcFATMfmggmiQ+9s99l7GQrMUBnsaL3XjCYkr2ClhWbQYZPUmP06miR28yju2mEP m+ET+Pt7rPQQiyvd3JxQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1maML2-00DiZ1-K8; Tue, 12 Oct 2021 18:17:20 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1maMKz-00DiYa-Ny for linux-arm-kernel@lists.infradead.org; Tue, 12 Oct 2021 18:17:19 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7A93560462; Tue, 12 Oct 2021 18:17:15 +0000 (UTC) Date: Tue, 12 Oct 2021 19:17:12 +0100 From: Catalin Marinas To: Kefeng Wang Cc: will@kernel.org, ryabinin.a.a@gmail.com, andreyknvl@gmail.com, dvyukov@google.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, elver@google.com, akpm@linux-foundation.org, gregkh@linuxfoundation.org, kasan-dev@googlegroups.com Subject: Re: [PATCH v4 3/3] kasan: arm64: Fix pcpu_page_first_chunk crash with KASAN_VMALLOC Message-ID: References: <20210910053354.26721-1-wangkefeng.wang@huawei.com> <20210910053354.26721-4-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210910053354.26721-4-wangkefeng.wang@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211012_111717_820482_AC3BF8AD X-CRM114-Status: GOOD ( 12.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Sep 10, 2021 at 01:33:54PM +0800, Kefeng Wang wrote: > With KASAN_VMALLOC and NEED_PER_CPU_PAGE_FIRST_CHUNK, it crashs, > > Unable to handle kernel paging request at virtual address ffff7000028f2000 > ... > swapper pgtable: 64k pages, 48-bit VAs, pgdp=0000000042440000 > [ffff7000028f2000] pgd=000000063e7c0003, p4d=000000063e7c0003, pud=000000063e7c0003, pmd=000000063e7b0003, pte=0000000000000000 > Internal error: Oops: 96000007 [#1] PREEMPT SMP > Modules linked in: > CPU: 0 PID: 0 Comm: swapper Not tainted 5.13.0-rc4-00003-gc6e6e28f3f30-dirty #62 > Hardware name: linux,dummy-virt (DT) > pstate: 200000c5 (nzCv daIF -PAN -UAO -TCO BTYPE=--) > pc : kasan_check_range+0x90/0x1a0 > lr : memcpy+0x88/0xf4 > sp : ffff80001378fe20 > ... > Call trace: > kasan_check_range+0x90/0x1a0 > pcpu_page_first_chunk+0x3f0/0x568 > setup_per_cpu_areas+0xb8/0x184 > start_kernel+0x8c/0x328 > > The vm area used in vm_area_register_early() has no kasan shadow memory, > Let's add a new kasan_populate_early_vm_area_shadow() function to populate > the vm area shadow memory to fix the issue. > > Acked-by: Marco Elver (for KASAN parts) > Acked-by: Andrey Konovalov (for KASAN parts) > Signed-off-by: Kefeng Wang It looks like I only acked patch 2 previously, so here it is: Acked-by: Catalin Marinas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel