From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C968EC433EF for ; Sun, 31 Oct 2021 21:30:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8C0D960F45 for ; Sun, 31 Oct 2021 21:30:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8C0D960F45 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=grimler.se Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=X3v0c10uPnSe0brYViH5xKLQW/GiZYKQ5JrP0vZxEfw=; b=SsDeuXEHaObo/h S/iXhYYTS6uam78O/m97+BHFAzsMyTUJFdmAXu+SpvP3hBJgqYbKBpl1PPHjbBPfullzVQc4VnkMV oZdafjXE2esJqr8fF48ILDNSVSfS6nccc95z2n+ZWEHSaIamW/ZoRXGXEjBxMNGAE7Fp7BLdjZdRk XnxgOcPfe6uwefNb1fMpDB3Enc/8uqSzPmitCsOZtecUFpJ9tRVRTdI6IQ+XCNrt2G1F5kuW4B2AY w0jV+Wvt9spo5EIv9m2ShfOgcmpMlj91PQEA7l/U7P/QZ/JmZwgXVFV0grDieOhHqGQAe7SkcWCqp YoSgnePEdw6zYbENMWog==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mhIO5-00Ek4P-Rf; Sun, 31 Oct 2021 21:29:10 +0000 Received: from h01mx22.reliablemail.org ([198.20.92.92]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mhIO1-00Ek32-AF for linux-arm-kernel@lists.infradead.org; Sun, 31 Oct 2021 21:29:07 +0000 X-Halon-Out: 913ccb05-3a91-11ec-90dc-00163c81f1a9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=grimler.se; s=default; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=JeCHttEry3ORV5FIx1XciXwxFlHv3MV3D9HY2sgigoo=; b=CEw1tmR7b5zVP8DGoDmP1A97og kUwEsjE1udsGkb6Zq5XwEln1Q1L7AwXRxc+vrlawbk4eOHRDmCn1/KdKkASa5aXsZ9vXCNkThCD18 R9vUlflwIrNeh3p0fT94eREqj4aiu3/62wSyz7g0BPNTjz70uingA/T6EfXu2yVXC/56EUhzmw6Xv GRiVJBhPH7XGHb1uL6GVBDe/YjWF5KoZRqduCYVUpcX9EloW0Q6ifCtFWuxeQ6TEBw22uK5aW9duw 6lz88fISCqlxz+XI1PkxLDKkXp8P1NtBE+ZSpiuNopmFfFESQzS77TF4jyIZFUE65q+nxNbd2l143 FGyBGCjg==; Date: Sun, 31 Oct 2021 22:29:00 +0100 From: Henrik Grimler To: Krzysztof Kozlowski Cc: chanho61.park@samsung.com, semen.protsenko@linaro.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH 1/2] soc: samsung: exynos-chipid: print entire PRO_ID reg when probing Message-ID: References: <20211031165645.1182368-1-henrik@grimler.se> <878a4657-c68a-743e-7c89-bf69b416b824@canonical.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <878a4657-c68a-743e-7c89-bf69b416b824@canonical.com> X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cpsrv07.misshosting.com X-AntiAbuse: Original Domain - lists.infradead.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - grimler.se X-Get-Message-Sender-Via: cpsrv07.misshosting.com: authenticated_id: henrik@grimler.se X-Authenticated-Sender: cpsrv07.misshosting.com: henrik@grimler.se X-Source: X-Source-Args: X-Source-Dir: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211031_142905_567028_17E2C9F4 X-CRM114-Status: GOOD ( 16.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Sun, Oct 31, 2021 at 09:35:20PM +0100, Krzysztof Kozlowski wrote: > On 31/10/2021 17:56, Henrik Grimler wrote: > > Older Exynos socs has one reg PRO_ID containing both product id and > > revision information. Newer Exynos socs has one Product_ID reg with > > product id, and one CHIPID_REV reg with revision information. > > > > In commit c072c4ef7ef0 ("soc: samsung: exynos-chipid: Pass revision > > reg offsets") the driver was changed so that the revision part of > > PRO_ID is masked to 0 when printed during probing. This can give a > > false impression that the revision is 0, so lets change so entire > > PRO_ID reg is printed again. > > > > Signed-off-by: Henrik Grimler > > --- > > Has been tested on exynos4412-i9300, which is compatible with > > exynos4210-chipid, and on an exynos8895 device compatible with > > exynos850-chipid. > > --- > > Hi, > > Thanks for the patch. > > I miss here however the most important information - why do you need it? > The answer to "why" should be in commit msg. In dmesg we currently print something like: Exynos: CPU[EXYNOS4412] PRO_ID[0xe4412000] REV[0x11] Detected where PRO_ID is given in datasheet as: [31:12] Product ID [9:8] Package information [7:4] Main Revision Number [3:0] Sub Revision Number By printing PRO_ID[0xe4412000] it gives the impression that Package information, Main Revision Number and Sub Revision Number are all 0. > The change was kind of intentional and accepted, because revision ID is > printed next to the product ID. Printing revision ID with product ID > could be confusing... Sure, I see the reason for only printing the product id. Would you accept a patch write Product_ID instead of PRO_ID in the printed message? So that we print: Exynos: CPU[EXYNOS4412] Product_ID[0xe4412000] REV[0x11] Detected There's then less room for confusion regarding the revision, since Product_ID should contain only the Product ID, unlike PRO_ID which should contain both Product ID and revision info. > Best regards, > Krzysztof Best regards, Henrik Grimler _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel