From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3177C4332F for ; Thu, 21 Oct 2021 13:00:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 93F2261186 for ; Thu, 21 Oct 2021 13:00:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 93F2261186 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FHzPSbwFlopD8ftKiAynFQ1w6nHRswxB1afJcG06SaA=; b=lLjxhW9hMtAEx8 oiifDWIDVyD7QXcv0iN1n/yVl4OpxA7ANlQxkV1FOZwd3KoYOzVfcweo7yXjJabgEPnKrHQ+Pk+0w mRCjCnFLdoZP0IDrrYT5HAOh6r0OTlU2T+UUf1ylc9XxAbQSDuQh4nhS4ATIYWGAkviDVY7ie7Fub y+155unYsaVN5kulxXnt/VyIBsgDetoFRs0h+w87NWTOvh0JQfx21Mn2i65Jl3+wlPvtzfRC7Xkme X8dbYYLLXaagbUFi56sEKS0wcJwyTsDdLqcrB4ao/hMf/2C/PzTcX7y9DLB1W4a/qscAxEkonXkyQ iSI/+y8ZfN5ztSspxyiQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mdXew-007aEe-2j; Thu, 21 Oct 2021 12:59:02 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mdXes-007aE0-NP for linux-arm-kernel@lists.infradead.org; Thu, 21 Oct 2021 12:58:59 +0000 Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 5524380EB; Thu, 21 Oct 2021 12:59:31 +0000 (UTC) Date: Thu, 21 Oct 2021 15:58:56 +0300 From: Tony Lindgren To: Lukas Bulwahn Cc: linux-arm-kernel@lists.infradead.org, Russell King , Linux Kernel Mailing List , linux-omap@vger.kernel.org Subject: Re: Non-existing config symbols DEBUG_OMAP{3,4,5}UART{1,2} Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211021_055858_829272_6F600D1E X-CRM114-Status: GOOD ( 20.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, * Lukas Bulwahn [211011 05:39]: > Dear Tony, > > With commit d2b310b0234c ("ARM: debug: Use generic 8250 debug_ll for > omap2 and omap3/4/5 common uarts"), you added address definitions of > DEBUG_UART_PHYS for OMAP2, OMAP3, OMAP4 and OMAP5 in > ./arch/arm/Kconfig.debug. > > These definitions depend on: > - DEBUG_OMAP2UART1 || DEBUG_OMAP3UART1 || DEBUG_OMAP4UART1 || > DEBUG_OMAP5UART1, and > - DEBUG_OMAP2UART2 || DEBUG_OMAP3UART2 || DEBUG_OMAP4UART2 || > DEBUG_OMAP5UART2. > > As of now, only DEBUG_OMAP2UART{1,2} are defined in > ./arch/arm/Kconfig.debug, but DEBUG_OMAP{3,4,5}UART{1,2} are not > defined. Hence, ./scripts/checkkconfigsymbols.py warns here on > non-existing symbols. > > I am unsure about the best way to resolve this issue. > > - Would you like to simply reuse the config DEBUG_OMAP2UART{1,2} also > for OMAP3, OMAP4 and OMAP5? Then, we probably just need to delete the > dead references > to DEBUG_OMAP{3,4,5}UART{1,2}. If you consider this further change > helpful, we could even rename the configs to DEBUG_OMAP2PLUSUART{1,2} > to make the architecture more specific. > > - Do you see the need for separate config definitions for UART{1,2} on > OMAP3, OMAP4 and OMAP5? Then, we would need to add further definitions > DEBUG_OMAP{3,4,5}UART{1,2} > in this file and link those to the specific architecture. > > Once the direction is clear, I am happy to provide a patch to address > this issue or you can quickly take care of this yourself. The missing ones should be the same as the DEBUG_OMAP2 I think. We still have these defined in arch/arm/mach-omap2/include/mach/serial.h, so that can be used to confirm it. Seems like we can just reuse the DEBUG_OMAP2UART variants, not sure if we need to rename these to DEBUG_OMAP2PLUSUART variants. Regards, Tony _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel