From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90DD9C433F5 for ; Fri, 22 Oct 2021 04:52:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3CBF360240 for ; Fri, 22 Oct 2021 04:52:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3CBF360240 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kZ/e3EyDITjYgtae6slxDM7F1Ic4gAAioBXkvKUh+Lc=; b=a4DRTv5vXHoqDp DYHrRK8SPCYFPFR375xzLlHIkhi/g/JTXLhYxtnQ9a9XRkuNeKFSbutTpPtaFjtdN5VFOE8JZSuo+ Pcjh0SsMmUdxrq92rqLCO2S1Jlfi4rrNiEd5wKfTQmfJD2BpnwLOgHLB4pag+UP0NFQxSwlozZWrV NyS2ZrtTW/7rocznatsNH3rAJWWAJpdctK2LdR1dXjGAz8w28T2OTzUo79nHOGTskhRk52u5sDu3S pa50oNDsq/S6iYhIIG+PznjasZXAWm1FtDDu08VtEhWykC7j1JMbPsBl/R21ZoMJ0Wuh2Fmm7VLIi 1eG0b2EzDS4BRCNZbWzQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mdmT6-009j7H-NA; Fri, 22 Oct 2021 04:47:48 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mdmT2-009j61-DX for linux-arm-kernel@lists.infradead.org; Fri, 22 Oct 2021 04:47:46 +0000 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id E8BCB51D; Fri, 22 Oct 2021 06:47:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1634878060; bh=G7T6wZkmrWLHbctwp4ctx4alzTbYKzVDezqLPHMiKe0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=W/brV8VOxlPHQ0b1U9/XRwEUOyfHjdMY4JDujpx8mPXzYg5xVSgKfzmsKSAuwwwFy QOi7CMXVQ7mwa+GKOGLFLyNKrrXMlNLpJIrL3VLDjnF8Gc67OI6V9kqBUcNGppL4+D gjclIMtiN9UXtpkwcGjk4a6vBAYPf/e4cZ9qRLKU= Date: Fri, 22 Oct 2021 07:47:19 +0300 From: Laurent Pinchart To: Maxime Ripard Cc: Rob Herring , Frank Rowand , Chen-Yu Tsai , Jernej =?utf-8?Q?=C5=A0krabec?= , Daniel Vetter , David Airlie , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v5 1/7] of: Make of_graph_get_port_by_id take a const device_node Message-ID: References: <20210929084234.1271915-1-maxime@cerno.tech> <20210929084234.1271915-2-maxime@cerno.tech> <20211021074843.yxbzoasfyxmzmukf@gilmour> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211021074843.yxbzoasfyxmzmukf@gilmour> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211021_214744_655868_F2406B5D X-CRM114-Status: GOOD ( 20.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Maxime, On Thu, Oct 21, 2021 at 09:48:43AM +0200, Maxime Ripard wrote: > On Tue, Oct 19, 2021 at 03:02:13PM +0300, Laurent Pinchart wrote: > > On Wed, Sep 29, 2021 at 10:42:28AM +0200, Maxime Ripard wrote: > > > of_graph_get_port_by_id doesn't modify the device_node pointer it takes > > > as argument, so we can make it const. > > > > From a C point of view that's right, but conceptually speaking, is it > > right to return a non-const child port node of a const device_node ? > > I mean, I guess not, but you're the one that asked for it: > https://lore.kernel.org/dri-devel/YBAiztjg0Jji9voK@pendragon.ideasonboard.com/ Oops. Looks like I must be wrong with at least one of the two comments. Please pick the option you like best. > I can change it if you want, but certainly not if the only comment I get > on this series for the next year is going to be over whether or not > arguments of functions unrelated to the main intent should be constified > or not. DRM/KMS seems to suffer from a deficit of reviewers in all non-desktop areas :-( -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel