From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DD2DC433F5 for ; Sun, 24 Oct 2021 20:29:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 14D7C60FE8 for ; Sun, 24 Oct 2021 20:29:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 14D7C60FE8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CXPotDhYhm8iAplc6OKNZrV0B8R6DQrP4bAVEGw7ImY=; b=GSUSEYuqtW7GL/ n0KvpzemkbFvl7+suITPTXlRezpNXsfHenGOhw2r5jVOHBe7KLBrUlg/BmUXGxH8p5S3ILVUoQQxu bBB9AV0SSEWO7AFVaVDuPRV3ax8g2gTjuKY1wp2TyLPn2zCyDLTRXtiFWjOPkM9y4wbrMEfb/klO/ 1J0pBlVhucNNRg6LN/CH0SK68VRTINI54Hz5+1tRYptFBOFTGknlYWayQ7mA5+wdGKewHa6XRpNxA iNMBVjuZN0emQoDz7+5k8Ky7dxHc4leNXa12ZaxWIGahyul9cimzXexaJofRIUFnkwFaQdjeLu0Sa 07QQNoq0alMtXFxOY+4g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mek6O-00EaI7-MU; Sun, 24 Oct 2021 20:28:20 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mek6J-00EaEB-J5; Sun, 24 Oct 2021 20:28:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=8O9gkYAmFcVK2IsDTWyn2VcW39mplgtD5t4PDmHXu1U=; b=nSaHE3DkXdmeZ1O0lor5XmoZPe AW5ZCFNAxuvaGwR9xicRQr5bwZzNSKltIJlzzKIfb2B41sFIiWKNLHMxaykVDRj1MhManwnqgrj/S x9ZQedtZPEiyRNOygnlTPudecxV3ArZrm3/abUvlXCE5ztjj0qNfwUwjLOdeaytVsz4+BQmuUtfKu IfshdYkYPo3di9x0o2/Dswha1avGXlmWtX9n1EQwYW5XDl8OuvEs3VIR+MXA4vtI6SMeI7B4nhLi/ bCUHBXPGkqMQcySiXD1C4DcC1niCP7nlV+Bx4tLMqyIEP53flEsPKfa2yZXIi/Rn42ghwVnMeRJf4 FofPugpg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:55272) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mek49-0003Y2-8V; Sun, 24 Oct 2021 21:26:01 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1mek46-0003JU-0B; Sun, 24 Oct 2021 21:25:58 +0100 Date: Sun, 24 Oct 2021 21:25:57 +0100 From: "Russell King (Oracle)" To: "jason-jh.lin" Cc: Chun-Kuang Hu , Philipp Zabel , Matthias Brugger , Jassi Brar , Yongqiang Niu , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, hsinyi@chromium.org, fshao@chromium.org, nancy.lin@mediatek.com, singo.chang@mediatek.com Subject: Re: [PATCH] mailbox: remove the error message when gce clk is defer Message-ID: References: <20211023164831.25690-1-jason-jh.lin@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211023164831.25690-1-jason-jh.lin@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211024_132815_642531_F7842D35 X-CRM114-Status: GOOD ( 16.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Oct 24, 2021 at 12:48:31AM +0800, jason-jh.lin wrote: > Remove the error message when gce clk is defer. > > Signed-off-by: jason-jh.lin > --- > drivers/mailbox/mtk-cmdq-mailbox.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c > index fd5576a9f8b4..684b8aa1e445 100644 > --- a/drivers/mailbox/mtk-cmdq-mailbox.c > +++ b/drivers/mailbox/mtk-cmdq-mailbox.c > @@ -577,7 +577,8 @@ static int cmdq_probe(struct platform_device *pdev) > snprintf(clk_id, sizeof(clk_id), "%s%d", clk_name, alias_id); > cmdq->clocks[alias_id].id = clk_id; > cmdq->clocks[alias_id].clk = of_clk_get(node, 0); > - if (IS_ERR(cmdq->clocks[alias_id].clk)) { > + if (IS_ERR(cmdq->clocks[alias_id].clk) && > + PTR_ERR(cmdq->clocks[alias_id].clk) != -EPROBE_DEFER) { > dev_err(dev, "failed to get gce clk: %d\n", alias_id); > return PTR_ERR(cmdq->clocks[alias_id].clk); > } So when you get -EPROBE_DEFER, you omit the error message _and_ ignore the -EPROBE_DEFER. Is that really what you want to do? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel