* [PATCH] mailbox: remove the error message when gce clk is defer
@ 2021-10-23 16:48 jason-jh.lin
2021-10-24 20:25 ` Russell King (Oracle)
0 siblings, 1 reply; 3+ messages in thread
From: jason-jh.lin @ 2021-10-23 16:48 UTC (permalink / raw)
To: Chun-Kuang Hu, Philipp Zabel, Matthias Brugger, Jassi Brar,
Yongqiang Niu
Cc: David Airlie, Daniel Vetter, jason-jh . lin, dri-devel,
linux-mediatek, linux-arm-kernel, linux-kernel, hsinyi, fshao,
nancy.lin, singo.chang
Remove the error message when gce clk is defer.
Signed-off-by: jason-jh.lin <jason-jh.lin@mediatek.com>
---
drivers/mailbox/mtk-cmdq-mailbox.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c
index fd5576a9f8b4..684b8aa1e445 100644
--- a/drivers/mailbox/mtk-cmdq-mailbox.c
+++ b/drivers/mailbox/mtk-cmdq-mailbox.c
@@ -577,7 +577,8 @@ static int cmdq_probe(struct platform_device *pdev)
snprintf(clk_id, sizeof(clk_id), "%s%d", clk_name, alias_id);
cmdq->clocks[alias_id].id = clk_id;
cmdq->clocks[alias_id].clk = of_clk_get(node, 0);
- if (IS_ERR(cmdq->clocks[alias_id].clk)) {
+ if (IS_ERR(cmdq->clocks[alias_id].clk) &&
+ PTR_ERR(cmdq->clocks[alias_id].clk) != -EPROBE_DEFER) {
dev_err(dev, "failed to get gce clk: %d\n", alias_id);
return PTR_ERR(cmdq->clocks[alias_id].clk);
}
@@ -586,7 +587,8 @@ static int cmdq_probe(struct platform_device *pdev)
} else {
cmdq->clocks[alias_id].id = clk_name;
cmdq->clocks[alias_id].clk = devm_clk_get(&pdev->dev, clk_name);
- if (IS_ERR(cmdq->clocks[alias_id].clk)) {
+ if (IS_ERR(cmdq->clocks[alias_id].clk) &&
+ PTR_ERR(cmdq->clocks[alias_id].clk) != -EPROBE_DEFER) {
dev_err(dev, "failed to get gce clk\n");
return PTR_ERR(cmdq->clocks[alias_id].clk);
}
--
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] mailbox: remove the error message when gce clk is defer
2021-10-23 16:48 [PATCH] mailbox: remove the error message when gce clk is defer jason-jh.lin
@ 2021-10-24 20:25 ` Russell King (Oracle)
2021-10-25 3:08 ` Jason-JH Lin
0 siblings, 1 reply; 3+ messages in thread
From: Russell King (Oracle) @ 2021-10-24 20:25 UTC (permalink / raw)
To: jason-jh.lin
Cc: Chun-Kuang Hu, Philipp Zabel, Matthias Brugger, Jassi Brar,
Yongqiang Niu, David Airlie, Daniel Vetter, dri-devel,
linux-mediatek, linux-arm-kernel, linux-kernel, hsinyi, fshao,
nancy.lin, singo.chang
On Sun, Oct 24, 2021 at 12:48:31AM +0800, jason-jh.lin wrote:
> Remove the error message when gce clk is defer.
>
> Signed-off-by: jason-jh.lin <jason-jh.lin@mediatek.com>
> ---
> drivers/mailbox/mtk-cmdq-mailbox.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c
> index fd5576a9f8b4..684b8aa1e445 100644
> --- a/drivers/mailbox/mtk-cmdq-mailbox.c
> +++ b/drivers/mailbox/mtk-cmdq-mailbox.c
> @@ -577,7 +577,8 @@ static int cmdq_probe(struct platform_device *pdev)
> snprintf(clk_id, sizeof(clk_id), "%s%d", clk_name, alias_id);
> cmdq->clocks[alias_id].id = clk_id;
> cmdq->clocks[alias_id].clk = of_clk_get(node, 0);
> - if (IS_ERR(cmdq->clocks[alias_id].clk)) {
> + if (IS_ERR(cmdq->clocks[alias_id].clk) &&
> + PTR_ERR(cmdq->clocks[alias_id].clk) != -EPROBE_DEFER) {
> dev_err(dev, "failed to get gce clk: %d\n", alias_id);
> return PTR_ERR(cmdq->clocks[alias_id].clk);
> }
So when you get -EPROBE_DEFER, you omit the error message _and_ ignore
the -EPROBE_DEFER. Is that really what you want to do?
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mailbox: remove the error message when gce clk is defer
2021-10-24 20:25 ` Russell King (Oracle)
@ 2021-10-25 3:08 ` Jason-JH Lin
0 siblings, 0 replies; 3+ messages in thread
From: Jason-JH Lin @ 2021-10-25 3:08 UTC (permalink / raw)
To: Russell King (Oracle)
Cc: Chun-Kuang Hu, Philipp Zabel, Matthias Brugger, Jassi Brar,
Yongqiang Niu, David Airlie, Daniel Vetter, dri-devel,
linux-mediatek, linux-arm-kernel, linux-kernel, hsinyi, fshao,
nancy.lin, singo.chang
Hi Russell,
Thanks for the reviews.
On Sun, 2021-10-24 at 21:25 +0100, Russell King (Oracle) wrote:
> On Sun, Oct 24, 2021 at 12:48:31AM +0800, jason-jh.lin wrote:
> > Remove the error message when gce clk is defer.
> >
> > Signed-off-by: jason-jh.lin <jason-jh.lin@mediatek.com>
> > ---
> > drivers/mailbox/mtk-cmdq-mailbox.c | 6 ++++--
> > 1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c
> > b/drivers/mailbox/mtk-cmdq-mailbox.c
> > index fd5576a9f8b4..684b8aa1e445 100644
> > --- a/drivers/mailbox/mtk-cmdq-mailbox.c
> > +++ b/drivers/mailbox/mtk-cmdq-mailbox.c
> > @@ -577,7 +577,8 @@ static int cmdq_probe(struct platform_device
> > *pdev)
> > snprintf(clk_id, sizeof(clk_id),
> > "%s%d", clk_name, alias_id);
> > cmdq->clocks[alias_id].id = clk_id;
> > cmdq->clocks[alias_id].clk =
> > of_clk_get(node, 0);
> > - if (IS_ERR(cmdq->clocks[alias_id].clk))
> > {
> > + if (IS_ERR(cmdq->clocks[alias_id].clk)
> > &&
> > + PTR_ERR(cmdq->clocks[alias_id].clk)
> > != -EPROBE_DEFER) {
> > dev_err(dev, "failed to get gce
> > clk: %d\n", alias_id);
> > return PTR_ERR(cmdq-
> > >clocks[alias_id].clk);
> > }
>
> So when you get -EPROBE_DEFER, you omit the error message _and_
> ignore
> the -EPROBE_DEFER. Is that really what you want to do?
>
Oh, you're right. I should return the -EPROBE_DEFER.
I just want to ignore the error msg because gce clk may not ready while
gce probing.
I'll update this patch at next version.
--
Regrads,
Jason-JH Lin <jason-jh.lin@mediatek.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-25 3:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-23 16:48 [PATCH] mailbox: remove the error message when gce clk is defer jason-jh.lin
2021-10-24 20:25 ` Russell King (Oracle)
2021-10-25 3:08 ` Jason-JH Lin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).