From: Vinod Koul <vkoul@kernel.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Hyun Kwon <hyun.kwon@xilinx.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Michal Simek <michal.simek@xilinx.com>,
Sanjay R Mehta <sanju.mehta@amd.com>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
Arnd Bergmann <arnd@arndb.de>,
Jianqiang Chen <jianqiang.chen@xilinx.com>,
Quanyang Wang <quanyang.wang@windriver.com>,
Yang Li <yang.lee@linux.alibaba.com>,
Allen Pais <apais@linux.microsoft.com>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Biju Das <biju.das.jz@bp.renesas.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dmaengine: remove debugfs #ifdef
Date: Mon, 25 Oct 2021 12:01:23 +0530 [thread overview]
Message-ID: <YXZPO6z2emwXe5DA@matsya> (raw)
In-Reply-To: <20210920122017.205975-1-arnd@kernel.org>
On 20-09-21, 14:20, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The ptdma driver has added debugfs support, but this fails to build
> when debugfs is disabled:
>
> drivers/dma/ptdma/ptdma-debugfs.c: In function 'ptdma_debugfs_setup':
> drivers/dma/ptdma/ptdma-debugfs.c:93:54: error: 'struct dma_device' has no member named 'dbg_dev_root'
> 93 | debugfs_create_file("info", 0400, pt->dma_dev.dbg_dev_root, pt,
> | ^
> drivers/dma/ptdma/ptdma-debugfs.c:96:55: error: 'struct dma_device' has no member named 'dbg_dev_root'
> 96 | debugfs_create_file("stats", 0400, pt->dma_dev.dbg_dev_root, pt,
> | ^
> drivers/dma/ptdma/ptdma-debugfs.c:102:52: error: 'struct dma_device' has no member named 'dbg_dev_root'
> 102 | debugfs_create_dir("q", pt->dma_dev.dbg_dev_root);
> | ^
>
> Remove the #ifdef in the header, as this only saves a few bytes,
> but would require ugly #ifdefs in each driver using it.
> Simplify the other user while we're at it.
Applied, thanks
--
~Vinod
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2021-10-25 6:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 12:20 [PATCH] dmaengine: remove debugfs #ifdef Arnd Bergmann
2021-09-20 12:47 ` Laurent Pinchart
2021-09-20 12:50 ` Arnd Bergmann
2021-09-20 16:28 ` Laurent Pinchart
2021-10-25 6:31 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXZPO6z2emwXe5DA@matsya \
--to=vkoul@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=apais@linux.microsoft.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=biju.das.jz@bp.renesas.com \
--cc=dmaengine@vger.kernel.org \
--cc=hyun.kwon@xilinx.com \
--cc=jianqiang.chen@xilinx.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=peter.ujfalusi@ti.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=quanyang.wang@windriver.com \
--cc=sanju.mehta@amd.com \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).