From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA0C9C433F5 for ; Mon, 25 Oct 2021 06:32:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 903D160E09 for ; Mon, 25 Oct 2021 06:32:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 903D160E09 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YtQqkTvp4RDRcG4lWe8PMOpREoFSxiKrYUlT4QfzCZY=; b=PzLTDXa8tgVh7s rDjVFjakSdRLpZXPxCeeiu6dwJZb9MlBfv0MQmgkI6OdYpo8Kon7yd4amdxOQ1wLrA6csaMkpFTol tmEzk0F72z90rEOvtzSsVsq8aPOtNIBxhxx3+YKq04cV278WRuEUbV65tOl0lmwo/KUad10tpTOVZ 4tLJ0Fff2UQy9x6eejf2vx4Kw04I2+AlOhgWDG0vGmSCOCKdE0LNmAlGYMjxFYICbkigQhnfppDQX NLxAW3DHeRaT+1y78c2pQoa5IDo0PvlQo5SbfbsNXspl2RImgEcoundhiaHLALiDG9UPkInwIhaTQ OtxAemR/siGfcShgdwEQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1metW7-00FPlA-Pd; Mon, 25 Oct 2021 06:31:31 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1metW4-00FPkq-8D for linux-arm-kernel@lists.infradead.org; Mon, 25 Oct 2021 06:31:29 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id E180E60E09; Mon, 25 Oct 2021 06:31:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1635143487; bh=w0wt2RzbUmzFsn9gjSb7RtbSu2VKVQcA+1obxbpkBtw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YAHIL+vC76firAy7T3DBeUnbIXP6C25M/4Qp/Ww5/kmcMBkZwIaAcnXabdBplwpRH yJKRih7lqyB9PBIuVoBT5I2msrSby7ZHPv7t7MuqL5uMqfZ0htjq408f8Y7z5Aa+t/ V4sTAWX6ssNkWjDi3EnQ76Ns7WBS/wC51Sl5bGAuZdvtO2VWzu3clNJEvYw9Ctq2P1 0Gf55/NtGlaD9x8jFqZU7XdyUvL30Kn8hlp6YrUwIPL8wyzkCQMIGbo7vDx9nsWx24 QqJgZp92R5NYdayJ7QIw1mHk0OMl5hBQ0+WbnBee4U/suRE1nlC8z+BYQpdW6ahzud w72Vz/20YBfkg== Date: Mon, 25 Oct 2021 12:01:23 +0530 From: Vinod Koul To: Arnd Bergmann Cc: Hyun Kwon , Laurent Pinchart , Michal Simek , Sanjay R Mehta , Peter Ujfalusi , Arnd Bergmann , Jianqiang Chen , Quanyang Wang , Yang Li , Allen Pais , Lad Prabhakar , Biju Das , Andy Shevchenko , dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dmaengine: remove debugfs #ifdef Message-ID: References: <20210920122017.205975-1-arnd@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210920122017.205975-1-arnd@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211024_233128_360033_B8C63EFD X-CRM114-Status: GOOD ( 10.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 20-09-21, 14:20, Arnd Bergmann wrote: > From: Arnd Bergmann > > The ptdma driver has added debugfs support, but this fails to build > when debugfs is disabled: > > drivers/dma/ptdma/ptdma-debugfs.c: In function 'ptdma_debugfs_setup': > drivers/dma/ptdma/ptdma-debugfs.c:93:54: error: 'struct dma_device' has no member named 'dbg_dev_root' > 93 | debugfs_create_file("info", 0400, pt->dma_dev.dbg_dev_root, pt, > | ^ > drivers/dma/ptdma/ptdma-debugfs.c:96:55: error: 'struct dma_device' has no member named 'dbg_dev_root' > 96 | debugfs_create_file("stats", 0400, pt->dma_dev.dbg_dev_root, pt, > | ^ > drivers/dma/ptdma/ptdma-debugfs.c:102:52: error: 'struct dma_device' has no member named 'dbg_dev_root' > 102 | debugfs_create_dir("q", pt->dma_dev.dbg_dev_root); > | ^ > > Remove the #ifdef in the header, as this only saves a few bytes, > but would require ugly #ifdefs in each driver using it. > Simplify the other user while we're at it. Applied, thanks -- ~Vinod _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel