From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76113C433EF for ; Mon, 25 Oct 2021 12:21:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4BF5360FDA for ; Mon, 25 Oct 2021 12:21:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4BF5360FDA Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=usp.br Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=Wiz3q+BOwJobIj/PXrbmokD25qrmVNWL8nzEkuLgfGw=; b=KZg+V7VVpyYh4F YQlcH674e8uF/4oYv/3e7G6eGideNfrEN51oUavX/g4qRDukAC8J/lvxgm/mnsHx8t5o/ZoXhcas2 VQ0aWKX8Jt/VKAd1PqjCxhRtZL1cwYxTnM/rsCWgSqah9ssBBXOCg2rLKFreh9Ef1YeYsQAv2JPsD ukDq00FLRKIb5vql8W6L8hcbHaAyy0GXbVgB4vhT4n9HJB2oAFnprfEf8sDHDx9TUdMsRQNgsOpoc K25mw4m7PLtIwpj1dJapToStHupHjHmZTui5DeDYqdIUUqtrEbvTtl9+GGbZB1t4xIgVIq2VKdQcX O64LTmnWlkRJ7uGa8n6w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1meyxM-00GOoh-Or; Mon, 25 Oct 2021 12:20:01 +0000 Received: from mail-ua1-x92d.google.com ([2607:f8b0:4864:20::92d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1meyxH-00GOmu-QB for linux-arm-kernel@lists.infradead.org; Mon, 25 Oct 2021 12:19:57 +0000 Received: by mail-ua1-x92d.google.com with SMTP id e5so14518269uam.11 for ; Mon, 25 Oct 2021 05:19:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=usp.br; s=usp-google; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :content-transfer-encoding; bh=zwmpU/4wUBOOjvtzhmHsdtzGo9J9noPc+g2NVU0zBxc=; b=zdb7e5wgfnKy23IF9N+nt68OhysvD7UjZ5zDYtdgZ0sivFULWY9/ugfSFeix0JXopS ziNYkrV3JAE2eoI6BDjbLHmoKFCYJhdkfryGUfZ1xdgLM9FzxTcSgi1+WnWe8gTYD0/8 fPAZq4D3xit+HpvCyLjEsQDxQerW6UcSkXtExYFNZwK6CFsRw+1soqeGeq5rhVfpmHv6 Rvpk8+miDk28wz2oH2daV0v4ZJJCP4OvMBslThVP8Jve9hlzk75Yi+hoyxdHZZ5ShbY8 OJGl02WdhcSzIg1ke8hQ3ndiRB8p/Cwj/fJrlQFasC0E9Befo3N/NnG2UY1gyauJ61V7 F5Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:content-transfer-encoding; bh=zwmpU/4wUBOOjvtzhmHsdtzGo9J9noPc+g2NVU0zBxc=; b=5CerL0euPqYwI6t93kVPoWwGk5lVlLM+T19SjULGyFYcSLnzsAn2sha2sFpklF41HS wW1Axe5QZ0/63do3j18ex+OamTgbEmMzC/MIl/84S3rbPCfoDAFpr+HKTSB+PnsO12mO pcJO2gbVHCAiw1ZM2dxsOw/eWJ7eg+UOA1aALkwo9kT0tIKkiSlxM7TU92FJQ5dZutHw tMP+B5sf9QZrGRLBwCcsQ0BGbf4x1QTKQ9Golft0QfV/rjK6PzNNq/H+zpqpLPYT2cJ8 BmWuPTPe/aTovs5W0AuVvgQr1QqbK6JBlxgIozTKTrRr/6iRztO74c9PCF4nfEEkxmGZ RGmQ== X-Gm-Message-State: AOAM53247ph7Fqkes280bmYS6YjCVrfo/R+8uqoubXY6PPMBxuxE4hkv 5eXOzxyhynFqraPDZYFoqqSU3Q== X-Google-Smtp-Source: ABdhPJwO0IHmRP033afGZOvNBH76vR6CJDWgHofTo24bK/FSoHv7O6QBDFOMfGnQpyjlLwXwYtmSGA== X-Received: by 2002:a67:b202:: with SMTP id b2mr14375566vsf.33.1635164394426; Mon, 25 Oct 2021 05:19:54 -0700 (PDT) Received: from Andryuu.br ([2804:431:c7fd:423:9dac:f639:6086:598]) by smtp.gmail.com with ESMTPSA id ba22sm848466vkb.7.2021.10.25.05.19.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Oct 2021 05:19:54 -0700 (PDT) Date: Mon, 25 Oct 2021 09:19:50 -0300 From: =?iso-8859-1?Q?Andr=E9?= Gustavo Nakagomi Lopez To: jic23@kernel.org, lars@metafoo.de, vz@mleia.com Cc: linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] iio: adc: lpc18xx_adc: Reorder clk_get_rate function call Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211025_051955_896738_C195CAA7 X-CRM114-Status: GOOD ( 11.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org clk_get_rate is not guaranteed to work if called before clk_prepare_enable. Reorder clk_get_rate, so it's called after clk_prepare_enable and after devm_add_action_or_reset of lpc18xx_clk_disable. Suggested-by: Jonathan Cameron Acked-by: Vladimir Zapolskiy Signed-off-by: Andr=E9 Gustavo Nakagomi Lopez --- Change log V1 -> V2: -Fixed typo -Added appropriate Suggested-by and Acked-by tags drivers/iio/adc/lpc18xx_adc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/iio/adc/lpc18xx_adc.c b/drivers/iio/adc/lpc18xx_adc.c index ceefa4d793cf..ae9c9384f23e 100644 --- a/drivers/iio/adc/lpc18xx_adc.c +++ b/drivers/iio/adc/lpc18xx_adc.c @@ -157,9 +157,6 @@ static int lpc18xx_adc_probe(struct platform_device *pd= ev) return dev_err_probe(&pdev->dev, PTR_ERR(adc->clk), "error getting clock\n"); = - rate =3D clk_get_rate(adc->clk); - clkdiv =3D DIV_ROUND_UP(rate, LPC18XX_ADC_CLK_TARGET); - adc->vref =3D devm_regulator_get(&pdev->dev, "vref"); if (IS_ERR(adc->vref)) return dev_err_probe(&pdev->dev, PTR_ERR(adc->vref), @@ -192,6 +189,9 @@ static int lpc18xx_adc_probe(struct platform_device *pd= ev) if (ret) return ret; = + rate =3D clk_get_rate(adc->clk); + clkdiv =3D DIV_ROUND_UP(rate, LPC18XX_ADC_CLK_TARGET); + adc->cr_reg =3D (clkdiv << LPC18XX_ADC_CR_CLKDIV_SHIFT) | LPC18XX_ADC_CR_PDN; writel(adc->cr_reg, adc->base + LPC18XX_ADC_CR); -- = 2.33.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel