From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87EE1C433EF for ; Mon, 25 Oct 2021 22:25:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9C5A96103C for ; Mon, 25 Oct 2021 22:25:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9C5A96103C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nnmlDKE9Z9fYfLKGWcb92Tv4zedA+eXUxEdtPZYCgRk=; b=mBXOk5XQ/xy0sX KdVzAgkNkcHKl6CI9YKcdoMa7+X+FkKs+Wkv5EG0O485ApEwX3iNDtVYRGL/2j/kejzuEw2eeWFIG BpLpmzCzZmjPkOTECP1ImbRBm8UnJsuQPRF+YMc+iipGoqUfqJgaJ57d74ozBki1aOmPPo6/mj1Yh blzrRpKnADzxVR+nqt+THCaFde+D7ofzymcvZQLWVwEVRrLXIB6K8UO+f7BXzKp4gfeYmDbXxl7nV IMct7zs6e579Anhuek1K2yFhJvCguztQ0wvr68BOdJ/X+y1ZUUqS6YRZLnTYeRrVn/x7mEiZ63/Y6 kQFtHLnaVDsvNG1RVe+w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mf8Oc-000DWi-2G; Mon, 25 Oct 2021 22:24:46 +0000 Received: from mail-ot1-f51.google.com ([209.85.210.51]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mf8OY-000DVd-I0; Mon, 25 Oct 2021 22:24:44 +0000 Received: by mail-ot1-f51.google.com with SMTP id l24-20020a9d1c98000000b00552a5c6b23cso16989341ota.9; Mon, 25 Oct 2021 15:24:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=L/hlTtZupHzj4/jWdWv9ULYOvkBrN5PlWdyav0V4CCU=; b=vlYnnv7P+LTfdXIRNTFY4rcTp9ycf/toT9km1m0tVXCdTzkJtNQyI/e4I0515OBwyh jNx8Y24z1nGOx7OIqYnYrVUDSu5EcazngMd0mulG58pQ+rDowvSOrX1ZziJ1TfaZFD/w u09VVtl8DygnHOIYi12CDzkPYrZfi5uapa6bXDaj4uXQw/qrbisrVxt1cK9XPrnryEVX IthqLikdSj5w5VsazEmvxKab8o0riagjoUdEkWeMX3ZtUGG3EdNbnb6olK1htX2DfTXB Yv8XrmhgjQOXGJoggVQlRsXDh32SfsKDEH6hTREj4X3CkwoNzkE27xbxw9U8sC4gz1dt GRBw== X-Gm-Message-State: AOAM533R1wojxCcN3rQ4jjnr9FLzE0fRohPmwKwgKYw9tOYLCgqECDff 0XYZtx5Dqj2brdU5PxqMDg== X-Google-Smtp-Source: ABdhPJy6PWKHQYzOWadWPt0ynalGKvun/QJa8ePrjt0bfrFipgAtZNmeZZGxpq1/mujmp7vzBtfbmg== X-Received: by 2002:a9d:6d99:: with SMTP id x25mr7187510otp.168.1635200681358; Mon, 25 Oct 2021 15:24:41 -0700 (PDT) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id 3sm3996343oif.12.2021.10.25.15.24.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Oct 2021 15:24:40 -0700 (PDT) Received: (nullmailer pid 1194223 invoked by uid 1000); Mon, 25 Oct 2021 22:24:39 -0000 Date: Mon, 25 Oct 2021 17:24:39 -0500 From: Rob Herring To: Jim Quinlan Cc: linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Mark Brown , bcm-kernel-feedback-list@broadcom.com, james.quinlan@broadcom.com, Florian Fainelli , Bjorn Helgaas , Saenz Julienne , "moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list Subject: Re: [PATCH v5 1/6] dt-bindings: PCI: Add bindings for Brcmstb EP voltage regulators Message-ID: References: <20211022140714.28767-1-jim2101024@gmail.com> <20211022140714.28767-2-jim2101024@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211022140714.28767-2-jim2101024@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211025_152442_628146_F29CE4A9 X-CRM114-Status: GOOD ( 18.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 22, 2021 at 10:06:54AM -0400, Jim Quinlan wrote: > Similar to the regulator bindings found in "rockchip-pcie-host.txt", this > allows optional regulators to be attached and controlled by the PCIe RC > driver. That being said, this driver searches in the DT subnode (the EP > node, eg pci@0,0) for the regulator property. > > The use of a regulator property in the pcie EP subnode such as > "vpcie12v-supply" depends on a pending pullreq to the pci-bus.yaml > file at > > https://github.com/devicetree-org/dt-schema/pull/54 > > Signed-off-by: Jim Quinlan > --- > .../bindings/pci/brcm,stb-pcie.yaml | 23 +++++++++++++++++++ > 1 file changed, 23 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml > index b9589a0daa5c..fec13e4f6eda 100644 > --- a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml > +++ b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml > @@ -154,5 +154,28 @@ examples: > <0x42000000 0x1 0x80000000 0x3 0x00000000 0x0 0x80000000>; > brcm,enable-ssc; > brcm,scb-sizes = <0x0000000080000000 0x0000000080000000>; > + > + /* PCIe bridge */ More specifically, the root port. > + pci@0,0 { > + #address-cells = <3>; > + #size-cells = <2>; > + reg = <0x0 0x0 0x0 0x0 0x0>; > + device_type = "pci"; > + ranges; > + > + /* PCIe endpoint */ > + pci@0,0 { > + device_type = "pci"; This means this device is a PCI bridge which wouldn't typically be the endpoint. Is that intended? > + assigned-addresses = <0x82010000 0x0 0xf8000000 0x6 0x00000000 0x0 0x2000>; > + reg = <0x0 0x0 0x0 0x0 0x0>; > + compatible = "pci14e4,1688"; > + vpcie3v3-supply = <&vreg7>; > + > + #address-cells = <3>; > + #size-cells = <2>; > + > + ranges; > + }; > + }; > }; > }; > -- > 2.17.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel