From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EDB9C433EF for ; Tue, 26 Oct 2021 09:03:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D9F3060D07 for ; Tue, 26 Oct 2021 09:03:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D9F3060D07 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hzgj013b7TejVf45sPWKwIC3GHa2PPRGRyU5YZnRlrM=; b=XpGDHr4tuVBQc2 gnP3n5RLNxv7aUXbo5RdUUhvMzyvKz+qj7Hph6RVWp0ekOA0mLK3YdYu5wEkCLazb53Xc/ZcgtbUc GwZiM30g/+yoQD3CSFF1dll7H3fNq6flVcO/JWf3H7neOLZ0WeR693ADiFGlHC5f/vWRE6PkdsEwp pq33YzecYjb0xYAA0QgzxEA2CYtRGJB0L7L3FvkfnieNPXB1TROE4kYgu8EN3sf5DRnLHWwXwZUEU Xly+fhSry6DtGhgFGRLad3zkHl6sOx/+Bgx9UHbVXQVvbrZ8XzUWoMCVj3/GDTEtf8t/5MAymosxf NQY6pY+LqGDZi6LVxtdA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mfILA-0019xK-B1; Tue, 26 Oct 2021 09:01:52 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mfIL5-0019f8-3m for linux-arm-kernel@lists.infradead.org; Tue, 26 Oct 2021 09:01:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=0hA9F2izcUGC40cVRcQ0tDFSmX7Q4rUQYCuTHCJ3bRY=; b=PdauVmbTEfXxx4kHsYgM2RQder N6z0NcQjMHMvVUd6LgQwW33d+H0wc7sTVyuH0BM1b10/8DWcU7SPElHAMSoxvu3J4uoFGQacbBZJZ 4oYjve/XFElbji/RX2Husw+iOvSt6/SdGDKR6/GGws/V65UrBxTJ/jO9JTMbOULpGwd+kV9fXIE6n IfyqMpeTjuvz7+DJzNlXVzNbv8rGNmO9J/+U8MqRveTpRoXAqxNv0kP2T2YlPmRFoSnm49CTMPT1x k8RPzU4HOuDhpLK1kgQyJyQudtzMtJY+JRTAXu3ChYoorzpjf3ErlqDsGI8LKgFmhaVlZloAsCNNJ flYKtvJw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:55302) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mfIIy-00055M-UU; Tue, 26 Oct 2021 09:59:36 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1mfIIw-0006cF-L9; Tue, 26 Oct 2021 09:59:34 +0100 Date: Tue, 26 Oct 2021 09:59:34 +0100 From: "Russell King (Oracle)" To: Linus Walleij Cc: quanyang.wang@windriver.com, Thomas Gleixner , Ard Biesheuvel , Linux ARM , linux-kernel Subject: Re: [PATCH] ARM: add BUILD_BUG_ON to check if fixmap range spans multiple pmds Message-ID: References: <20211020054942.1608637-1-quanyang.wang@windriver.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211026_020147_182568_C8A73E5B X-CRM114-Status: GOOD ( 15.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Oct 24, 2021 at 11:44:31PM +0200, Linus Walleij wrote: > On Wed, Oct 20, 2021 at 7:50 AM wrote: > > > From: Quanyang Wang > > > > Not only the early fixmap range, but also the fixmap range should be > > checked if it spans multiple pmds. When enabling CONFIG_DEBUG_HIGHMEM, > > some systems which contain up to 16 CPUs will crash. > > > > Signed-off-by: Quanyang Wang > > Looks reasonable to me. > Reviewed-by: Linus Walleij > > Please submit this patch into Russell's patch tracker. ... and has totally broken what looks like _all_ ARM kernel builds. It can not have been tested. Maybe it's uncovered a previously unknown problem, but causing such a wide-range regression is disappointing. I'm going to revert this commit. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel