From: Andrew Lunn <andrew@lunn.ch>
To: Corentin Labbe <clabbe@baylibre.com>
Cc: davem@davemloft.net, kuba@kernel.org, linus.walleij@linaro.org,
ulli.kroll@googlemail.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] net: ethernet: cortina: permit to set mac address in DT
Date: Wed, 27 Oct 2021 02:08:04 +0200 [thread overview]
Message-ID: <YXiYZGEiVMLdN1zt@lunn.ch> (raw)
In-Reply-To: <20211026191703.1174086-1-clabbe@baylibre.com>
On Tue, Oct 26, 2021 at 07:17:03PM +0000, Corentin Labbe wrote:
> Add ability of setting mac address in DT for cortina ethernet driver.
>
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
> ---
> drivers/net/ethernet/cortina/gemini.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/net/ethernet/cortina/gemini.c b/drivers/net/ethernet/cortina/gemini.c
> index 941f175fb911..f6aa2387a1af 100644
> --- a/drivers/net/ethernet/cortina/gemini.c
> +++ b/drivers/net/ethernet/cortina/gemini.c
> @@ -2356,12 +2356,14 @@ static void gemini_port_save_mac_addr(struct gemini_ethernet_port *port)
> static int gemini_ethernet_port_probe(struct platform_device *pdev)
> {
> char *port_names[2] = { "ethernet0", "ethernet1" };
> + struct device_node *np = pdev->dev.of_node;
> struct gemini_ethernet_port *port;
> struct device *dev = &pdev->dev;
> struct gemini_ethernet *geth;
> struct net_device *netdev;
> struct device *parent;
> unsigned int id;
> + u8 mac[ETH_ALEN];
Off by one in terms of reverse Christmas tree.
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-10-27 0:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-26 19:17 [PATCH] net: ethernet: cortina: permit to set mac address in DT Corentin Labbe
2021-10-26 20:17 ` Linus Walleij
2021-10-27 0:08 ` Andrew Lunn [this message]
2021-11-02 9:50 ` Corentin Labbe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXiYZGEiVMLdN1zt@lunn.ch \
--to=andrew@lunn.ch \
--cc=clabbe@baylibre.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ulli.kroll@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox