From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2A53C433F5 for ; Wed, 27 Oct 2021 00:10:40 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9D5706103B for ; Wed, 27 Oct 2021 00:10:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9D5706103B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=StaXw76HscrMXAkftW4lC5io8safMSXJEKgdc9czr9o=; b=ScMOa/oh1+EJwA Ke5nMQF0AypkZui4m5WbM3hiWAWdU+1kTkNea8g7jDeNWKtu9ymzmH5VQBRojj93FPEb9xANTMiBS DtGR6ur3hMVMEQ6/5NcL78ywstbd8ePjT0JVRCKkFkRpITtiOoWWQdMTSxRaQcE5AFnjaQGOcEKoj +qRMoSJdD2AKhuzSzmhkPn9C54Vzs632kqE/SMVRtpgS+SAci1bcMMY85pGEEidxA/5MuEX9wDI5y QBztPBNuOEC2eWFF//MHCWzDoGYDUn/Jp/D/fWR1k+JS1HV7CUoG4x6dJWnT0CWv6AMOivb8jofdc irwkTFiGmwyuBDeCHsfg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mfWUy-003MDY-8I; Wed, 27 Oct 2021 00:08:56 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mfWUG-003M73-8C for linux-arm-kernel@lists.infradead.org; Wed, 27 Oct 2021 00:08:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=l3HKwrI4aii/N0e3D8E0FITj+tQPQCyffkihHJ5j0nc=; b=n3q9Nv1+OxmGCua+s3bMYSsIw0 v4zsQ7/sayqijhOCuHnryTEhDexB3O5CNiNM3TkuySjXvXqEmMJJFp3kKOCu4Pdq/B39BombxpMJR Cds3ckIsl9FUw4fj9iKtev+oMdO0m9Xdtx+M3GjF1Myt+5TChIIILEEY8RXs7d9pmkaM=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1mfWU8-00Bpoe-Nx; Wed, 27 Oct 2021 02:08:04 +0200 Date: Wed, 27 Oct 2021 02:08:04 +0200 From: Andrew Lunn To: Corentin Labbe Cc: davem@davemloft.net, kuba@kernel.org, linus.walleij@linaro.org, ulli.kroll@googlemail.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] net: ethernet: cortina: permit to set mac address in DT Message-ID: References: <20211026191703.1174086-1-clabbe@baylibre.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211026191703.1174086-1-clabbe@baylibre.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211026_170812_335233_B6AB3FC5 X-CRM114-Status: GOOD ( 14.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Oct 26, 2021 at 07:17:03PM +0000, Corentin Labbe wrote: > Add ability of setting mac address in DT for cortina ethernet driver. > > Signed-off-by: Corentin Labbe > --- > drivers/net/ethernet/cortina/gemini.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/net/ethernet/cortina/gemini.c b/drivers/net/ethernet/cortina/gemini.c > index 941f175fb911..f6aa2387a1af 100644 > --- a/drivers/net/ethernet/cortina/gemini.c > +++ b/drivers/net/ethernet/cortina/gemini.c > @@ -2356,12 +2356,14 @@ static void gemini_port_save_mac_addr(struct gemini_ethernet_port *port) > static int gemini_ethernet_port_probe(struct platform_device *pdev) > { > char *port_names[2] = { "ethernet0", "ethernet1" }; > + struct device_node *np = pdev->dev.of_node; > struct gemini_ethernet_port *port; > struct device *dev = &pdev->dev; > struct gemini_ethernet *geth; > struct net_device *netdev; > struct device *parent; > unsigned int id; > + u8 mac[ETH_ALEN]; Off by one in terms of reverse Christmas tree. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel