From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AD5FC433F5 for ; Fri, 12 Nov 2021 01:35:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1AD1E61284 for ; Fri, 12 Nov 2021 01:35:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1AD1E61284 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=12o1hBBBsJfpJIqCYT3LKGybqFTDuuLdnwVbkrfHkP8=; b=Ss0FWYsFO48gHV Zxac9zZBn/irjCZLZN7tVGpSS7FBcxeuaje0o5ckpNuxJVs1LZyF+INGJphSPLLl6A3rrpLVBV8jq T0R9DXxQjvsBdWZuiCCMHZeXKqiVxUgDwp92DaXIvJ2WluWLJcmPyy9g3p3dyTyvelWqAzLFH7eBG NX8Q3PfH6WT9o0Vv5jX6tJB1Hk6Fnlwe/FVAJYLi51UgaZj9GPb6Xf5EGfh9v7Ay6oGPEPUxJ467t Hsy/piwV1/ffx8ODvVYjJIZpvQ6FA6HkE9s3MBRfsw1NcIqxU0qB47IxlNHq74WK4lqVCPzn/9DPn MrqZ2uchepVRS2fnPCaQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mlLSU-009BdE-BP; Fri, 12 Nov 2021 01:34:26 +0000 Received: from mail-pj1-x102a.google.com ([2607:f8b0:4864:20::102a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mlLSO-009BaS-ST for linux-arm-kernel@lists.infradead.org; Fri, 12 Nov 2021 01:34:22 +0000 Received: by mail-pj1-x102a.google.com with SMTP id fv9-20020a17090b0e8900b001a6a5ab1392so6273216pjb.1 for ; Thu, 11 Nov 2021 17:34:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=0YHU5BFJe1UeJmMP6VYLEudXKn26+NeOxTqKcy9fme8=; b=LrFnSWp7l4vvRFWqk06cZtwB/ugRwVOpRXHG+uL+eIa85OD3cC5UgUaQ/gbX+IQUgd N5j7X456rIqpp28T9y0cSOfeC5OOs1vsm4r9GxHHABLjSIlcZkBpqAEKnOO0fD2iRfU3 Zi7bZij5unADfaSDgQct4cGhDgHCNsqiDS2Jnh6WDjYPDBrGOBSbCyYVcFc6PhQ/JFZ4 RoD5uK51PLaQOhc0Udq2fvkh+ZrSztIibqX3r8mcDuuHX0s0A9BR2TySEAW1QbHRSZVy WZMSLHskRaYFOr1+ijUTRrVxc80eRJlnLanayATyJyudWGMIa1gLqjepUMCjqT1kxXiZ c1og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=0YHU5BFJe1UeJmMP6VYLEudXKn26+NeOxTqKcy9fme8=; b=E7wUKOnFRHwcKWD1pdNCPCzKFFhbgVWCXu2mVVaxiuEERhAOZX3UY4F2NKV1Tqo7j3 QQbeD3zc+2V6q++7486gFnvWLzBju+lrtzOJeMk9Hyns+vBTrJWS5uA64RY6g5Mw0l7G o9anHkUGc+LDee7u/znGJPsUBCZJDkaudP7Upi7PA5Dmns4xZQ4PhqmHQyYtm7ZVNyjG /RVy6Kd7gDC+Huv5evH/uC3GNulmgJXUjH3ffKLprRSmjoF/vP5czaTaa8nF/8UJXZzd ZmH1Im298iS1TFlPjwGk7WOSba1EVCT6Som8gFqgT/Hb2TlB1uMkcSrn4TiuX/f0CHD4 E00A== X-Gm-Message-State: AOAM533mqrIh6BhBPF1VpRyarBHzgpOhbTF6JhaCF0h7Rc8PXsU0b5Oa LnDoI38HBRkoP6SdU4h3kpaDaQ== X-Google-Smtp-Source: ABdhPJwCqDn0a2JCQcf42AQVYBrgJG7/UP8bVjVF7dmyhdh/1aO7xtYDLnN93T7YEfSgDiy+x3pAbQ== X-Received: by 2002:a17:90a:670e:: with SMTP id n14mr13311383pjj.144.1636680856755; Thu, 11 Nov 2021 17:34:16 -0800 (PST) Received: from google.com ([2401:fa00:1:10:3f91:373b:ba9b:471e]) by smtp.gmail.com with ESMTPSA id nn4sm3367102pjb.38.2021.11.11.17.34.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Nov 2021 17:34:16 -0800 (PST) Date: Fri, 12 Nov 2021 09:34:13 +0800 From: Tzung-Bi Shih To: Christophe JAILLET Cc: tiffany.lin@mediatek.com, andrew-ct.chen@mediatek.com, mchehab@kernel.org, matthias.bgg@gmail.com, acourbot@chromium.org, yunfei.dong@mediatek.com, hverkuil-cisco@xs4all.nl, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] media: mtk-vcodec: Fix an error handling path in 'asid_allocator_init()' Message-ID: References: <86d3e2db237bc35eb55bd46ef07fa13a39bcdff8.1636636541.git.christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <86d3e2db237bc35eb55bd46ef07fa13a39bcdff8.1636636541.git.christophe.jaillet@wanadoo.fr> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211111_173420_933672_0A8D939F X-CRM114-Status: UNSURE ( 9.86 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 11, 2021 at 02:17:51PM +0100, Christophe JAILLET wrote: > In case of error the 'media_device_init()' call is not balanced by a > corresponding 'media_device_cleanup()' call. > > Add it, when needed, as already done in the remove function. > > Fixes: 118add98f80e ("media: mtk-vcodec: vdec: add media device if using stateless api") > Signed-off-by: Christophe JAILLET The commit title looks incorrect: "asid_allocator_init". Except that, Acked-by: Tzung-Bi Shih _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel