From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA8DEC433EF for ; Tue, 2 Nov 2021 09:52:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9A29660E73 for ; Tue, 2 Nov 2021 09:52:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9A29660E73 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=71rXxU4aEkIcGwsD3MW0wTqWrMC7XvSVlW37xW9awOk=; b=WZrUtDbTUTHdlJ qWo6l2jnWUHYn9A/2j5q4y0CPkZHr/CFsn/LNDHi1/8zTckQV0E4Qd40L1pLkZvNZvVc37Lkwnfz1 2zQK9x9sRC/iwlitthK4Q/11UDFL+O+/iozDbMbA9fgrDzOLHXy8a5fUAycQ1Jh09tw48ReoTcpB1 V3JTXenn+/ry3+FZkb75yXQmehfJ1R/7AO7eSLIhar6P6R31ASCBuXiBM7Q+QP+lVNTfXHu/zaDGW l3YxX6BMrXWg00i5xgaHHcPfEFjbuS7fbFB6yuW6H30mBU6c7MIPoGQyxHd0lm5RPt4365TYpEoPn p7TiE+e+SqS6QEssAJXw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mhqRp-001B4Y-3d; Tue, 02 Nov 2021 09:51:17 +0000 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mhqR6-001Afv-9Z for linux-arm-kernel@lists.infradead.org; Tue, 02 Nov 2021 09:50:33 +0000 Received: by mail-wm1-x330.google.com with SMTP id j128-20020a1c2386000000b003301a98dd62so1330681wmj.5 for ; Tue, 02 Nov 2021 02:50:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=oV0s+u8QiQmnjKjuoPQXLkVGEgq7irgWfISNaVxibvg=; b=I125bBsZTLZQrrB6vgaRjifQrWb+2NrjcGJhEgRURoeoOl0JFL+rMBOxYYpYaxpZK4 +fWowieHZNM8x+TaJn2uG94gbouK0+mM7287Kj0ML/Phm/J0k0yTHTTz6XiFpxNG3IW3 CrZ9Ga1Lq8a15snM9kS+B2K3fI28qXQxIwSgpjX7+/iPmS1Vv2K3iJPYW0JNJd2LwFAq abCpUA8VH/gb87JyJrJmrCRqbWY0etfTu/kHVUYn8jU4erkonW25JON4FqOr4E4JCLMY +A+aXhg9btdMgMW131d/3v+AK/mlCjCyZqVbblD5Cvec/PFDqeTZMOCKlcw/mctAl0al 9pwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=oV0s+u8QiQmnjKjuoPQXLkVGEgq7irgWfISNaVxibvg=; b=MciKsygZWKo5yQVjHpxGnBlvzsuNH+dHMAL3HVheJIqakRcxhBfvufjCd2kXGiJyOQ LrbGuA9gVosQ6QNCLwleGmQj0n5fNyKO1JCvOTfaJ4Cx6ZMLj2xPkvYI2xHHLrNEUhLC /hyVwUkBo0S69lQH7EHlpgs/XVKT1ypilOKaox9iasqHRb5Q24hnnF/0Cf6DCLtSgWjL qoqKUGUyeOdWkIySTkfmFFJPmWB7EME378rLF12/vnilhw+d/Lk21A5Wp0OdBSc5jtxf AsoglczzOKjsnkEBqLF/TUuy0F4QDx6SjqpWrtgmuPDagcV7IJ/Ec+8U33EPHTSfAybq dO2w== X-Gm-Message-State: AOAM532hkI3JxLuH0xQWbhNmLrXkzhI5VEJQRVzkWVdqZN9qbKrm6Pzw Mz1HE1tVe0Zrf4R4bTcQ/sM= X-Google-Smtp-Source: ABdhPJyPqqYUMd0iwbhra9iG2MqPMTGLA5Tg7Dl8bOVs4AJeHOjyNGH5F8AnmcpcUlSU47S2aIT1ng== X-Received: by 2002:a1c:ac03:: with SMTP id v3mr5695607wme.13.1635846629643; Tue, 02 Nov 2021 02:50:29 -0700 (PDT) Received: from Red ([2a01:cb1d:3d5:a100:264b:feff:fe03:2806]) by smtp.googlemail.com with ESMTPSA id o8sm4262688wrm.67.2021.11.02.02.50.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Nov 2021 02:50:29 -0700 (PDT) Date: Tue, 2 Nov 2021 10:50:27 +0100 From: Corentin Labbe To: Andrew Lunn Cc: Corentin Labbe , davem@davemloft.net, kuba@kernel.org, linus.walleij@linaro.org, ulli.kroll@googlemail.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] net: ethernet: cortina: permit to set mac address in DT Message-ID: References: <20211026191703.1174086-1-clabbe@baylibre.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211102_025032_384753_60F07CED X-CRM114-Status: GOOD ( 18.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Le Wed, Oct 27, 2021 at 02:08:04AM +0200, Andrew Lunn a =E9crit : > On Tue, Oct 26, 2021 at 07:17:03PM +0000, Corentin Labbe wrote: > > Add ability of setting mac address in DT for cortina ethernet driver. > > = > > Signed-off-by: Corentin Labbe > > --- > > drivers/net/ethernet/cortina/gemini.c | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > = > > diff --git a/drivers/net/ethernet/cortina/gemini.c b/drivers/net/ethern= et/cortina/gemini.c > > index 941f175fb911..f6aa2387a1af 100644 > > --- a/drivers/net/ethernet/cortina/gemini.c > > +++ b/drivers/net/ethernet/cortina/gemini.c > > @@ -2356,12 +2356,14 @@ static void gemini_port_save_mac_addr(struct ge= mini_ethernet_port *port) > > static int gemini_ethernet_port_probe(struct platform_device *pdev) > > { > > char *port_names[2] =3D { "ethernet0", "ethernet1" }; > > + struct device_node *np =3D pdev->dev.of_node; > > struct gemini_ethernet_port *port; > > struct device *dev =3D &pdev->dev; > > struct gemini_ethernet *geth; > > struct net_device *netdev; > > struct device *parent; > > unsigned int id; > > + u8 mac[ETH_ALEN]; > = > Off by one in terms of reverse Christmas tree. > = Hello I will fix it in a v2 Thanks Regards _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel