From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A366AC433EF for ; Tue, 2 Nov 2021 12:14:01 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 663B660EDF for ; Tue, 2 Nov 2021 12:14:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 663B660EDF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yVcgfepsrub5IHsXx797k6mPtUVejICirvqwAQyY/2U=; b=i86DmiMmV0KJiy BFEjaTv290BxvtJ7Q3jd/Q3FIyvBG0MxParY1N+3p7w5pvoLMFG359lu0S5onnccFJ0khR+IkwuXa Y+m2bfq/qfuxUDW0BqWVnuJM3pzw/Qsy2oxXJ9IFiz+pH5iHH70pFNx0lSwCTJtXEz3NgvJVDcQa9 StY868sHXUn1l19FnlNNWp4xj8AQ9G/ZAff4a9PQkPURHCTFs1wdQSjtrygqzRklpRwNPsgTRHWvc +p9oC5ilve0kdQONdbkqA16UcdZMupRLkNpFz5VSiy3r0qeDKnMxw7j9ULs7s+LKqF1IcKz4LD5Ur KvpGD3VfVn8vL9/0HYxQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mhse8-001bMM-Lb; Tue, 02 Nov 2021 12:12:08 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mhse3-001bJw-Gn; Tue, 02 Nov 2021 12:12:04 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=o6FGnU4FYOY3wyYVmDluYr+k4/2zK3R/YdK8+ZD+B24=; b=xcBw0Q2V9DCSvPYJKTfqqnt58Y Xxi0DhL4Go3hSmgmSTgUKCBZtG/cqy3CiK/5jx2H3aDtAlltAzP1H5p2UTKPiXQDJA+o538iXovEP /FxuEUidPzD7z9R3XJnumXLmvIerc1DIkMtH/sg/cHQyE8aEEDOW590g3N9MQl/Qkgc2a6X4Jl9RF QZtmo1k87gLy1FpzUvbuuQKGoLtMIrLa0HWfEoYI+W8hriexTPLAN12u4vF8Wln7tCirizlfSqK6a Xag91bRze7t2HHj9PJCLJ1/HRdurlHwC1AuGBu7F0Q7hZBEuqDo6yrJO531TXnOEJgRwnQJmHxkfE 3OeQn7uA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:55436) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mhsds-0003mX-PL; Tue, 02 Nov 2021 12:11:52 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1mhsdp-0005Oz-CD; Tue, 02 Nov 2021 12:11:49 +0000 Date: Tue, 2 Nov 2021 12:11:49 +0000 From: "Russell King (Oracle)" To: Mark-PK Tsai Cc: ohad@wizery.com, bjorn.andersson@linaro.org, mathieu.poirier@linaro.org, matthias.bgg@gmail.com, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, yj.chiang@mediatek.com Subject: Re: [PATCH] remoteproc: use %d format string to print return error code Message-ID: References: <20211102120805.27137-1-mark-pk.tsai@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211102120805.27137-1-mark-pk.tsai@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211102_051203_582570_35BB9FC5 X-CRM114-Status: UNSURE ( 8.82 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Nov 02, 2021 at 08:08:05PM +0800, Mark-PK Tsai wrote: > Use %d format string to print return error code which > make the error message easier to understand. Even better, if you use %pe after converting "ret" to a pointer via ERR_PTR(ret), when the kernel is appropriately configured, the kernel will give a textual version of the error code, which is even easier! -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel