From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93952C433F5 for ; Wed, 3 Nov 2021 19:46:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 627D560FC2 for ; Wed, 3 Nov 2021 19:46:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 627D560FC2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=CINBVEPL7WEIRjVNoa0k4qjoVTIX91Fsp1bmIsnDYKk=; b=wUpsfg48S34UXWY5NhlsUb8bL8 x39lSAFyNMtSVMxoJ0J7bHWM890SkDZHk5cE2zya7G8qa8Glx6MMvh/U96fJG+uQuv1+3y/txphR8 AwjO4mMFSVCVqyNhSL4K4P0octV347yydhm4P9MUEa4mY4CA7/Khl4OTFShfY4ygXgLtvTi56AsyW fQ3my3xDrNEayH+/K+l1Byvwb6xpAl/23IlPMq/JGMO8z+aIbtNx5zzDG0CcjWUy/3zmzC7rrwIpJ 4LAk9j+lH2M2C61KuEyHqJdSDPm/g2rREG9DchxQe/70HlNEdWEnSr6P0YLj6sI0Nhrc3glfoVOpt F1wwu80A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1miMCe-006RQ9-Te; Wed, 03 Nov 2021 19:45:45 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1miMCb-006RP5-F4; Wed, 03 Nov 2021 19:45:42 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 470E960FC2; Wed, 3 Nov 2021 19:45:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1635968741; bh=oQwHcJhV75tudfQz9JXIXP43sTr35k5qkbqxxjX+yiA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UEPxrZxNGUovzKG1LrS+HDz5/l5tZHMXk4siPp76mEGXc3nj0QBLS60Y5Sy1DCFmt AZ9NEd4tU+cTquvmOTbNQsjQaavLv6VxzkRuIdSyAJHbw7ELVRjL69+wsnm6aUrxvv eTKtqR2IF6HaomD2FIgbJdHcibP/JYH0nXf5gOO/lQ4tWZ/jh1JJDgvVxgPbz4ZKmL w1pLghMJ4H7mnb0CP1AzgbnuJNVtj3u52doug3GMD567ewPpxWvzLmwDm2/WN5fl2J pK5+EBJWMAAat+L0K2ODFqhndIozbScA55wM7QRZ3IH5P18DwmYRWd6siMdrqevrS1 Vnb+8AOdMIXvQ== Date: Wed, 3 Nov 2021 19:45:35 +0000 From: Mark Brown To: Jim Quinlan Cc: linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Rob Herring , bcm-kernel-feedback-list@broadcom.com, james.quinlan@broadcom.com, Florian Fainelli , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , open list Subject: Re: [PATCH v7 5/7] PCI: brcmstb: Add control of subdevice voltage regulators Message-ID: References: <20211103184939.45263-1-jim2101024@gmail.com> <20211103184939.45263-6-jim2101024@gmail.com> MIME-Version: 1.0 In-Reply-To: <20211103184939.45263-6-jim2101024@gmail.com> X-Cookie: Thank God I'm an atheist. X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211103_124541_552662_3501396C X-CRM114-Status: GOOD ( 12.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============4612281728720793281==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============4612281728720793281== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="4Bn4OUkL+bJRmBog" Content-Disposition: inline --4Bn4OUkL+bJRmBog Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Nov 03, 2021 at 02:49:35PM -0400, Jim Quinlan wrote: > + for_each_property_of_node(dn, pp) { > + for (i = 0; i < ns; i++) { > + char prop_name[64]; /* 64 is max size of property name */ > + > + snprintf(prop_name, 64, "%s-supply", supplies[i]); > + if (strcmp(prop_name, pp->name) == 0) > + break; > + } > + if (i >= ns || pcie->num_supplies >= ARRAY_SIZE(supplies)) > + continue; > + > + pcie->supplies[pcie->num_supplies++].supply = supplies[i]; > + } Why are we doing this? If the DT omits the supplies the framework will provide dummy supplies so there is no need to open code handling for supplies not being present at all in client drivers. Just unconditionally ask for all the supplies. --4Bn4OUkL+bJRmBog Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmGC5toACgkQJNaLcl1U h9AbFAf+IFo802ZTgImd/SOw0tU2P5NR02kU1F9YzvxpTqde6/5HYQJYWeMUGJDa egO5QI0PCRh68Eq3wY4QCunv4kMkJW9zF3fD6xkCUD024RTFQyb2OPuCz34SSnVP 9IJ2e8fB8h7v0eSyg22SKBgzkzh6bPh8nK5KdlvNyeOoG3t+x8O1CKmvs74C8hpV tRadkEXmR46hD6JP+KiJj4oMnREO0pA0qdhwk1E2tNlA74+teWapp0tU9nW7vXb8 805+lD1BTiuq3hYLrxWuio/CFznhUqStn8gibTWTeiwSdcE/s1JP8uRmpE0Gv3X0 6bsCS1K7SyqqIte2HSRbv0Qj8p8eIg== =MzLw -----END PGP SIGNATURE----- --4Bn4OUkL+bJRmBog-- --===============4612281728720793281== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============4612281728720793281==--