From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B98CC433F5 for ; Mon, 8 Nov 2021 17:57:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DB64461458 for ; Mon, 8 Nov 2021 17:57:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org DB64461458 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0VkFuqgCyTLQp2E7YA9sPnvCFkOW/Jd6gE+ENnj7Jog=; b=EnDY1dw+5dL97O YgQjMAC9h1tZw0K1jokBEFI6SHdgQbJGsMabJFqoJ0/LK2RoZKq0zKLTWjous7YzluotyxDWmZdZZ fBxFJIXjS88SwhDPOEgU8CehR1k+rh4tUQCe5Zp9IDSxDxV+o0wQdCqtX28Q9Pdwv19yo7GgrjzOA 5CXd7goqftT54gtFuINp1Jv4fR5MfaLAUPpDJO/PZnUoB2UDIIKk1e3738AJCZ1yqdrzPjPKwi98y quY2pShOITGbb8SnvBxlDCJb/lgqn4tsYdnqFenhGJolk8NxKwr7G/N+Bylsr3stfIunuUEhHFsDN YkWUAiBJpZOFsVPjskTA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mk8s5-00H6Ar-I1; Mon, 08 Nov 2021 17:55:53 +0000 Received: from mail-oi1-x22d.google.com ([2607:f8b0:4864:20::22d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mk8s0-00H68t-Py for linux-arm-kernel@lists.infradead.org; Mon, 08 Nov 2021 17:55:51 +0000 Received: by mail-oi1-x22d.google.com with SMTP id bg25so28170085oib.1 for ; Mon, 08 Nov 2021 09:55:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=LhWfz+5JE21inJr4S250OgcbtsWmt4NJR6DvKNs5YBk=; b=NLZ/NWmaut34l69Gi0IMn3FhSPoI8MJxyT511eGKct44ivuZgMwua7hT0tOyLsDZUP TrgDXxUaUA7ChA+L3cFnC1wxXZ9OKrp2DAiclSjd/0dAqPiEQUMxdLhwh7TJBeW62J0y sxa7L/gO7PUUgBqELeaWYWMpjfyrDPN5orMWbR0tgee7qH946wvFrwRkNxmCE20baibN k+IRalaydJaBo+7hWaDZNjCRUOsSOX8GaiuqRGVUZ8nIAxdWVmPEL4ubW46Kx7KoptLH NXfufoYJtTJtYYpAQh2ZV1xuOG4OC8fEO2gNDc7SVhOr6lUM1CgDwpMx+e8MVxkv1JSD yRuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=LhWfz+5JE21inJr4S250OgcbtsWmt4NJR6DvKNs5YBk=; b=Y6xY4aFcSEYvljtqzAhXDQ3Or0j7qNSS11FBctuve1WonpHuXQs/+6WYDpwblOeKRY 2JdBHFZCH+YAD3kMWTHQWD2R5JRkfrrdiT6cummbloy4xvBhegz2PG08ewIEvc27506P iDATVGC1tE5TYbe/P5cWubGhCbH10bkix+y8qLbcw+LVfQ/n0uWsubK4RgXwYNA7/zJc cOiwLfFro5ZgtlN06tl9p8EwxBU++o5dCO8WTQ8TGFKPQsoN9CdeyythcwyQCkx4KMev 9NDdk/MrZd+uR0SDP6iMqILozMkFfTvOXzOhGG1BDhVsbwVxKU/LoAJxJeGajbis5ogy IS6g== X-Gm-Message-State: AOAM533O1OW2xFITWu1769mP9AxMki3g7KYqDEHQjWxXvqFQIQA7ziEp C6s9BddI0sck4KN4/lpmWFlnqA== X-Google-Smtp-Source: ABdhPJz9eQvKIrPc8ta+sw34+CJDdEJVNU0OWR59hAmfrup/u3GDs03M3CvU50HHVxV7g2TUwoHwZA== X-Received: by 2002:a05:6808:128d:: with SMTP id a13mr98463oiw.29.1636394142851; Mon, 08 Nov 2021 09:55:42 -0800 (PST) Received: from ripper (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id c16sm6822645oiw.31.2021.11.08.09.55.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Nov 2021 09:55:42 -0800 (PST) Date: Mon, 8 Nov 2021 09:57:19 -0800 From: Bjorn Andersson To: Rob Clark Cc: iommu@lists.linux-foundation.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Rob Clark , Will Deacon , Robin Murphy , Joerg Roedel , Jordan Crouse , Sai Prakash Ranjan , Shawn Guo , Eric Anholt , "moderated list:ARM SMMU DRIVERS" , open list Subject: Re: [PATCH] iommu/arm-smmu-qcom: Fix TTBR0 read Message-ID: References: <20211108171724.470973-1-robdclark@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211108171724.470973-1-robdclark@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211108_095548_856224_5571ADEC X-CRM114-Status: GOOD ( 16.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon 08 Nov 09:17 PST 2021, Rob Clark wrote: > From: Rob Clark > > It is a 64b register, lets not lose the upper bits. > > Fixes: ab5df7b953d8 ("iommu/arm-smmu-qcom: Add an adreno-smmu-priv callback to get pagefault info") > Signed-off-by: Rob Clark Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c > index 55690af1b25d..c998960495b4 100644 > --- a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c > +++ b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c > @@ -51,7 +51,7 @@ static void qcom_adreno_smmu_get_fault_info(const void *cookie, > info->fsynr1 = arm_smmu_cb_read(smmu, cfg->cbndx, ARM_SMMU_CB_FSYNR1); > info->far = arm_smmu_cb_readq(smmu, cfg->cbndx, ARM_SMMU_CB_FAR); > info->cbfrsynra = arm_smmu_gr1_read(smmu, ARM_SMMU_GR1_CBFRSYNRA(cfg->cbndx)); > - info->ttbr0 = arm_smmu_cb_read(smmu, cfg->cbndx, ARM_SMMU_CB_TTBR0); > + info->ttbr0 = arm_smmu_cb_readq(smmu, cfg->cbndx, ARM_SMMU_CB_TTBR0); > info->contextidr = arm_smmu_cb_read(smmu, cfg->cbndx, ARM_SMMU_CB_CONTEXTIDR); > } > > -- > 2.31.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel