From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C507FC433F5 for ; Tue, 9 Nov 2021 18:57:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7C92360FD8 for ; Tue, 9 Nov 2021 18:57:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7C92360FD8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=u/n6NvwYf1XnbhSrsc5sRU4gjiqRG+VOd1nF2u36X3A=; b=EnaDtk8xnrdNTj Vx5CsZEEu1vj1lEeiqYQrqWYQ8i+6+yy2RRKhohQSfaTJ5XLR2ekDHnPUj3hyR4nOBuMAO/3betOs YCNo7s4bgU4vrtmo3PZCVbdb5mAJw6TE0fHMaSV5yPoGi3dXpo1AnL3ogvKc0WfYTzyXcfz+tRgqz vrqMeLP2QmFyZMZuwDtbEaXEya9U/KXjuSl6LTcG2SDQovZW8rYyewkzHllYuaRuuM4vqKl1BhpY0 nDSEzcHQjCPJt496qRvATTbUm+Byr9J9dlhSgZw1auE1E6lILK3qoCjZbTGP6srb/i5ioJgonb+/A EqP/nzBoVOaIU+L7Bq3A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mkWI2-0032hj-08; Tue, 09 Nov 2021 18:56:14 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mkWHy-0032gj-TB for linux-arm-kernel@bombadil.infradead.org; Tue, 09 Nov 2021 18:56:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=u3FQPPMTwKhIwI4dCTCxShL7v0DIZcxjmFUSnXqOhSM=; b=an2LWyWTsLNHAU3v9uYogWfVbN E1OYqIrizTLqSaoInwXrDRQPKlaAX+hHZy7sXTM/VuqLvoQ7K7CcNRHeWSMOl1jUZGOsW9vUAJM2s LwkYyZ+bv9Sd7iGdAJONNFIInG7deBx2BTFNUJ5PTrpTYN4M6ue5Vvcfi/TXkcGI+cra01DHk6JWe VuJMrKRpv03P/sMx7dAUYN6XY1OJuzvjpm9biqka9DSexYoALAU5+vkP619vrr7cY1o7roJOc5fW5 8zu1KtfRNJuqluXlvOTNLWQ4GVibO4mfHYAZP28+U3qW0nn55LzOx5Gx2aSNxSIcDyum3b8j5Bzj4 NVDa3Tkw==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1mkWHv-00F76z-SZ; Tue, 09 Nov 2021 18:56:08 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 30F753000DD; Tue, 9 Nov 2021 19:56:07 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 144DC212EE599; Tue, 9 Nov 2021 19:56:07 +0100 (CET) Date: Tue, 9 Nov 2021 19:56:07 +0100 From: Peter Zijlstra To: Ard Biesheuvel Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Josh Poimboeuf , Jason Baron , Steven Rostedt , Mark Rutland , Kees Cook Subject: Re: [RFC PATCH 4/7] static_call: fix broken static_call_query() for non-exported keys Message-ID: References: <20211109164549.1724710-1-ardb@kernel.org> <20211109164549.1724710-5-ardb@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211109164549.1724710-5-ardb@kernel.org> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Nov 09, 2021 at 05:45:46PM +0100, Ard Biesheuvel wrote: > static_call_query() accesses the func member of the static call key > directly, which means that it is broken for cases where it is used from > a module and the key resides elsewhere and is not exported. > Arguably when the module can't change the value, it shouldn't be having any interest in obtaining said value either. I really think you're exporting too much. Modules aren't good, they deserve to suffer. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel