From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43237C433F5 for ; Wed, 10 Nov 2021 15:54:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 11B7B6112F for ; Wed, 10 Nov 2021 15:54:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 11B7B6112F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qMDRmlenHvJN2zI80lWkwOFDTJfxlGYcT21rVFEilJc=; b=JtOre73bkYh4nI kCrwEZ9X24d4TIqiFI03HantdFgmuNK5+lxij6mlegsA2grU71mfX/jsaiMES3aI/wkb9L9wPWjXi 1ae7ey7td4v9V3b8af6g/xlxQBp8lTKfOrygdjYTqHXxhEF+CoNOgTqnfsXI2hsFrbOaIO2ExzKmW /Mpcebs3d4ezVTPFFlo92AiQVyWFVnXeybAtipzMYOK8jAi/jtAuPwlifaUzjRotynrY4bIomV6jc aBVH0B7TGgPWajiDh2ssRtC7jKuctHZiqvAHCLY1Qejo18BpRkY0XXFrYT/3L2PeMgmxy76CRbb87 WHCJI1Am2JQDqGyqqG+A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mkptr-005lhO-1c; Wed, 10 Nov 2021 15:52:35 +0000 Received: from mail-eopbgr60052.outbound.protection.outlook.com ([40.107.6.52] helo=EUR04-DB3-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mkptn-005lfr-Hs for linux-arm-kernel@lists.infradead.org; Wed, 10 Nov 2021 15:52:33 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZO+9p+W3+HYueqABh3ZR4JVbmLdHmwVnE6/ERNJlM3nl5OCSHm/fgj7BlpIr6arEHug3Jkk2uqku5BWleZso+Kf4q5iCGD1Gskv01IpBD2pectxmjMafEw+PwCRYE0NzvJs9j7XvpsPqE94csbmHRfaa4/f0u4EJLs/tc2ZyVARiT/bq9ShYkHlUkMF/FA+MSNiZfU1FEgTr072KCFy1UN2NVcw+PbjXyhTlBjldifSx/xQLT8By1uHheK2TcwTUnPChaEpdpIBONgMOPsaogHILjFDgdVGHTJ3SL46NRBD4T05prWg+wWrIixZf8KXteokmQagH3+sDiooMjeF/wQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dmAS/dYJAlW/eR43yaZtZsorQr21y5X61frfyHAOpNI=; b=YsEf3jw1EaTbtVBeAz3x7HKHzrbMNrMGBAnlIyASGIFuOvokmHqxowpYjxd7pifg0RGPraaji6I5FliMeVwpiJbFm1Y1F+xB6tgYv+4zAwzfshcGJJg+Fd0jO/iGcwpbtsQznqmDqXkqEpfzrCoYaUmQpG7tGZdsjh8v057+kt7G//S2Y/q0JpXXj9Z/sWyZRsJDCSFoeHv1fjK+jIQQX+9jFusUN1LnpIl/6IEu/fdhLOxwaq9Yrh35g22ujHpRVceTGcR6jKprVpKalcNxMoDaAR1fR14E0EP5nIak2v4qXKLzXzrjw+2zo1xX3qjypyrUky3xpJ5vK9QW9HBvJQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dmAS/dYJAlW/eR43yaZtZsorQr21y5X61frfyHAOpNI=; b=GNRsHsB2RZ01b7p+pMV1zWyYM8SHkqhLtV2Srh8mclS/Mul//SiUBPN9P47duG6Ggr+bWftbKEJpx8spgJP9qNVCqe7OXPJ7BUuCX7wh0S2zhjoQ4A/x8uA4Ph9P1Q5rWz5W2hi1dP29YnzMk5IRw4XTVQMI5tTKW3XYWf1kipU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from VI1PR04MB4688.eurprd04.prod.outlook.com (2603:10a6:803:6a::30) by VI1PR0401MB2304.eurprd04.prod.outlook.com (2603:10a6:800:29::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.15; Wed, 10 Nov 2021 15:52:21 +0000 Received: from VI1PR04MB4688.eurprd04.prod.outlook.com ([fe80::885c:ddee:c614:9787]) by VI1PR04MB4688.eurprd04.prod.outlook.com ([fe80::885c:ddee:c614:9787%7]) with mapi id 15.20.4690.016; Wed, 10 Nov 2021 15:52:21 +0000 Date: Wed, 10 Nov 2021 17:52:19 +0200 From: Abel Vesa To: Rob Herring Cc: Dong Aisheng , Shawn Guo , Sascha Hauer , Greg Kroah-Hartman , Fabio Estevam , Pengutronix Kernel Team , linux-i2c@vger.kernel.org, linux-serial@vger.kernel.org, NXP Linux Team , Linux Kernel Mailing List , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Subject: Re: [PATCH v3 09/11] dt-bindings: i2c: i2c-imx-lpi2c: Fix dtbs_check compatible oneOf error Message-ID: References: <1633526764-30151-1-git-send-email-abel.vesa@nxp.com> <1633526764-30151-10-git-send-email-abel.vesa@nxp.com> Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: VE1PR03CA0012.eurprd03.prod.outlook.com (2603:10a6:802:a0::24) To VI1PR04MB4688.eurprd04.prod.outlook.com (2603:10a6:803:6a::30) MIME-Version: 1.0 Received: from ryzen (5.12.226.136) by VE1PR03CA0012.eurprd03.prod.outlook.com (2603:10a6:802:a0::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.15 via Frontend Transport; Wed, 10 Nov 2021 15:52:21 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 57de3ef6-85a2-4803-6b01-08d9a46214f4 X-MS-TrafficTypeDiagnostic: VI1PR0401MB2304: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4714; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /d6gvUo+TVaOlMqnoHKzMf1hAyYCNFUQsuScSU4AYGhWD9KXJd5GxAfMJ2flMUrCmA2UPvT6/kt91AmvE70JMwzyb9LubIkB/t0YNIyDzwZ3LkPU2K4SJz2NO+lDtyBH6qlhnXUsA+BK8rvkDRp51W35HNCaN3RWJHqPWk8EBDPRZ0cTS56lssdOcWQI5R1Jl05u9r08b8RV9akd7DXmaoqbEUJi3B4pK1al+qga7/a/l4uH69qNJNrJ6cKNIe4EgRVE2s2bQ3W68r5qfek+Zl7ukSWMePKKxkOZVTg5k/86YT+91y1XsfLr1BeKkQG8d6px7uARblf71bad1tSUoLkPo12t/CLaabpV8zOwwe5OEYp2eXSdLUX1DXT14ahmPVPihV7h3VHGdbLf41tvkVMjBINZSoFFgVgyAIDCXXRnIB1MFKAgsIgpr6qpxkzeEY+ypYG+SuIX64Wq5WofVKzk4BskmbpAEsOs3y6PoSVjFsZMvZgdu5XsL/QypwebBvvfOl1+c0ileb8GR0dfiYDaO8gmD7isTqDKP1t4VQc5KF+wKeaDo8H9mu8/VmAEUDWDsJ//Dexlvg1S2Uca4OYWs1GHh9a+6mr7cFyDQExK9skYyacWcwjDqtX9l4qe6x2cBKR8aWCtUpf1jBuAPNrPcuXcYW93CzztkaYVOMJ46IxoOjwTsnipvi4K3t4eGNwiy0N6NplWWA8PcDfTnw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB4688.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(5660300002)(508600001)(316002)(8676002)(66946007)(6916009)(33716001)(54906003)(4326008)(9576002)(8936002)(7416002)(956004)(83380400001)(2906002)(38100700002)(38350700002)(53546011)(55016002)(66556008)(9686003)(186003)(26005)(66476007)(52116002)(6496006)(44832011)(86362001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?gdGP76ppxksbza41wRzG8snTWZ8CmB3wXpVfddAm7Gi76G41A8Gu0wwfOBHe?= =?us-ascii?Q?miQJ23I5b0gijJ74OYVNKDoRtHAMAeUADoIuCHyAfR90JWkZCNHCwsEaGG10?= =?us-ascii?Q?ahVhpYSzyCbjl7OHYYXPWPyJ3iMxGqk1rzrexsDfB/xfLnYGa9klYrAaqv7q?= =?us-ascii?Q?/ulcJ+9zTOlOt5t5KWiRbmgssFhnjqjg8LnLXMauB2CKRREyZpMlO30ROBiN?= =?us-ascii?Q?uNLdKK26CZrAmoiP3jLhlO1uB7jxitVVe7dVn/zsWUGqw1YheTUlQfNvWVu7?= =?us-ascii?Q?pbact509PG2e+ZOiV5wCAqaBqB89xVhjEgDFySfzvpXX/gYDcebUWSiXvgzD?= =?us-ascii?Q?rjhgghRuEnXDADoluiHbH+XJ/3yF+iaOx20J6KL8vNtEXDc4EjnzM9nEk1O1?= =?us-ascii?Q?X5U8wc14x+M47ngdnPWLWQZjttwA5piJKc2FQxZP5tSj+s7mcqCru4IdGNcF?= =?us-ascii?Q?5bzgHo5uxDuGFzlc8r1xAOPlBbNty7yVZzW3jMczyxv+RY70/LKF0x1eEYwR?= =?us-ascii?Q?wEkKG8kjhc1/QnmZJuQLd3Gt4Tz8io80AnVRWLqu6df+p01U5p/jxqx2bGBa?= =?us-ascii?Q?/mazOu6PLhYvqtJAl8dAa61yyWCuV/IFNbKUvHnlwIE924ZCjS7HTX0OvlDJ?= =?us-ascii?Q?dsZLgQm94U69IwIEjvsu+7JThX3OZZQhTzFFww/Gs8WtQMdlgo+YXMk3Fkl6?= =?us-ascii?Q?KPOQMYppcgaQVDwcos0fokmjq6MZgtWscmQS8j3Fol4+Oj+1ObhllllB8j0C?= =?us-ascii?Q?MDmYapNql0XJC6psht5kKFLhfvA26C0Fsl91e9DLEi0HkP2Q8ux0YLdz7shN?= =?us-ascii?Q?Ak/ANE6F7kCWlPU2ImqYyMKEFN8+Z3EPXOKVO3kvpIjqR87Lj15glGEci5vU?= =?us-ascii?Q?vbxkvIAoIisA2T7/rHfA/RKHoEiwRSihJt8m7CACNnJwYNkY3AnRQBRUskU9?= =?us-ascii?Q?KlGiwTg5bXyGRXXFaYEiyND9tInXl9uwp4AzGRhDQre9Pn6RLn2GFO7vHY+/?= =?us-ascii?Q?6UdFjsNor9ibJ4j+7Y3yzgOLagTkIfn3oG+U8a8IqLd1+GoRLGgbILphv/Xv?= =?us-ascii?Q?AaWdxaIKl634eih0C92D+3CclZhrhCTYdwCnlb3z/JFtoOayAexk/qosAu1+?= =?us-ascii?Q?TFnHaJ4iixXRtx2C834nEB/o1qzE4K13bNRb/hGsuOvxENGTyUFkGHESnP/G?= =?us-ascii?Q?R19ifay58FwZvxKTQve6HaTB8S9T4Ay0oPMIBt0sziZB73QF7w23cYc6TGrL?= =?us-ascii?Q?RQ+Nu+3WD8KGC3N9VQ0LAl8HYsJaz/p/u0JR3mlGiVQBh1DerRVycJATh9wU?= =?us-ascii?Q?fqFxxlv2nuh1yKVdE3o3c0Oz0hdYOt0D+tPt2alqJD2B33CBGfrj8NweHFkZ?= =?us-ascii?Q?BswXOJwt1Ev2n+EVNJYBddJgADP2hVKRrA7eFXVDV9l1vBduwPorD3vxZ8B3?= =?us-ascii?Q?E2d+PL3reL/DlGu6Z1nvsERbYhcctLX04vr0XAy2pQU+4f7aqWa8xw56ceBN?= =?us-ascii?Q?YOsd753GM11ff8B/pByZyPuUSlL6lRhmZuk+bQGeuvdAq7i7wbdHk/7AS09X?= =?us-ascii?Q?0E9YFl0RR8IzXwDD5DC3q4sipDSpn/tqHtBH6UGw+dt+/MLn8+PB0qOt+2sq?= =?us-ascii?Q?Y7Y56ZoRUwEcnLaZa9IFdFA=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 57de3ef6-85a2-4803-6b01-08d9a46214f4 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB4688.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2021 15:52:21.7866 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YmLacRCceOq7qO2/7XEh70l8oqqPunHPnMG9B0FPIL7TyqTFF8hFwNh2IPu4xMTTh/lgtiPUCgRInap5Rozt8A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2304 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211110_075231_647212_6EEB3BF4 X-CRM114-Status: GOOD ( 20.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 21-10-14 15:02:19, Rob Herring wrote: > On Wed, Oct 06, 2021 at 04:26:02PM +0300, Abel Vesa wrote: > > Fix following dtbs_check error: > > > > arch/arm64/boot/dts/freescale/imx8qm-mek.dt.yaml: > > i2c@5a800000: compatible: 'oneOf' conditional failed, one must be fixed: > > ['fsl,imx8qm-lpi2c', 'fsl,imx7ulp-lpi2c'] is too long > > Additional items are not allowed ('fsl,imx7ulp-lpi2c' was > > unexpected) > > 'fsl,imx8qxp-lpi2c' was expected > > From schema: > > Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml > > > > Signed-off-by: Abel Vesa > > --- > > Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml b/Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml > > index 29b9447f3b84..acf2d5f45f4e 100644 > > --- a/Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml > > +++ b/Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml > > @@ -18,8 +18,11 @@ properties: > > - enum: > > - fsl,imx7ulp-lpi2c > > - fsl,imx8qm-lpi2c > > + - fsl,imx8qxp-lpi2c > > Both with and without a fallback should not be valid. > > Why are you changing fsl,imx8qxp-lpi2c when the error was for > fsl,imx8qm-lpi2c? > Sorry for the late reply. I assume the correct way would be like: oneOf: - enum: - fsl,imx7ulp-lpi2c - items: - enum: - fsl,imx8dxl-lpi2c - fsl,imx8qxp-lpi2c - fsl,imx8qm-lpi2c - const: fsl,imx7ulp-lpi2c Right ? Since all the possible combinations are: compatible = "fsl,imx8dxl-lpi2c", "fsl,imx7ulp-lpi2c"; compatible = "fsl,imx8qm-lpi2c", "fsl,imx7ulp-lpi2c"; compatible = "fsl,imx8qxp-lpi2c", "fsl,imx7ulp-lpi2c"; compatible = "fsl,imx7ulp-lpi2c"; > > - items: > > - - const: fsl,imx8qxp-lpi2c > > + - enum: > > + - fsl,imx8qm-lpi2c > > + - fsl,imx8qxp-lpi2c > > - const: fsl,imx7ulp-lpi2c > > > > reg: > > -- > > 2.31.1 > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel