From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Chris Snook <chris.snook@gmail.com>, Felix Fietkau <nbd@nbd.name>,
Florian Fainelli <f.fainelli@gmail.com>,
John Crispin <john@phrozen.org>,
Mark Lee <Mark-MC.Lee@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Michal Simek <michal.simek@xilinx.com>,
Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>,
Sean Wang <sean.wang@mediatek.com>,
Vivien Didelot <vivien.didelot@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Heiner Kallweit <hkallweit1@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, netdev@vger.kernel.org
Subject: Re: [PATCH RFC net-next 5/8] net: ag71xx: mark as a legacy_pre_march2020 phylink driver
Date: Tue, 23 Nov 2021 18:05:59 +0000 [thread overview]
Message-ID: <YZ0th75Vr9M0u6So@shell.armlinux.org.uk> (raw)
In-Reply-To: <E1mpSbK-00BXoo-UE@rmk-PC.armlinux.org.uk>
On Tue, Nov 23, 2021 at 10:00:34AM +0000, Russell King (Oracle) wrote:
> ag71xx has a PCS, but does not make use of the phylink PCS support.
> Mark it was a pre-March 2020 driver.
>
> Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Hi,
I've just been looking closer at this driver, and it seems that we can
drop the "legacy_pre_march2020" flag, and in doing so, delete the
ag71xx_mac_pcs_get_state and ag71xx_mac_an_restart functions entirely,
removing them from ag71xx_phylink_mac_ops.
Should this driver need to deal with the PCS - in other words, to
modify the advertisement, then it will need to make use of the
phylink_pcs support.
I'll send a v2 in a day or two.
Thanks!
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-11-23 18:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-23 9:52 [PATCH RFC net-next 0/8] net: phylink: introduce legacy mode flag Russell King (Oracle)
2021-11-23 10:00 ` [PATCH RFC net-next 1/8] net: dsa: consolidate phylink creation Russell King (Oracle)
2021-11-23 10:00 ` [PATCH RFC net-next 2/8] net: phylink: add legacy_pre_march2020 indicator Russell King (Oracle)
2021-11-23 10:00 ` [PATCH RFC net-next 3/8] net: dsa: mark DSA phylink as legacy_pre_march2020 Russell King (Oracle)
2021-11-23 10:00 ` [PATCH RFC net-next 4/8] net: mtk_eth_soc: mark as a legacy_pre_march2020 driver Russell King (Oracle)
2021-11-23 10:00 ` [PATCH RFC net-next 5/8] net: ag71xx: mark as a legacy_pre_march2020 phylink driver Russell King (Oracle)
2021-11-23 18:05 ` Russell King (Oracle) [this message]
2021-11-23 10:00 ` [PATCH RFC net-next 6/8] net: axienet: " Russell King (Oracle)
2021-11-23 10:00 ` [PATCH RFC net-next 7/8] net: phylink: use legacy_pre_march2020 Russell King (Oracle)
2021-11-23 10:00 ` [PATCH RFC net-next 8/8] net: phylink: allow PCS to be removed Russell King (Oracle)
2021-11-23 12:08 ` Vladimir Oltean
2021-11-23 16:08 ` Russell King (Oracle)
2021-11-23 17:30 ` Sean Anderson
2021-11-23 18:15 ` Vladimir Oltean
2021-11-23 19:04 ` Sean Anderson
2021-11-23 19:30 ` Vladimir Oltean
2021-11-23 19:50 ` Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZ0th75Vr9M0u6So@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=Mark-MC.Lee@mediatek.com \
--cc=andrew@lunn.ch \
--cc=chris.snook@gmail.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=john@phrozen.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=michal.simek@xilinx.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=radhey.shyam.pandey@xilinx.com \
--cc=sean.wang@mediatek.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).