From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: Sean Anderson <sean.anderson@seco.com>,
Chris Snook <chris.snook@gmail.com>, Felix Fietkau <nbd@nbd.name>,
Florian Fainelli <f.fainelli@gmail.com>,
John Crispin <john@phrozen.org>,
Mark Lee <Mark-MC.Lee@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Michal Simek <michal.simek@xilinx.com>,
Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>,
Sean Wang <sean.wang@mediatek.com>,
Vivien Didelot <vivien.didelot@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Heiner Kallweit <hkallweit1@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, netdev@vger.kernel.org
Subject: Re: [PATCH RFC net-next 8/8] net: phylink: allow PCS to be removed
Date: Tue, 23 Nov 2021 19:50:17 +0000 [thread overview]
Message-ID: <YZ1F+dD3Jwc/k1Xw@shell.armlinux.org.uk> (raw)
In-Reply-To: <20211123193017.rtvxyvb3oheqoxlz@skbuf>
On Tue, Nov 23, 2021 at 09:30:17PM +0200, Vladimir Oltean wrote:
> Sorry if you feel like I am asking too many questions. I just want to
> understand what I'm being asked to review here :)
>
> So going back to the initial question. What use case do these patches
> help to make some progress with?
If we exclude patch 8, this series:
1) identifies all those drivers that are reliant on the legacy behaviour
of phylink, which can then be targetted for modernisation - some of
which may be trivial to do. ag71xx and axienet have turned out to be
two drivers that can be trivially converted.
2) hopefully stops the legacy use finding its way into new drivers by
making it easier to spot in review, but hopefully people will realise
that setting the legacy flag in their driver to use the old hooks is
something they probably want to avoid.
3) gives consistent phylink behaviour to modern drivers which may or
may not decide to register a PCS with phylink.
(3) is probably the most important point for any driver that registers
a PCS conditionally. Right now, any driver that does this gets a
slightly different behaviour from phylink as detailed in patch 7.
I would like to remove the legacy code and old .mac_pcs_get_state and
.mac_an_restart callbacks some day...
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2021-11-23 19:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-23 9:52 [PATCH RFC net-next 0/8] net: phylink: introduce legacy mode flag Russell King (Oracle)
2021-11-23 10:00 ` [PATCH RFC net-next 1/8] net: dsa: consolidate phylink creation Russell King (Oracle)
2021-11-23 10:00 ` [PATCH RFC net-next 2/8] net: phylink: add legacy_pre_march2020 indicator Russell King (Oracle)
2021-11-23 10:00 ` [PATCH RFC net-next 3/8] net: dsa: mark DSA phylink as legacy_pre_march2020 Russell King (Oracle)
2021-11-23 10:00 ` [PATCH RFC net-next 4/8] net: mtk_eth_soc: mark as a legacy_pre_march2020 driver Russell King (Oracle)
2021-11-23 10:00 ` [PATCH RFC net-next 5/8] net: ag71xx: mark as a legacy_pre_march2020 phylink driver Russell King (Oracle)
2021-11-23 18:05 ` Russell King (Oracle)
2021-11-23 10:00 ` [PATCH RFC net-next 6/8] net: axienet: " Russell King (Oracle)
2021-11-23 10:00 ` [PATCH RFC net-next 7/8] net: phylink: use legacy_pre_march2020 Russell King (Oracle)
2021-11-23 10:00 ` [PATCH RFC net-next 8/8] net: phylink: allow PCS to be removed Russell King (Oracle)
2021-11-23 12:08 ` Vladimir Oltean
2021-11-23 16:08 ` Russell King (Oracle)
2021-11-23 17:30 ` Sean Anderson
2021-11-23 18:15 ` Vladimir Oltean
2021-11-23 19:04 ` Sean Anderson
2021-11-23 19:30 ` Vladimir Oltean
2021-11-23 19:50 ` Russell King (Oracle) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZ1F+dD3Jwc/k1Xw@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=Mark-MC.Lee@mediatek.com \
--cc=andrew@lunn.ch \
--cc=chris.snook@gmail.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=john@phrozen.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=michal.simek@xilinx.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=radhey.shyam.pandey@xilinx.com \
--cc=sean.anderson@seco.com \
--cc=sean.wang@mediatek.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).