From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 874C7C433F5 for ; Tue, 23 Nov 2021 19:51:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8XzsDcn+gGEIWvvwXfMx2zOtbW+Xx6hxLfC2ldHOED0=; b=thPvSXcNuzjd/C GB3r0l6sJNzz7Jd/TAiYNcdCF4Fz8toXgplcmTS2wMn+eHD6tyIogKs7NmVzwheUNkB89cqOBWBpM kLp3I1KSfV5Y/Tf7866P6ieiIhcqWIOGr/SgZm0CSv+6KQl5wMp+M/vqNB149uyLVPJUIC+lQWZfz pJMADfuLsJ+no9baLi13HKAP+0bdl1+INnA+TmFZFatWt5PsMDJRlpo+GphrkVBSUVgINjyMztHj6 2xmlWNZ3SPVh6JQQm1iPxa3+pSR+7mDhBV3GmxTfpF0rN+GdcYpsH+vD06YilNNaZuut8i5I3gzid uYK9eINcCNqqYMABjx2w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mpboL-003NBK-8a; Tue, 23 Nov 2021 19:50:37 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mpboH-003NAr-Pj; Tue, 23 Nov 2021 19:50:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=JqPQT+5l4PKOmnzgMmJcdponKw5AJ1lusJwfSB+JKtc=; b=I1bAbDItaiXpFxQ3LNSctXv/hd hEj16n9n5ke8/jcmeowt/V6FIcyeQtBWHs/VBbai21S2YagXJxPXNyE8G4Pw4XdqNAaEYoxUJ8Mgj VKRWp1zwhF4HDIQKkqaQx3oGPhzvynHhI5v0sBnJD8MO35BLZXeVyZ1MrVn3UXrqRe9mDvDYDA2U1 xlAVJ0QaE449Z+bVT8nAdZxJSYODYSHi6nMOWzzygi67PH8W8VIzQ79drEiDSQcBkrWmEaV4JlkOm gYyNHkn9Y12R7rTJEQAtJxeXglN//mWe/SAqCBoO6Ui54t9bph0/ZKX6wk9TqyHHHHhP3VGBufPxk fge9XwBA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:55826) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mpbo4-0008Kl-Iw; Tue, 23 Nov 2021 19:50:20 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1mpbo1-0000V4-4Y; Tue, 23 Nov 2021 19:50:17 +0000 Date: Tue, 23 Nov 2021 19:50:17 +0000 From: "Russell King (Oracle)" To: Vladimir Oltean Cc: Sean Anderson , Chris Snook , Felix Fietkau , Florian Fainelli , John Crispin , Mark Lee , Matthias Brugger , Michal Simek , Radhey Shyam Pandey , Sean Wang , Vivien Didelot , Andrew Lunn , "David S. Miller" , Heiner Kallweit , Jakub Kicinski , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, netdev@vger.kernel.org Subject: Re: [PATCH RFC net-next 8/8] net: phylink: allow PCS to be removed Message-ID: References: <20211123120825.jvuh7444wdxzugbo@skbuf> <90262b1c-fee2-f906-69df-1171ff241077@seco.com> <20211123181515.qqo7e4xbuu2ntwgt@skbuf> <472ce8f0-a592-ce5b-0005-7d765b2d0e93@seco.com> <20211123193017.rtvxyvb3oheqoxlz@skbuf> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211123193017.rtvxyvb3oheqoxlz@skbuf> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211123_115033_861431_AF4BE018 X-CRM114-Status: GOOD ( 14.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Nov 23, 2021 at 09:30:17PM +0200, Vladimir Oltean wrote: > Sorry if you feel like I am asking too many questions. I just want to > understand what I'm being asked to review here :) > > So going back to the initial question. What use case do these patches > help to make some progress with? If we exclude patch 8, this series: 1) identifies all those drivers that are reliant on the legacy behaviour of phylink, which can then be targetted for modernisation - some of which may be trivial to do. ag71xx and axienet have turned out to be two drivers that can be trivially converted. 2) hopefully stops the legacy use finding its way into new drivers by making it easier to spot in review, but hopefully people will realise that setting the legacy flag in their driver to use the old hooks is something they probably want to avoid. 3) gives consistent phylink behaviour to modern drivers which may or may not decide to register a PCS with phylink. (3) is probably the most important point for any driver that registers a PCS conditionally. Right now, any driver that does this gets a slightly different behaviour from phylink as detailed in patch 7. I would like to remove the legacy code and old .mac_pcs_get_state and .mac_an_restart callbacks some day... -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel