From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Vladimir Murzin <vladimir.murzin@arm.com>
Cc: linux-arm-kernel@lists.infradead.org, ardb@kernel.org
Subject: Re: [PATCH] ARM: NOMMU: Reload __secondary_data after PROCINFO_INITFUNC
Date: Thu, 25 Nov 2021 10:58:47 +0000 [thread overview]
Message-ID: <YZ9sZ1bKg7pCV2iJ@shell.armlinux.org.uk> (raw)
In-Reply-To: <20211125104841.46128-1-vladimir.murzin@arm.com>
On Thu, Nov 25, 2021 at 10:48:41AM +0000, Vladimir Murzin wrote:
> __secondary_data used to reside in r7 around call to
> PROCINFO_INITFUNC. After commit 95731b8ee63e ("ARM: 9059/1: cache-v7:
> get rid of mini-stack") r7 is used as a scratch register, so we have
> to reload __secondary_data before we setup the stack pointer.
>
> Fixes: 95731b8ee63ec9419822a51cd9878fa32582fdd2 ("ARM: 9059/1: cache-v7: get rid of mini-stack")
Documentation/process/submitting-patches.rst requests only 12 digits for
the sha1 in the fixes line, which makes this:
Fixes: 95731b8ee63e ("ARM: 9059/1: cache-v7: get rid of mini-stack")
and avoids it being unnecessarily long. Please make that change before
sending it to the patch system, thanks.
Other than that, patch looks good, thanks.
>
> Signed-off-by: Vladimir Murzin <vladimir.murzin@arm.com>
> ---
> arch/arm/kernel/head-nommu.S | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/kernel/head-nommu.S b/arch/arm/kernel/head-nommu.S
> index 0fc814b..8796a69 100644
> --- a/arch/arm/kernel/head-nommu.S
> +++ b/arch/arm/kernel/head-nommu.S
> @@ -114,6 +114,7 @@ ENTRY(secondary_startup)
> add r12, r12, r10
> ret r12
> 1: bl __after_proc_init
> + ldr r7, __secondary_data @ reload r7
> ldr sp, [r7, #12] @ set up the stack pointer
> mov fp, #0
> b secondary_start_kernel
> --
> 2.7.4
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-11-25 11:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-25 10:48 [PATCH] ARM: NOMMU: Reload __secondary_data after PROCINFO_INITFUNC Vladimir Murzin
2021-11-25 10:58 ` Russell King (Oracle) [this message]
2021-11-25 11:09 ` Vladimir Murzin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZ9sZ1bKg7pCV2iJ@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=ardb@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=vladimir.murzin@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).