From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9DF3CC433F5 for ; Thu, 25 Nov 2021 11:02:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sHnM0oXiIyDnElRWK2py5UL5F7w0m65ss7kDf0vE12I=; b=CvFXxQJO0XC0jC YRgmVACiYcoZXGix0fmyZ395us0R6srP0YssjNyn8x8c1fz5HV8ymwMo0y9Y2BPBCWvH1IhNzLCMW MqYEo2UYbvxjzrhf2FeaPeanb9ZvE9ZS8AoBuFG7zIYJByg3d3FcfL5UaAh9mHnoLWlRFb7OcsE0A izEgofMUKng8aFR8M6Dz6p8Nqn4RICF2twqMMCJCmMx9z3c40eaEU95V3w4ZT4RvaJM8S0NPyJoXc rHufFs8yZ2gyv0HS7+5oRK8JWw3mzc9tDvAyFWFm4GDFdadkwE7BfQbxzpUc3oqezYlOkeX4Wvn/b ZU9hTTcE1n97vqf8dT5g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mqCUu-0078tg-NL; Thu, 25 Nov 2021 11:01:00 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mqCUq-0078fu-4v for linux-arm-kernel@lists.infradead.org; Thu, 25 Nov 2021 11:00:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=DjAnYzRJafCTfZ7A711ef6sKMKAk8MrZUTW08Zx6NjA=; b=gQOnfDSrFjyNAXfqxVpnsnnh43 /uyI6vExipTMnUwwOWfnVSMkVdrl2o0Xq5+PWxzBx6ER93ftC7mRNq83dAIit5yMYGpSkNwEsB3vb ulhfYGSpPmol5aD/eiRtS2eBV5TQ5mhUgBXfRFmc77xoRwKYxtV56W8SmZUIbrjwaaRXkB9jdHMU9 X17BWssVWbFk7ZXsMPCg2aSzL2Pbcgsn6P7sM8zJx3Gwmi7NHJ10GG/NBfmIumb7M3ZFGYqM39SPY l1ddehB/5ElxoRDx3MtiZu61EebsPyR2Rdbidj47RgsRVWUTzJ0Kd0+4gYcfeRwWpkzaVIRd1qzp7 NdJI+7nQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:55886) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mqCSm-0001l0-QK; Thu, 25 Nov 2021 10:58:48 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1mqCSl-00026b-PY; Thu, 25 Nov 2021 10:58:47 +0000 Date: Thu, 25 Nov 2021 10:58:47 +0000 From: "Russell King (Oracle)" To: Vladimir Murzin Cc: linux-arm-kernel@lists.infradead.org, ardb@kernel.org Subject: Re: [PATCH] ARM: NOMMU: Reload __secondary_data after PROCINFO_INITFUNC Message-ID: References: <20211125104841.46128-1-vladimir.murzin@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211125104841.46128-1-vladimir.murzin@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211125_030056_215017_FC4DFEEA X-CRM114-Status: GOOD ( 16.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 25, 2021 at 10:48:41AM +0000, Vladimir Murzin wrote: > __secondary_data used to reside in r7 around call to > PROCINFO_INITFUNC. After commit 95731b8ee63e ("ARM: 9059/1: cache-v7: > get rid of mini-stack") r7 is used as a scratch register, so we have > to reload __secondary_data before we setup the stack pointer. > > Fixes: 95731b8ee63ec9419822a51cd9878fa32582fdd2 ("ARM: 9059/1: cache-v7: get rid of mini-stack") Documentation/process/submitting-patches.rst requests only 12 digits for the sha1 in the fixes line, which makes this: Fixes: 95731b8ee63e ("ARM: 9059/1: cache-v7: get rid of mini-stack") and avoids it being unnecessarily long. Please make that change before sending it to the patch system, thanks. Other than that, patch looks good, thanks. > > Signed-off-by: Vladimir Murzin > --- > arch/arm/kernel/head-nommu.S | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/kernel/head-nommu.S b/arch/arm/kernel/head-nommu.S > index 0fc814b..8796a69 100644 > --- a/arch/arm/kernel/head-nommu.S > +++ b/arch/arm/kernel/head-nommu.S > @@ -114,6 +114,7 @@ ENTRY(secondary_startup) > add r12, r12, r10 > ret r12 > 1: bl __after_proc_init > + ldr r7, __secondary_data @ reload r7 > ldr sp, [r7, #12] @ set up the stack pointer > mov fp, #0 > b secondary_start_kernel > -- > 2.7.4 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel