From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 856F1C433EF for ; Tue, 16 Nov 2021 17:38:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5619F615A4 for ; Tue, 16 Nov 2021 17:38:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5619F615A4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wd5H8jXoCLKCJGTqyosFRm+1QXOl+eMUyIsuHk356G8=; b=IVwYudh3RFGeoY CS5wp5WTZGTFVz6kquBM/ohny0cPS4ZDIk5/TT2vPnOTa9V1UppjPEhNPLgndB6r/ACW2MgoOYR1a +8u9ZZQAhs2miqLD8d1Iv2uZTzDj4hhqa6tz+rED9pIfm431vi1fxRjj7y6QlC2twSg3z5Smr+u3q jiyHZQH0ddDJBurj+74C2n81lcDceLP7YTXfTuNRmFPPL8xFRFcpQR1yQeydQJmKFy7wtc3ur9r/k DTW7DusRUwHvb/iNjlH72VyOdgVlSWEOt0IYqx0LAhZEWDSyrrr9Gy9T0MKNq7RO/9ARYh/bXJ2l8 dC0agO5yzUtAbiQlKo8g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mn2Ny-002TiC-OQ; Tue, 16 Nov 2021 17:36:46 +0000 Received: from relay3-d.mail.gandi.net ([217.70.183.195]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mn2Nu-002Th5-BY for linux-arm-kernel@lists.infradead.org; Tue, 16 Nov 2021 17:36:44 +0000 Received: (Authenticated sender: alexandre.belloni@bootlin.com) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 67A7560011; Tue, 16 Nov 2021 17:36:34 +0000 (UTC) Date: Tue, 16 Nov 2021 18:36:33 +0100 From: Alexandre Belloni To: Colin Foster , =?iso-8859-1?Q?Cl=E9ment_L=E9ger?= Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, Greg Kroah-Hartman , "Rafael J. Wysocki" , Vladimir Oltean , Claudiu Manoil , UNGLinuxDriver@microchip.com, Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S. Miller" , Jakub Kicinski , Ioana Ciornei , Heiner Kallweit , Russell King , Lars Povlsen , Steen Hegelund , Linus Walleij , Philipp Zabel , Heikki Krogerus , Andy Shevchenko Subject: Re: [RFC PATCH v4 net-next 11/23] pinctrl: ocelot: update pinctrl to automatic base address Message-ID: References: <20211116062328.1949151-1-colin.foster@in-advantage.com> <20211116062328.1949151-12-colin.foster@in-advantage.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211116062328.1949151-12-colin.foster@in-advantage.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211116_093642_581345_42E2A1FA X-CRM114-Status: GOOD ( 17.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello, On 15/11/2021 22:23:16-0800, Colin Foster wrote: > struct gpio_chip recommends passing -1 as base to gpiolib. Doing so avoids > conflicts when the chip is external and gpiochip0 already exists. > = > Signed-off-by: Colin Foster > --- > drivers/pinctrl/pinctrl-ocelot.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > = > diff --git a/drivers/pinctrl/pinctrl-ocelot.c b/drivers/pinctrl/pinctrl-o= celot.c > index cc7fb0556169..f015404c425c 100644 > --- a/drivers/pinctrl/pinctrl-ocelot.c > +++ b/drivers/pinctrl/pinctrl-ocelot.c > @@ -1308,7 +1308,7 @@ static int ocelot_gpiochip_register(struct platform= _device *pdev, > gc =3D &info->gpio_chip; > gc->ngpio =3D info->desc->npins; > gc->parent =3D &pdev->dev; > - gc->base =3D 0; > + gc->base =3D -1; I can't remember why but I'm pretty sure I did that on purpose but this indeed cause issues when the chip is external. I've asked Cl=E9ment to check, let's see what the result is ;) > gc->of_node =3D info->dev->of_node; > gc->label =3D "ocelot-gpio"; > = > -- = > 2.25.1 > = -- = Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel