From: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
To: Andrzej Pietrasiewicz <andrzej.p@collabora.com>
Cc: linux-media@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-staging@lists.linux.dev,
Benjamin Gaignard <benjamin.gaignard@collabora.com>,
Boris Brezillon <boris.brezillon@collabora.com>,
Fabio Estevam <festevam@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Heiko Stuebner <heiko@sntech.de>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Nicolas Dufresne <nicolas.dufresne@collabora.com>,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Philipp Zabel <p.zabel@pengutronix.de>,
Sascha Hauer <s.hauer@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
kernel@collabora.com
Subject: Re: [PATCH v8 11/12] media: hantro: Staticize a struct in postprocessor code
Date: Wed, 17 Nov 2021 08:01:28 -0300 [thread overview]
Message-ID: <YZThCK6+/jA+P/v8@eze-laptop> (raw)
In-Reply-To: <20211116143842.75896-12-andrzej.p@collabora.com>
On Tue, Nov 16, 2021 at 03:38:41PM +0100, Andrzej Pietrasiewicz wrote:
> The struct is not used outside this file, so it can be static.
>
> Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@collabora.com>
Reviewed-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
> ---
> drivers/staging/media/hantro/hantro_postproc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/hantro/hantro_postproc.c b/drivers/staging/media/hantro/hantro_postproc.c
> index 4549aec08feb..89de43021779 100644
> --- a/drivers/staging/media/hantro/hantro_postproc.c
> +++ b/drivers/staging/media/hantro/hantro_postproc.c
> @@ -33,7 +33,7 @@
> #define VPU_PP_OUT_RGB 0x0
> #define VPU_PP_OUT_YUYV 0x3
>
> -const struct hantro_postproc_regs hantro_g1_postproc_regs = {
> +static const struct hantro_postproc_regs hantro_g1_postproc_regs = {
> .pipeline_en = {G1_REG_PP_INTERRUPT, 1, 0x1},
> .max_burst = {G1_REG_PP_DEV_CONFIG, 0, 0x1f},
> .clk_gate = {G1_REG_PP_DEV_CONFIG, 1, 0x1},
> --
> 2.25.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-11-17 11:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-16 14:38 [PATCH v8 00/12] VP9 codec V4L2 control interface Andrzej Pietrasiewicz
2021-11-16 14:38 ` [PATCH v8 01/12] hantro: postproc: Fix motion vector space size Andrzej Pietrasiewicz
2021-11-16 14:38 ` [PATCH v8 02/12] hantro: postproc: Introduce struct hantro_postproc_ops Andrzej Pietrasiewicz
2021-11-16 14:38 ` [PATCH v8 03/12] hantro: Simplify postprocessor Andrzej Pietrasiewicz
2021-11-16 14:38 ` [PATCH v8 04/12] hantro: Add quirk for NV12/NV12_4L4 capture format Andrzej Pietrasiewicz
2021-11-16 14:38 ` [PATCH v8 05/12] media: uapi: Add VP9 stateless decoder controls Andrzej Pietrasiewicz
2021-11-16 14:38 ` [PATCH v8 06/12] media: Add VP9 v4l2 library Andrzej Pietrasiewicz
2021-11-16 14:38 ` [PATCH v8 07/12] media: rkvdec: Add the VP9 backend Andrzej Pietrasiewicz
2021-11-17 11:52 ` [PATCH v8.1 " Andrzej Pietrasiewicz
2021-11-16 14:38 ` [PATCH v8 08/12] media: hantro: Rename registers Andrzej Pietrasiewicz
2021-11-17 11:02 ` Ezequiel Garcia
2021-11-16 14:38 ` [PATCH v8 09/12] media: hantro: Prepare for other G2 codecs Andrzej Pietrasiewicz
2021-11-16 14:38 ` [PATCH v8 10/12] media: hantro: Support VP9 on the G2 core Andrzej Pietrasiewicz
2021-11-16 14:38 ` [PATCH v8 11/12] media: hantro: Staticize a struct in postprocessor code Andrzej Pietrasiewicz
2021-11-17 11:01 ` Ezequiel Garcia [this message]
2021-11-16 14:38 ` [PATCH v8 12/12] media: hantro: Support NV12 on the G2 core Andrzej Pietrasiewicz
2021-11-16 14:47 ` [PATCH v8 00/12] VP9 codec V4L2 control interface Ezequiel Garcia
2021-11-16 14:48 ` Andrzej Pietrasiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZThCK6+/jA+P/v8@eze-laptop \
--to=ezequiel@vanguardiasur.com.ar \
--cc=andrzej.p@collabora.com \
--cc=benjamin.gaignard@collabora.com \
--cc=boris.brezillon@collabora.com \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=heiko@sntech.de \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jernej.skrabec@gmail.com \
--cc=kernel@collabora.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=nicolas.dufresne@collabora.com \
--cc=p.zabel@pengutronix.de \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox