From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E484C433F5 for ; Wed, 17 Nov 2021 15:03:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D6F3B61B4C for ; Wed, 17 Nov 2021 15:03:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D6F3B61B4C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6hT0GGwQNJsq2YS6CBuuIJ3DmsFkK0qh6sFu9fCVNZk=; b=CxbWnPXFTOeaU2 k7IiVlWAJ4FLE3VVJTNPmirNaOwlGeDfDsUjEb6Eg+CuxU3LSDDTkiN19TtQPghD+B30oOZ2ia6gr Va2BQbqsPWE4UeLObIps62Vx7C1BEKCbrK5pVutnXs78D5iw3noUUX0FXU6M+D09BubU6jFz0aj8a Jr4r0mYVkJ+6yVdryaqrJC4IWSxwnu+oGByp7savBx7g1pMYOvZmESmm6/EWjQlnBib+eXBt3m1aP BuU8hI7mS3vxYrgYiqlhe+bDWl041a/m1EhcCkuYLFillelsHG44fN8OXBTSlt9qGphlg47rTd3Qm gYO69htxl+Q9s6dB0R4Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mnMQl-005Hy1-QY; Wed, 17 Nov 2021 15:01:00 +0000 Received: from mail-oi1-x230.google.com ([2607:f8b0:4864:20::230]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mnMP3-005HFV-Tp for linux-arm-kernel@lists.infradead.org; Wed, 17 Nov 2021 14:59:15 +0000 Received: by mail-oi1-x230.google.com with SMTP id t23so7006054oiw.3 for ; Wed, 17 Nov 2021 06:59:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=7vwEIGRd/k9q1/+y5hcDE349ZZtS7AT1p1s0Zcv7eNE=; b=dyMkyVuNdoMZvjI0ierM6RaC+RN6oZin+Sqkd6bM4mvd/cAUZGfbRBwTCXK9XUFmuN mXgtExUa30oDoPk+WTTAI1T5ZRYSd4uYAV9c1BwGZRHJRpCT2QgD7iUbSlREZtVlvQpu f9TGzhoiu6KJWaCx1V/SDwv+0onqKWgI0s4GDYG4CM8s0KQs8XsTvkgtTQS8i1wu0Oxg eeLY9uEKOL+rBGbFB+RpsGTLtaa/G3fnVpgbOmgbQREfHNDM/1cRc5Nc4InEoFfPPAcc EXVJO2rTtFu+xrwo8hIQ0lbV2JMwne2ZPX3GA40CtnmJ/VWSD5SoPNV24nZQ6b9HGQzI UTKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=7vwEIGRd/k9q1/+y5hcDE349ZZtS7AT1p1s0Zcv7eNE=; b=eM6Au/lrZ5nVegdL/EwU28j9EvwyTk4gny25iUDbmcCePj4ZbZaf2Ql7HF40kBdweI 8Jzp1LT1EQkE0KM6+/D+vK1mTuIWgBVOlEA+WTkf+j81nf+AqLKkOR/mJjeP8W+IKXCL 8T3bveP0Lb7YovXOFSIqy7OUGKVhnzQgu0izzXEdUaRLfChSv571p2+Q9nCqfng3FMmx AsqfuQYCRua5vL5eePMWDmEW/1Zmy9sc2VmzYs2uU9dRXLsnn4yNMGsy7E6WV2Zb1LLZ V4TYVIRSSdcMetWT599ZM4Anwd9WNdvI0ZYnGkIfVzN3wCAyW1m0OeT0VH+VwB3ZoVSc M4wg== X-Gm-Message-State: AOAM530yrTfdYKtuA4+38cGHCvJ2AZs7a/sQJ/bCzogHWBPMKWcybt/V l3QDo+o+QiQd0ihXP7ZYgrIhNQ== X-Google-Smtp-Source: ABdhPJxm262/4sVs9neZzycZF3skmMRjr0n4bKAnJHM153HG6gX0GlpzV3dRgWlWYAIctxlrkuPVhA== X-Received: by 2002:aca:b386:: with SMTP id c128mr179202oif.161.1637161152006; Wed, 17 Nov 2021 06:59:12 -0800 (PST) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id e21sm15160ote.72.2021.11.17.06.59.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Nov 2021 06:59:11 -0800 (PST) Date: Wed, 17 Nov 2021 08:59:07 -0600 From: Bjorn Andersson To: Mark-PK Tsai Cc: ohad@wizery.com, mathieu.poirier@linaro.org, matthias.bgg@gmail.com, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, yj.chiang@mediatek.com Subject: Re: [PATCH v2] remoteproc: use %pe format string to print return error code Message-ID: References: <20211102141535.28372-1-mark-pk.tsai@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211102141535.28372-1-mark-pk.tsai@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211117_065914_030304_77618516 X-CRM114-Status: GOOD ( 16.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue 02 Nov 09:15 CDT 2021, Mark-PK Tsai wrote: > Use %pe format string to print return error code which > make the error message easier to understand. > Reviewed-by: Bjorn Andersson > Signed-off-by: Mark-PK Tsai > --- > drivers/remoteproc/remoteproc_core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c > index 502b6604b757..2242da320368 100644 > --- a/drivers/remoteproc/remoteproc_core.c > +++ b/drivers/remoteproc/remoteproc_core.c > @@ -575,8 +575,8 @@ static int rproc_handle_vdev(struct rproc *rproc, void *ptr, > dma_get_mask(rproc->dev.parent)); > if (ret) { > dev_warn(dev, > - "Failed to set DMA mask %llx. Trying to continue... %x\n", > - dma_get_mask(rproc->dev.parent), ret); > + "Failed to set DMA mask %llx. Trying to continue... (%pe)\n", > + dma_get_mask(rproc->dev.parent), ERR_PTR(ret)); > } > > /* parse the vrings */ > -- > 2.18.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel