From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2620EC433EF for ; Fri, 19 Nov 2021 07:57:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D526861AA3 for ; Fri, 19 Nov 2021 07:57:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D526861AA3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tDqA5UxhlVnjPXZXMIfC/e7AywChlk2Ud+puI9MKdAo=; b=QABx6eyE70R9R2 fBWuFjPmNyonirxmslfDrnV1phNpa4J0ejcMr7RKdlgrr0B/bLXzXNEDVoioAFgizgFQ+mDDJ4nhp wfRHqjysYg6CFreAN2J2UsiscJk4HLOkvBhGOmcLb9QsYHR2sDhVVz6VgSQiWsE9ynfroMhVi1d66 DJR22QFKupSh+gk/MXYWJZToRMDjTkxup7bA+s5RC/e10Po37ethVDDRhOGB9AgFeyQyUthmZqM6Y HZ0fglK2uiNbI9BHWDsrv1kA7Lna4ZfE1q2PPM/mEeZHVSEly2W8WRrI9nCtx3JEBq3wt/Rcw+PUe abqGjB+npr6IRcXEysEg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mnykC-009fwA-G6; Fri, 19 Nov 2021 07:55:36 +0000 Received: from mail-ed1-f51.google.com ([209.85.208.51]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mnyk9-009fvH-2Z for linux-arm-kernel@lists.infradead.org; Fri, 19 Nov 2021 07:55:34 +0000 Received: by mail-ed1-f51.google.com with SMTP id x15so39122905edv.1 for ; Thu, 18 Nov 2021 23:55:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=J6zouXQGCHiuiXkAFB6eU4GAjZXCJ/oMOdOwBgVwDYw=; b=VWVeCJS3WdwimvlvAIYKas4pD5Unt+OaWeiwF8rqDflq3PL4vZVmHyKD3lzGefqRYN srFNbb0wiCz6YuXmgET+8mkqYd0fEM1pyZq+ectkxkkxyJGpaUDZKRrChQbz2Z/2pSjl wofPWgqDgu/1BFoN3at1gPqIoPej9RzJLNjjkuQS1ORDWDCwzXLT6KwCadxjBkJNhZIN 9Ah0EDCoWle5SQEfXcfn/ZgxJMiZMKJ58yl5reXNBjRgRTq+D7VYCmBoep8T2kRCAJqC Zu8YmnMj62raJjHNhn4cklFk2cmU33o630ahnuNxVT7xNF61LXbFK/WhvCEgQ8E9mxlp +NMg== X-Gm-Message-State: AOAM531V2V7XxYUHrEudb+lk/t/n2KyPbKzlcax9gk8/hUCY86RaET4t 8ohvdjJMNlLYjF2YbyCJ9P8= X-Google-Smtp-Source: ABdhPJyaLgIE5MXPw6z4W7QfxaymO23vtqDU8e14fPSgYaopP0LzVaVJQiXBrMUYeIDbh4SxOgFf5g== X-Received: by 2002:aa7:cf9a:: with SMTP id z26mr21601967edx.136.1637308530462; Thu, 18 Nov 2021 23:55:30 -0800 (PST) Received: from rocinante ([95.155.85.46]) by smtp.gmail.com with ESMTPSA id hv17sm881009ejc.66.2021.11.18.23.55.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Nov 2021 23:55:29 -0800 (PST) Date: Fri, 19 Nov 2021 08:55:28 +0100 From: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= To: "liuqi (BA)" Cc: Will Deacon , Mark Rutland , Bjorn Helgaas , PCI , linux-arm-kernel , Linux Kernel Mailing List , linuxarm@huawei.com, zhangshaokun@hisilicon.com Subject: Re: [PATCH v11 2/2] drivers/perf: hisi: Add driver for HiSilicon PCIe PMU Message-ID: References: <20211029093632.4350-1-liuqi115@huawei.com> <20211029093632.4350-3-liuqi115@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211118_235533_148271_CE0D746C X-CRM114-Status: GOOD ( 22.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Qi, Thank you for looking into things I've mentioned! [...] > > Would the above "bdf" be the PCI addressing schema? If so, then we could > > capitalise the acronym to keep it consistent with how it's often referred > > to in the PCI world. > > [...] > got it, will change it to Bdf to keep the consistent, thanks. Just to make sure - the "Bus, Device, Function" in the world of PCI usually uses the acronym of "BDF", all uppercase letters. > > [...] > > > +static int __init hisi_pcie_module_init(void) > > > +{ > > > + int ret; > > > + > > > + ret = cpuhp_setup_state_multi(CPUHP_AP_PERF_ARM_HISI_PCIE_PMU_ONLINE, > > > + "AP_PERF_ARM_HISI_PCIE_PMU_ONLINE", > > > + hisi_pcie_pmu_online_cpu, > > > + hisi_pcie_pmu_offline_cpu); > > > + if (ret) { > > > + pr_err("Failed to setup PCIe PMU hotplug, ret = %d.\n", ret); > > > + return ret; > > > + } > > > > The above error message could be made to be a little more aligned in terms > > of format with the other messages, thus it would be as follows: > > > > pr_err("Failed to setup PCIe PMU hotplug: %d.\n", ret); > > > > Interestingly, there would be then no need to add the final dot (period) at > > the end here, and that would be true everywhere else. > > > > thanks for your reminder , I'll fix that printout message to keep align. Thank you! Don't forget to drop the trailing dot after the error code (it makes it easier to read or even parse in a script, etc.). Again, thank you so much for working on this driver! An amazing work! Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel