Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Gaston Gonzalez <gascoar@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: linux-staging@lists.linux.dev, gregkh@linuxfoundation.org,
	nsaenz@kernel.org, stefan.wahren@i2se.com, arnd@arndb.de,
	ojaswin98@gmail.com, amarjargal16@gmail.com,
	linux-rpi-kernel@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	bcm-kernel-feedback-list@broadcom.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] staging: vchiq_core: remove superfluous static_assert statement
Date: Mon, 22 Nov 2021 12:00:31 -0300	[thread overview]
Message-ID: <YZuwj0mhn3qEgQbW@localhost.localdomain> (raw)
In-Reply-To: <20211122135031.GB6514@kadam>

On Mon, Nov 22, 2021 at 04:50:31PM +0300, Dan Carpenter wrote:
> On Mon, Nov 22, 2021 at 10:09:26AM -0300, Gaston Gonzalez wrote:
> > After removing the BITSET_T typedef in commit d8a364820e01 ("staging:
> > vchiq_core: get rid of typedef") the static_assert statement becomes superfluous
> > as now we are checking if the size of the u32 type is 4 bytes. Hence, just
> > remove the static_assert statement.
> > 
> > Suggested-by: Dan Carpenter <dan.carpenter@oracle.com>
> > Signed-off-by: Gaston Gonzalez <gascoar@gmail.com>
> > ---
> 
> You sent the first version after the merge window had just started.
> It's too early to be resending stuff.  Leave it for two weeks after the
> end of the merge window at least.
> 
> regards,
> dan carpenter
>

Ah, ok. I thought it was ok to resend after one week once the merge
window was closed.

Sorry for the noise.

Gaston

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

      reply	other threads:[~2021-11-22 15:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-22 13:09 [PATCH RESEND] staging: vchiq_core: remove superfluous static_assert statement Gaston Gonzalez
2021-11-22 13:50 ` Dan Carpenter
2021-11-22 15:00   ` Gaston Gonzalez [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YZuwj0mhn3qEgQbW@localhost.localdomain \
    --to=gascoar@gmail.com \
    --cc=amarjargal16@gmail.com \
    --cc=arnd@arndb.de \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=dan.carpenter@oracle.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=nsaenz@kernel.org \
    --cc=ojaswin98@gmail.com \
    --cc=stefan.wahren@i2se.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox