From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E7F9EC433F5 for ; Tue, 7 Dec 2021 21:21:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HrljiaRrgDiXC3KjIOY6/GJwl80djH33t7PuRD7pkdA=; b=kKb6b2KUsZQu7U hMstoCOzAiIIp7gpUv6WiDl04ACC8+v/v5ROUszKzaR0/gNASwjAZ/32ZrHUkJwUwA6p8s1X893I2 rkMUuzFeVUnhMkzjB/pfDA951geqB/ijLAUtGJw6QThk2pfy96iKvVOUkSTMuwBMDJRJUYXa94+PG QSxinGeTxJ5K+9PbKDizdt9K7Urz2+9qSRcEoDXdgc9x/RILWOYQIvlvWe2GzTWuEn6J9T7tVwIns JaEzJydAQLHnCXzNexUt+pykkCgXfadGmNQjd4yv4nyaKUH6+7zvD2UzLEv6m1sqsu15fxYNcKUwE 7asmWMqAOb0obhpElLvA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1muhsZ-00AAku-7K; Tue, 07 Dec 2021 21:20:03 +0000 Received: from mail-oo1-f52.google.com ([209.85.161.52]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1muhsV-00AAjX-6c for linux-arm-kernel@lists.infradead.org; Tue, 07 Dec 2021 21:20:00 +0000 Received: by mail-oo1-f52.google.com with SMTP id v30-20020a4a315e000000b002c52d555875so139003oog.12 for ; Tue, 07 Dec 2021 13:19:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=TDybkYmRgN7ASFL9lU803KLgt8MDRIp7lKanWAFVy8w=; b=VKBCd+Sq8O74S4XJIzRrTi+jH7UPhLMjKAy1a7hbGUPfldzgLtfDRhjjkoYT342ezu a0OzdCFb4oQlzx8zkta+sYybF30nCVwIDVfEw7IG6DhnxsHloBORj0O02wbIqht3oOBe SsNUCcod71HvhSq0JAxoRGDZcb6vJS+Rs7zK5tA8265OpGCflb2Yje39xeuc83hZOGqb TVtr8Fchm8VdHQaD3LqjER4eYEcmGkOyc/Ml8jsCkeEzI0erS17qtJDGbCBOahT7aFwH jxcH6rAqBUBbrREoBukIdDMTlvHiA5t0UZTh0QYj5lhzuB7O9v6Hrhd/fG5YacOx6mwh DpPw== X-Gm-Message-State: AOAM532uRgF20d0SQ1GIDUa5s/+6YREku98g2VAGgtqQjtMMUhOsU1yb wBj2RHrgtMCPI+iqeBN4Hw== X-Google-Smtp-Source: ABdhPJzQx6ifBIeo7YNw/4J7ZMf9KeE80PBI87o4MLSSxGDKBHAC15DEydOg8wZjHXu+Y1USi6AwDQ== X-Received: by 2002:a4a:b00e:: with SMTP id f14mr27855125oon.10.1638911997778; Tue, 07 Dec 2021 13:19:57 -0800 (PST) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id o2sm214597oik.11.2021.12.07.13.19.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Dec 2021 13:19:56 -0800 (PST) Received: (nullmailer pid 850716 invoked by uid 1000); Tue, 07 Dec 2021 21:19:55 -0000 Date: Tue, 7 Dec 2021 15:19:55 -0600 From: Rob Herring To: Joel Stanley Cc: Billy Tsai , Guenter Roeck , Jean Delvare , Andrew Jeffery , Lee Jones , Thierry Reding , Uwe Kleine-Konig , Philipp Zabel , linux-hwmon@vger.kernel.org, devicetree , Linux ARM , linux-aspeed , Linux Kernel Mailing List , linux-pwm@vger.kernel.org, BMC-SW Subject: Re: [v14 0/2] Support pwm driver for aspeed ast26xx Message-ID: References: <20211130055933.32708-1-billy_tsai@aspeedtech.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211207_131959_265398_B7B5F27F X-CRM114-Status: GOOD ( 21.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Dec 07, 2021 at 06:45:47AM +0000, Joel Stanley wrote: > Hi Billy, > > On Tue, 30 Nov 2021 at 05:58, Billy Tsai wrote: > > > > The legacy driver of aspeed pwm is binding with tach controller and it > > doesn't follow the pwm framworks usage. In addition, the pwm register > > usage of the 6th generation of ast26xx has drastic change. So these > > patch serials add the new aspeed pwm driver to fix up the problem above. > > Sorry for not taking a look earlier. Well done on making it this far. > > There's a few things that need to be addressed before merging this. > > Firstly, the bindings need fixing up. I think these should be the one > file. The device tree bindings are supposed to describe the hardware, > and it doesn't make sense to separate them out just because we plan on > using two subsystems to implement the functionality. > > Rob, please chime in if you would prefer something different. I prefer to see a common binding for fans which I said multiple times on this series. As the same thing keeps getting posted, I've stopped looking at this one. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel