From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F3AFCC433EF for ; Tue, 7 Dec 2021 07:07:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ik7g935jk03OKGjJJu06k5yfsMav2RAVcvY29D6Mehc=; b=tU7XNPKd2W8xG2 vyPG/dhim95GVady6lg6I/0J9+gtA+N0yT5je4JID3tDM31+DwdOoEmdLGYe6kt3eNGjyO7SCvKeZ z2+xN8YLuB2/LEKB+ix5aIZOdln7Yj/Yz39ZLVO7jcXfmwSZSY6H1ryqBMKn9Dl7kanTzlWW4+PBU tfhIq3LqNeN5DSynQ8J+t8z/hbrOQxT6G29/UgusNtS6jzcKWLZnhignXCDhnmROcPfK9l2YjPb40 DeI5qE1gfmAd3G9h43ArtFF307yYvPfweLyFYeTOYoqz7iiA6ko77IJ9KABIbOyf0GXIrBjMsuuq9 +v+8xxnQaHP03o87xWSg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1muUYH-007AZK-B0; Tue, 07 Dec 2021 07:06:13 +0000 Received: from mail-pj1-x102c.google.com ([2607:f8b0:4864:20::102c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1muUYE-007AYO-3Z for linux-arm-kernel@lists.infradead.org; Tue, 07 Dec 2021 07:06:11 +0000 Received: by mail-pj1-x102c.google.com with SMTP id k6-20020a17090a7f0600b001ad9d73b20bso1866664pjl.3 for ; Mon, 06 Dec 2021 23:06:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=+WUTgx0L85lxi2fdDbmVWfQm0Fyz5KOBASfXLKJ1914=; b=Qnj+3P7zN6U9mTLOmd2WzaOtEi5SlrvLkoST+sHw/BBxdY7+RyH2KjJc7goBB4sj8Z 8rTMBm361UDpSVbMHKV8i0W8Ynk0nTI/uqs31ciJCCQhxSePwoQUz6AwTWCiD4XfoHkB 1v9MWFQRmX8bNu7qZTFCWqyEOEAS11Lv06jJRXo5MQM8P8clC2qBmBuPgjbLYZDx+1VE S0t/BrDW2z1HaJq6FJNI9qKIPWOEfvbuS4W9YzVHf/fC3ttPKZysS6zVhxzYYgjDjgS4 j4/DElGse8K0ZUHBR9WVJ1RZ4j6oIVHwqMp/5Urggfm8sYe2/kWBcpGI3gCzePAiAWa1 h3Cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=+WUTgx0L85lxi2fdDbmVWfQm0Fyz5KOBASfXLKJ1914=; b=i2zLLPCbPaB1xiRo9q1uJPATpBtyqhY/3/NHqtCxNu1tdoMloCYOCB13OQOnwnwPCl ry+N5sBftwSlpdbzPxCDwwUAT1gU1e/WJbyrz9oSuNyKjv1wGULhdCKMV4rv4IckAc6U u9po5VGzifT6FWpNWSF7e+ttE9mHm0K+ETbw6DTu/6GSVDU/YwGWL33Thg7Bh+w96OYi xdXiMH1U3z4RvKHu1Y8w9nuiiHCDVXtmhlJwKChFq4F2ULAl+yy6do8/rDWz/hodfrwh 6HNaZhbuVrD4VZBOO+1pp3ZaUiTbNQb6fgyQhYqBQh7AO+qD7brE86u2cPzfpBAl4VkO SDlg== X-Gm-Message-State: AOAM531W0QffokKngqoCsN6Enc3D1hK77WEiqUj2COnwVTgrixZqqkVm AFujEmKT2u65Pdr2NqYj+TCAylflBAA= X-Google-Smtp-Source: ABdhPJwKMduaisPl4sUh7vNL0hUbGfNAGCj2DuKTt35IUcb8gAfCW29iwccLWh7N7iyAWnKiG6yCjg== X-Received: by 2002:a17:902:9692:b0:143:d9ad:d151 with SMTP id n18-20020a170902969200b00143d9add151mr48695859plp.40.1638860768318; Mon, 06 Dec 2021 23:06:08 -0800 (PST) Received: from google.com ([2620:15c:202:201:25b0:d110:b844:ea00]) by smtp.gmail.com with ESMTPSA id m16sm7551996pfk.186.2021.12.06.23.06.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Dec 2021 23:06:07 -0800 (PST) Date: Mon, 6 Dec 2021 23:06:04 -0800 From: Dmitry Torokhov To: Alistair Francis Cc: Andreas Kemnade , Alistair Francis , Linux Kernel Mailing List , devicetree , linux-input , linux-arm-kernel , Rob Herring , Linus Walleij , Henrik Rydberg , =?iso-8859-1?Q?Myl=E8ne?= Josserand , Maxime Ripard Subject: Re: [PATCH v3 1/4] Input: Add driver for Cypress Generation 5 touchscreen Message-ID: References: <20211202122021.43124-1-alistair@alistair23.me> <20211202122021.43124-2-alistair@alistair23.me> <20211204233233.6c55875c@aktux> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211206_230610_178529_DD1CAE3C X-CRM114-Status: GOOD ( 27.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Dec 06, 2021 at 08:46:50PM +1000, Alistair Francis wrote: > On Sun, Dec 5, 2021 at 8:32 AM Andreas Kemnade wro= te: > > > > Hi, > > > > > > On Thu, 2 Dec 2021 22:20:18 +1000 > > Alistair Francis wrote: > > > > > From: Myl=E8ne Josserand > > > > > > This is the basic driver for the Cypress TrueTouch Gen5 touchscreen > > > controllers. This driver supports only the I2C bus but it uses regmap > > > so SPI support could be added later. > > > The touchscreen can retrieve some defined zone that are handled as > > > buttons (according to the hardware). That is why it handles > > > button and multitouch events. > > > > > > Reviewed-by: Maxime Ripard > > > Signed-off-by: Myl=E8ne Josserand > > > Message-Id: <20180703094309.18514-2-mylene.josserand@bootlin.com> > > > Signed-off-by: Alistair Francis > > > > I finally got it working. The order of initialisation is important. > > Params are copied on input_mt_init_slots() from ABS_MT* to ABS_*, so you > > have to set params first. > > > > Here is the patch i need on top of this one to make it actually work > > with X (evdev and libinput is tested): > > > > diff --git a/drivers/input/touchscreen/cyttsp5.c b/drivers/input/touchs= creen/cyttsp5.c > > index b5d96eb71e46..3894ec85a732 100644 > > --- a/drivers/input/touchscreen/cyttsp5.c > > +++ b/drivers/input/touchscreen/cyttsp5.c > > @@ -415,19 +415,12 @@ static int cyttsp5_setup_input_device(struct devi= ce *dev) > > int max_x_tmp, max_y_tmp; > > int error; > > > > - __set_bit(EV_REL, ts->input->evbit); > = > Does it work with this still included? I need this for my userspace progr= am. You need to fix your program, the kernel should not be declaring capabilities that the device does not support. Thanks. -- = Dmitry _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel