From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CF265C433EF for ; Tue, 7 Dec 2021 15:13:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fv+FlUh2tJu95fkaUjLEm3q8nhXjTkLu1bXLpOZh+uA=; b=L/kgopdPp8k8HW 5wqo1N5mTRVWteGD1lVZLweA/8PGli97q4176PYiOdjSdgGyy35eq2h+/KvGxIAYN9WeXVqtbwYBT mAt2Wlp5sR3yUT9J4Ntoetf5/yXfB4aYIhlD0415hZ2A+63ONFE1fGiXk0k/KTKOrvb7Q+SzsgYQq jVjBKC1mk0EWIo3CnSkHBP8IiAlLqRObnwyrSaWrxeNybhjpM5PJMH7PKJuea9zwev6PqzZzw8Nlv Q5lr73qCNSO4TGIGs8mkf8o57MM/OLwyi0O2prgrLTbSgBzJewrWVbJoTGRYUvfQsXZBmZDpqAulB JPmq1CrXc+bFKtY3MNdQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1muc8P-0097tC-RA; Tue, 07 Dec 2021 15:12:02 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mubn6-00910B-Le for linux-arm-kernel@bombadil.infradead.org; Tue, 07 Dec 2021 14:50:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=OuBcwk+tQnML7Y3AtT73mMm7zXKJD8k/a0Deivdv7wI=; b=lH23EsgX9AwpK21dlrCIO+BPIb rX1FUMgX71/Im9r5TufxU3jXSv5MqM5JN2WFPPlbVc7ZvzF8plUsJKBKJSPVckKTOZiEybY5WMrd6 ZDPGT5pc6zo4PAuNih6dlXlRCLo3F+TTXmHcJ3tfXN9EeN4NY0WLtpvaf4MpeghlMQov2hORfwsbn vnfsxtZ83HlZzLHhwuYGFl3Ia58xDGZrv8M49P9DwjI7SuCU//VyxKThKGZlNr9ur+iC1AT/xZQxD r/n1o6SjRzk8nW9XXN6F1s/Wf2O6DVOu6hFC0Rd1oLh5zL9v/oHid1zJw/5PSks9mXj0FPw0DYFtd IBaEj+fA==; Received: from [179.97.37.151] (helo=quaco.ghostprotocols.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1mubn4-007Roi-Bk for linux-arm-kernel@lists.infradead.org; Tue, 07 Dec 2021 14:49:59 +0000 Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id EC418406C1; Tue, 7 Dec 2021 11:49:56 -0300 (-03) Date: Tue, 7 Dec 2021 11:49:56 -0300 From: Arnaldo Carvalho de Melo To: Andrew Kilroy Cc: John Garry , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Will Deacon , Mathieu Poirier , Leo Yan , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/3] perf vendor events: For the Neoverse N2 Message-ID: References: <20211203123525.31127-1-andrew.kilroy@arm.com> <2e1a7a96-4ec6-e1f2-5bd4-133480391053@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Em Tue, Dec 07, 2021 at 12:13:16PM +0000, Andrew Kilroy escreveu: > = > = > On 07/12/2021 09:57, John Garry wrote: > > On 03/12/2021 12:35, Andrew Kilroy wrote: > > > Updates the common and microarch json file to add counters > > > available in the Neoverse N2 chip, but should also apply to other Arm= V8 > > > and ArmV9 cpus.=A0 Specified in ArmV8 architecture reference manual > > > = > > > =A0=A0 https://developer.arm.com/documentation/ddi0487/gb/?lang=3Den > > > = > > > Some of the counters added to armv8-common-and-microarch.json are > > > specified in the ArmV9 architecture reference manual supplement > > > (issue A.a): > > > = > > > =A0=A0 https://developer.arm.com/documentation/ddi0608/aa > > > = > > > The additional ArmV9 counters are > > > = > > > =A0=A0 TRB_WRAP > > > =A0=A0 TRCEXTOUT0 > > > =A0=A0 TRCEXTOUT1 > > > =A0=A0 TRCEXTOUT2 > > > =A0=A0 TRCEXTOUT3 > > > =A0=A0 CTI_TRIGOUT4 > > > =A0=A0 CTI_TRIGOUT5 > > > =A0=A0 CTI_TRIGOUT6 > > > =A0=A0 CTI_TRIGOUT7 > > > = > > > This patch also adds files in pmu-events/arch/arm64/arm/neoverse-n2 f= or > > > perf list to output the counter names in categories. > > > = > > > A subsequent patch renames armv8-common-and-microarch.json and > > > armv8-recommended.json to reflect that counters for armv9 are being > > > added. > > = > > This commentary should be in a cover letter. Please do that. > > = > > And did you consider just adding a armv9-common-and-microarch.json and > > armv9-recommended.json instead of adding to and renaming the v8 version? > > I know that it creates scattered definitions, but we already have that = in > > dividing the common and the recommended JSONs. > > = > = > I considered it, but I wasn't sure what was preferable. I thought I'd get > some feedback. Do you consider the separation important? Any particular > reason? Applied the second patch, waiting for a conclusion to this discussion to pick the other two patches. - Arnaldo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel