From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BE5C0C433F5 for ; Tue, 7 Dec 2021 13:35:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mru2vhxy7j/5REYqm5vf9ou/29oroWWifvR0uoQhEwQ=; b=GdXZmhzCBGdjBv YvtwZV5MAs8QZYxC3VedWaTe3JfQKwhpOTTl2GC1YMJ5XyLdzrBU5So5ZUEGN82n+yA7seao4dH26 5TF6Tp3cU4hCBe2gBuu+03i3pLdoveosLCh/OOuUv8miMKidTx4UDIYkNzauguAMd/QpZ6ROrdVGB XfhDHKrNV4LXpE/ZebhCuavxbtLYorXidYsmq1csiE/jmQjzDFew9rj22/mkMCuBAeAjkJkmpw1tl bm9Pldq4aVTJG/8/aoK1RbzFw7QGZDA3DpFL8E+hz2KqFm6F6AekiH6fGaJZw4rsfAFDRuVT1ptKN TrnelFSDWCCtka5+x90Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1muabZ-008iVh-Sa; Tue, 07 Dec 2021 13:34:01 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1muabW-008iTW-3w for linux-arm-kernel@lists.infradead.org; Tue, 07 Dec 2021 13:33:59 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3100511FB; Tue, 7 Dec 2021 05:33:55 -0800 (PST) Received: from FVFF77S0Q05N (unknown [10.57.67.24]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DF6583F5A1; Tue, 7 Dec 2021 05:33:52 -0800 (PST) Date: Tue, 7 Dec 2021 13:33:42 +0000 From: Mark Rutland To: Josh Poimboeuf Cc: linux-kernel@vger.kernel.org, Borislav Petkov , Jiri Slaby , Peter Zijlstra , ardb@kernel.org, broonie@kernel.org, catalin.marinas@arm.com, dave.hansen@linux.intel.com, linux-arm-kernel@lists.infradead.org, maz@kernel.org, mingo@redhat.com, tabba@google.com, tglx@linutronix.de, will@kernel.org Subject: Re: [RFC PATCH 0/6] linkage: better symbol aliasing Message-ID: References: <20211206124715.4101571-1-mark.rutland@arm.com> <20211207052304.pb76ofjymf7o2yyb@treble> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211207052304.pb76ofjymf7o2yyb@treble> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211207_053358_257379_404CE9AD X-CRM114-Status: GOOD ( 16.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Dec 06, 2021 at 09:23:04PM -0800, Josh Poimboeuf wrote: > On Mon, Dec 06, 2021 at 12:47:09PM +0000, Mark Rutland wrote: > > This avoids repetition and hopefully make it easier to ensure > > consistency (e.g. so each function has a single canonical name and > > associated metadata). > > > > I'm sending this as an RFC since I want to check: > > > > a) People are happy with the idea in principle. > > > > b) People are happy with the implementation within . > > > > ... and I haven't yet converted the headers under tools/, which is > > largely a copy+paste job. > > Looks like a definite improvement to me. > > The only suggestion I'd have would be to fix a minor naming > inconsistency: change "SYM_FUNC_LOCAL_ALIAS" to "SYM_FUNC_ALIAS_LOCAL" > to match the other "_" macros. Sure; I was following the example set by `SYM_FUNC_START_LOCAL_ALIAS`, but I agree that placing LOCAL on the end looks more consistent overall once that's removed. For V2 I'll make that `SYM_FUNC_ALIAS_LOCAL`. Thanks, Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel