From: Tzung-Bi Shih <tzungbi@google.com>
To: "allen-kh.cheng" <allen-kh.cheng@mediatek.com>
Cc: Jassi Brar <jassisinghbrar@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
devicetree@vger.kernel.org,
Linux-ALSA <alsa-devel@alsa-project.org>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Liam Girdwood <lgirdwood@gmail.com>,
cujomalainey@google.com, linux-kernel@vger.kernel.org,
Takashi Iwai <tiwai@suse.com>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Project_Global_Chrome_Upstream_Group@mediatek.com,
Mark Brown <broonie@kernel.org>,
linux-mediatek@lists.infradead.org,
Daniel Baluta <daniel.baluta@nxp.com>,
linux-arm-kernel@lists.infradead.org,
sound-open-firmware@alsa-project.org
Subject: Re: [PATCH v4 2/3] firmware: mediatek: add adsp ipc protocol interface
Date: Fri, 26 Nov 2021 12:43:04 +0800 [thread overview]
Message-ID: <YaBl2PMPHnOMGKY+@google.com> (raw)
In-Reply-To: <20211125122925.1303-3-allen-kh.cheng@mediatek.com>
On Thu, Nov 25, 2021 at 08:29:24PM +0800, allen-kh.cheng wrote:
> diff --git a/drivers/firmware/mediatek/mtk-adsp-ipc.c b/drivers/firmware/mediatek/mtk-adsp-ipc.c
[...]
> +static void adsp_ipc_recv(struct mbox_client *c, void *msg)
> +{
> + struct mtk_adsp_chan *chan = container_of(c, struct mtk_adsp_chan, cl);
> +
> + if (chan->idx == MTK_ADSP_MBOX_REPLY)
> + chan->ipc->ops->handle_reply(chan->ipc);
> + else
> + chan->ipc->ops->handle_request(chan->ipc);
Using switch ... case ... makes the intention more clear.
> +static int mtk_adsp_ipc_probe(struct platform_device *pdev)
> +{
[...]
> + for (i = 0; i < MTK_ADSP_MBOX_NUM; i++) {
> + chan_name = kasprintf(GFP_KERNEL, "mbox%d", i);
> + if (!chan_name)
> + return -ENOMEM;
It needs to go error handling path.
> +static int mtk_adsp_remove(struct platform_device *pdev)
> +{
> + struct mtk_adsp_chan *dsp_chan;
> + struct mtk_adsp_ipc *dsp_ipc;
> + int i;
> +
> + dsp_ipc = dev_get_drvdata(&pdev->dev);
To be concise, I would prefer dev_get_drvdata() inline to the line where the variable is declared.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-11-26 4:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-25 12:29 [PATCH v4 0/3] This patches provide ADSP IPC support for MT8195 allen-kh.cheng
2021-11-25 12:29 ` [PATCH v4 1/3] dt-bindings: mediatek: add adsp-mbox document allen-kh.cheng
2021-11-25 12:29 ` [PATCH v4 2/3] firmware: mediatek: add adsp ipc protocol interface allen-kh.cheng
2021-11-26 4:43 ` Tzung-Bi Shih [this message]
2021-11-25 12:29 ` [PATCH v4 3/3] mailbox: mediatek: add support for adsp mailbox controller allen-kh.cheng
2021-11-26 4:43 ` Tzung-Bi Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YaBl2PMPHnOMGKY+@google.com \
--to=tzungbi@google.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=allen-kh.cheng@mediatek.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cujomalainey@google.com \
--cc=daniel.baluta@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=sound-open-firmware@alsa-project.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).