From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 37F7FC433FE for ; Fri, 26 Nov 2021 04:45:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HPz+AX6GdcMXTk0ZyIlpuL6bIdKIcQCwoUNz16AsFcA=; b=CnIk8rJ95iqy/p kxcdqy2q+QD0SuM4qAMr3M0QZzmdVTVfdJXljB0NG8mbANfP8SMBUt6NOxZiPh9so6Z4CWieGGYcD qgWWArOlKioBNwrI3g+dhepxAjsmrTOxUvmif28VO+w13hLYf0eQo61yYUyIJq1q0gICGve5Z9mex rP4tIb1HTYQPtu/DksHHCn+j3/SHlO90Gbwfc0xIhdNo0nkZ8dcy4CuGZri7UxnHToG8xvEgGF9BK kNOus5Vja175kaObGSEiz+0Iz0EGXeDdrx8LxI4Sq2pKgTtbap/oQLJl1KhUIUESBa7rct5LTu37v oBpNqgAs4vCeZT0qKZnQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mqT5D-009B1a-Rj; Fri, 26 Nov 2021 04:43:36 +0000 Received: from mail-pg1-x531.google.com ([2607:f8b0:4864:20::531]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mqT57-009Azp-3C for linux-arm-kernel@lists.infradead.org; Fri, 26 Nov 2021 04:43:31 +0000 Received: by mail-pg1-x531.google.com with SMTP id 71so7057292pgb.4 for ; Thu, 25 Nov 2021 20:43:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=gwJIiwnisD6cF408GW4bOCdNiOevm+kN2DCfktfQz/4=; b=p/HPnND/JDqjAz5osN2fiqxWxjwlxeukWlCnWFYdia3ksPcLdj2T2/w7EYHHk2wHzh 8NoOKsyeh7nIRO3jA2Qp5+Zzr44CZP9J0vSuGvhzzd5Ul9T7StHo8IKBzGd2fG7GtWDY nTuYDnPwWGPJ6wmjXG3VlLZeKT3MdPKSc62rgr6+X422bqTD4m2MyX/LeNEwCfWWPAmJ WL1g3/QQ9L7Sk4aUC+UtrkapDFWHLz0QFTssZtHaZhFkEONtoJXKH8XKz0xoFpLLMfX9 T9eYriy9fff/4MdXaIi3AukGZ6kvEwLf0KIs6V+L97ucwyXzlqO5xkmijlGi/tylQq5u qsYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=gwJIiwnisD6cF408GW4bOCdNiOevm+kN2DCfktfQz/4=; b=1ZP8cnma2qYXH2S4pt3p9JJsO71kV2OOYmNdD68WAfgR+yJ85eAeEcSywGDpaNIe6i lh0D+Vht41JfnVCfSZiObddBQLXn9F3i4a/AfeT/uuftUl/F1M+T6t62djtRuLA3FPZ4 SrufmvD9aDa9q1Ub6SbscR5oRfKS/zjK5WOf0KM3GwMWByJxq0nMDSkJ78bsiZnzBvMu NEZYXQ47rZooTfTEu69T+eVdYquPXSj076hlOn/x5FfXeg5xB0usWXKo95i4W1hARP4I XP+BbP2leIQpIYUnbVa3mLXOQUEk28NzzrPWav9EUJFuASo2WMHexgCUQTO6rKzMi2Kk SC7w== X-Gm-Message-State: AOAM532HEd1iCiY6Pyxp+ycg1mgA/0RxYHGc5oAhKzKsneRu36jbzxS2 HIM3l888RulNL0qIrnmEQdPu4w== X-Google-Smtp-Source: ABdhPJx0FjXR51YfULBYoNlN6azVm4pmsK/QdHHWCakrLIU0+ikdrQc99GBXkyRgdyNDpZyG+Rly5Q== X-Received: by 2002:a63:150c:: with SMTP id v12mr19528275pgl.442.1637901808160; Thu, 25 Nov 2021 20:43:28 -0800 (PST) Received: from google.com ([2401:fa00:1:10:5eda:d984:1426:91ca]) by smtp.gmail.com with ESMTPSA id g9sm5600382pfj.160.2021.11.25.20.43.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Nov 2021 20:43:27 -0800 (PST) Date: Fri, 26 Nov 2021 12:43:23 +0800 From: Tzung-Bi Shih To: "allen-kh.cheng" Cc: Jassi Brar , Rob Herring , Matthias Brugger , Linux-ALSA , cujomalainey@google.com, Pierre-Louis Bossart , Liam Girdwood , Ranjani Sridharan , Kai Vehmanen , Daniel Baluta , Mark Brown , Jaroslav Kysela , Takashi Iwai , Project_Global_Chrome_Upstream_Group@mediatek.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, sound-open-firmware@alsa-project.org Subject: Re: [PATCH v4 3/3] mailbox: mediatek: add support for adsp mailbox controller Message-ID: References: <20211125122925.1303-1-allen-kh.cheng@mediatek.com> <20211125122925.1303-4-allen-kh.cheng@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211125122925.1303-4-allen-kh.cheng@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211125_204329_155149_A61E64CF X-CRM114-Status: GOOD ( 13.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 25, 2021 at 08:29:25PM +0800, allen-kh.cheng wrote: > diff --git a/drivers/mailbox/mtk-adsp-mailbox.c b/drivers/mailbox/mtk-adsp-mailbox.c [...] > +static bool mtk_adsp_mbox_last_tx_done(struct mbox_chan *chan) > +{ > + struct adsp_mbox_ch_info *ch_info = chan->con_priv; > + void __iomem *reg = ch_info->va_reg; > + > + return (readl(reg + MTK_ADSP_MBOX_IN_CMD) == 0) ? true : false; To be concise, readl(reg + MTK_ADSP_MBOX_IN_CMD) == 0. > +static int mtk_adsp_mbox_probe(struct platform_device *pdev) > +{ [...] > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + if (!res) { > + dev_err(dev, "no adsp mbox register resource\n"); > + return -ENXIO; > + } > + > + priv->va_mboxreg = devm_platform_ioremap_resource(pdev, 0); > + if (IS_ERR(priv->va_mboxreg)) > + return PTR_ERR(priv->va_mboxreg); If using devm_platform_ioremap_resource(), it doesn't need to call platform_get_resource(). res is unused. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel