From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 953E6C433EF for ; Fri, 26 Nov 2021 07:33:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wZgS7PWO8auJIEduecXYk2MHbfak9YPB+6Au1mrYqY4=; b=en/2uJb5i6cl4g aZZnW4mL5g4WFLo4tUlqBQfotmBLR/6O1zWT84nt5FT2Qh4QL1kL94zrgvq8BsQb91efj0NqUhE0Z EU9XEpzeTyOPItpQa7RzpSk1X7Kbha9TeiTVzKUTd+b7gL4BpT9zPqBEhtwMBgfwU2rron9/a0o9/ 8xzykZL02Y9dNlUtbYpm2owZW8zup6Vr9q0T9iMjFZkZwUzM4SYB6IntBKvqu+ksKb03vs8hYRDJU VXMUFY+iAJoZU+WdtQhdcR0QmOMqqnf6f+yoO60+ONcKDSaoZn9vOz/Z2hBBFlena7xyBI8MSP3FK M9a76A5bWAjr/in5E3BA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mqVie-009RaD-KT; Fri, 26 Nov 2021 07:32:28 +0000 Received: from mail-pf1-x433.google.com ([2607:f8b0:4864:20::433]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mqViZ-009RYl-5F for linux-arm-kernel@lists.infradead.org; Fri, 26 Nov 2021 07:32:24 +0000 Received: by mail-pf1-x433.google.com with SMTP id p13so413744pfw.2 for ; Thu, 25 Nov 2021 23:32:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=/AAtVNxSEEMIS2MWinkvg2Tqw1EN5wSqX+XDPy/nWgI=; b=rUX7EPkOpCeOT0XDzv3zPUO65mVufrZATtBDv60kEPRIqIXnd367uOnp27jiHhW1RH pfZDsfZurY3opAdcGf9KbD0CAfhLVt2lc23p8w5m5g7ZsI1vPM3dDlMayAl8unNLuaAi G7XpZttHEAyra0B8n1oEx1fJSRyN5ROr1twSvleukoCpfjG3iT1ywnNB2G438p+WUIys BpRXFIC11cFbUlGHe9PDWmgBInA1QAq8cAUe8RW5pHox17z+ePwRAIRe0iXrndMiPpku 1llMHJ4ZOUODS2L0ni5PspcTSM8HJ1XdmckmEqkByum9Rjj5mNFqQ6aAS4S/l9AgDrq8 E8WQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=/AAtVNxSEEMIS2MWinkvg2Tqw1EN5wSqX+XDPy/nWgI=; b=TFq1A4nkRNTqgnP00YGFSh335lzX1S0VTwPW0xrjiqnjh+8w02HpH7zenuW2rYFFy2 Ex+52BZX8zC2ZuSVfA+94Lhw1sgjODZ78HNnxYnmKpU/SpHnjhPAmjDktf8PnPIVCrDQ fSxAz6T/ci//0DlTRmwWF7/ODJvhovCAaMF42oxDCn8TGReB6hqZ4NWk9Gv7lixAkpdI lSKXG6eBzuC3nv3i0slERvlac7KdO+pCKmR5Sd7AoNBN8ADx/Q2ajV79n7eZ8twYxZn1 wksAaKQ4iLdy68tlK1FlDG9J6KFi+MfYi/qf8wBvrlvK5tXTr6EEASjGFXUjlza0EuXi ArVw== X-Gm-Message-State: AOAM531sNCBrTJTv5Cz6nyiBmjPp332ugkWgT4Sr29gXoxDplgt/gAgm MJut5B4EXIqG8c7ikA6Pi6GEcg== X-Google-Smtp-Source: ABdhPJxBCLapsVbR8S32cbgSLGdf670vLzwnMC/H4p+iIY7hAahthtNMoj8b3XEDxeZJspFRP89tZA== X-Received: by 2002:a65:4b87:: with SMTP id t7mr19646091pgq.115.1637911941740; Thu, 25 Nov 2021 23:32:21 -0800 (PST) Received: from google.com ([2401:fa00:1:10:5eda:d984:1426:91ca]) by smtp.gmail.com with ESMTPSA id d12sm4112656pgf.19.2021.11.25.23.32.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Nov 2021 23:32:21 -0800 (PST) Date: Fri, 26 Nov 2021 15:32:17 +0800 From: Tzung-Bi Shih To: "allen-kh.cheng" Cc: Mark Brown , Rob Herring , Matthias Brugger , Jassi Brar , Linux-ALSA , cujomalainey@google.com, Pierre-Louis Bossart , Liam Girdwood , Ranjani Sridharan , Kai Vehmanen , Daniel Baluta , Jaroslav Kysela , Takashi Iwai , Project_Global_Chrome_Upstream_Group@mediatek.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, sound-open-firmware@alsa-project.org Subject: Re: [PATCH v5 3/3] mailbox: mediatek: add support for adsp mailbox controller Message-ID: References: <20211126071432.21990-1-allen-kh.cheng@mediatek.com> <20211126071432.21990-4-allen-kh.cheng@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211126071432.21990-4-allen-kh.cheng@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211125_233223_241172_057B7F7E X-CRM114-Status: GOOD ( 11.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Nov 26, 2021 at 03:14:32PM +0800, allen-kh.cheng wrote: > diff --git a/drivers/mailbox/mtk-adsp-mailbox.c b/drivers/mailbox/mtk-adsp-mailbox.c [...] > +static bool mtk_adsp_mbox_last_tx_done(struct mbox_chan *chan) > +{ > + struct adsp_mbox_ch_info *ch_info = chan->con_priv; > + void __iomem *reg = ch_info->va_reg; > + > + return readl(reg + MTK_ADSP_MBOX_IN_CMD) == 0 ? true : false; The expression "readl(...) == 0" should be already a boolean. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel