From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CB98CC433EF for ; Fri, 26 Nov 2021 12:48:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5jt1mjHKNwpphvTuP5UsiqGYVaad6rtiT5rqbJhkOJ4=; b=QS8vI26zCeA8ZZ jwfWjYaX9DC79Uk8fOhU8EXHPEhhx8bVSD1MWjizvXmEIEqWQ1/mvfyV/qIlCaHwJ6AdZ6C9Z32qX XcplE8zvB0lGaCZyjrWmKyr2tq5hnFb/KHvQWbwX9OJ3suchVL54uNAdqV5BoabLPPdnxXsowb/8x n8rkdwaGiSY3yU0tTUl8mDPPgN3J4LpJkGOYplodSvRjRQPsYsqk/biFTm3E4DUdVtDL9UczbFSrE v7/Lopc/ztAWBucp+XrckB6qZUwcHF53q2D+gbyI+Kob3Zd0KA4nSOX42fQkl4zJ9nWDt0I6Rw6KS T3V+R/V98Zo3CAVYdSLQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mqacV-00ARse-9n; Fri, 26 Nov 2021 12:46:28 +0000 Received: from [2001:8b0:1628:5005::111] (helo=metanate.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mqaVZ-00APWN-ON; Fri, 26 Nov 2021 12:39:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=metanate.com; s=stronger; h=In-Reply-To:Content-Type:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description; bh=6Q8FkNR0DNeahIkoGpQtYJLzOambxup0KYyLRA9vCcY=; b=hjUMA LFrtuLT9/WLkRW0wCzOVZzXTcy0gZsOZt0xnR9prHD9xP991ArgEVv91sadR6YmjKUf8H+dBJS4XI jpfipRFa9k76XKDJQhhOYdiDHVYlnXHxCvKJr+zZYeo4/vXFyy9Z2VUGET8+ARF+ZM7+TKlbdbIrd 79G2asIgrjBrk9/v1p6rcLSBodwCOxYvNsM4YA9HWGxyCmaWNrcRYcT7WqJbiT+P0/zUeqv973zAs TJljWxj28IWz+vm3b1vNSdHe2yMdgx/wWys7Cxqlyo2guwQevyXIlVftaoTWTeibzfDCOeCiMTfsf qCqTy/ELzRKDsi1GOs6DvBYR//wog==; Received: from [81.174.171.191] (helo=donbot) by email.metanate.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1mqaVM-0005gT-LX; Fri, 26 Nov 2021 12:39:04 +0000 Date: Fri, 26 Nov 2021 12:39:03 +0000 From: John Keeping To: Jaehoon Chung Cc: linux-mmc@vger.kernel.org, Heiko Stuebner , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, Ulf Hansson Subject: Re: [PATCH 4/4] mmc: dw_mmc: exynos: use common_caps Message-ID: References: <20211124184603.3897245-1-john@metanate.com> <20211124184603.3897245-5-john@metanate.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Authenticated: YES X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211126_043917_842751_9E5B5D77 X-CRM114-Status: GOOD ( 23.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Nov 26, 2021 at 08:38:20AM +0900, Jaehoon Chung wrote: > On 11/25/21 3:46 AM, John Keeping wrote: > > Move the common MMC_CAP_CMD23 capability to common_caps so that only the > > special case of MMC_CAP_1_8V_DDR and MMC_CAP_8_BIT_DATA are set via > > caps/num_caps. Both of those can, and should, be set via device tree > > properties instead, so we can now say that exynos_dwmmc_caps is only > > used for backwards compatibility. > > > > Signed-off-by: John Keeping > > > Reviewed-by: Jaehoon Chung > > Added minor comment.. > > > --- > > drivers/mmc/host/dw_mmc-exynos.c | 9 +++++---- > > 1 file changed, 5 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c > > index c2dd29ef45c6..f76eeeb0cc53 100644 > > --- a/drivers/mmc/host/dw_mmc-exynos.c > > +++ b/drivers/mmc/host/dw_mmc-exynos.c > > @@ -526,15 +526,16 @@ static int dw_mci_exynos_prepare_hs400_tuning(struct dw_mci *host, > > > > /* Common capabilities of Exynos4/Exynos5 SoC */ > > static unsigned long exynos_dwmmc_caps[4] = { > > - MMC_CAP_1_8V_DDR | MMC_CAP_8_BIT_DATA | MMC_CAP_CMD23, > > - MMC_CAP_CMD23, > > - MMC_CAP_CMD23, > > - MMC_CAP_CMD23, > > + MMC_CAP_1_8V_DDR | MMC_CAP_8_BIT_DATA, > > + 0, > > + 0, > > + 0, > > }; > > It can be removed all things. Do you mean that the MMC_CAP_1_8V_DDR | MMC_CAP_8_BIT_DATA entries are not needed at all? I know those can be set via DT but I don't think any Exynos DTs are currently using mmc-ddr-1_8v, so removing MMC_CAP_1_8V_DDR looks like a change in behaviour. MMC_CAP_8_BIT_DATA looks easier to remove, although exynos4412-p4note.dtsi seems to set the incorrect bus-width for mshc_0 so there would be a change of behaviour on that platform from removing this. Maybe it makes sense to add a warning in dw_mci_init_slot_caps() if any new caps are set by drv_data->caps[ctrl_id], to make it clear that this is deprecated. Regards, John _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel