From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 425ADC433EF for ; Mon, 29 Nov 2021 19:05:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=E3pLhXdcA06kWs+nxVnPJ+9VqWVWyzN4FK3Otr0EygU=; b=bMwAentonLSiDL5t2biXae09mz K2ctbffVfrnWbk6WOjILQAHWnQLT4oiA2oPhifs2HFRHqfeui++EMgai2pVq1sF4x8VL0ugVnL6a1 bq4rUgJS4yW4O6gcoGIlCcMDUEN11OWpfFWpnyVHNi+LKaYSGdos9FD5mK5PKI72Tx+ccIypG8Dpu y0+rjqjSdewy06n2dMTTdRLRIIVB8UpGo3NzUXuireGfvRFisFuKOb+dnfkZ7W0KfvSlqwwVLY7jU VNTgnxQcfI4HKxu4DbdwDAFKoZ3zL+SHyI2LNCvsiH47qmuBcJ7EVXCIGbwrJaXvKIqX/CE1IqKwS 9Zisetmw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mrlvt-001yOS-C9; Mon, 29 Nov 2021 19:03:22 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mrltt-001xez-PO for linux-arm-kernel@lists.infradead.org; Mon, 29 Nov 2021 19:01:19 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id C2D05CE13DF; Mon, 29 Nov 2021 19:01:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4E4C0C53FC7; Mon, 29 Nov 2021 19:01:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1638212474; bh=LI3uzx9vdel0e6nDIT5a2zojnOZrdhJyAQH/EOVBkBo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=f9kRWRULFdRNQwBgjwjcmLGKTulxrL6R4TnNzp3rrqnzJkuvvggCmX/TivIMm+fIG 5HUOOku7tuIE6tH+sCn2lnMFbInLJi88KRMITuroKGq2LNq9O7nB8sD9DGuuRrLy2W ys0qx3uF1Of8yqOG0Clst6rMzFxrdcUCSLsU37NJpwd0XfJS8rn4uWtkf48nAwa4M2 bvJEBfQRAPRNDekzfKXc05WWrF5NGxE+qxGQRIZDepONRlbJD7p1Kqx8YBvQfbLOYt hMYhWVTk8ptNweh3hyhBaG5PC3V6bUow93p/x90doNiYMQFG2txwBNlpKKVDunHqxR BJlKgwkyDqdzg== Date: Mon, 29 Nov 2021 20:01:11 +0100 From: Wolfram Sang To: Chris Packham Cc: rjui@broadcom.com, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Richard Laing Subject: Re: [PATCH v3] i2c: bcm-iproc: Add i2c recovery support Message-ID: Mail-Followup-To: Wolfram Sang , Chris Packham , rjui@broadcom.com, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Richard Laing References: <20210603052515.11178-1-chris.packham@alliedtelesis.co.nz> MIME-Version: 1.0 In-Reply-To: <20210603052515.11178-1-chris.packham@alliedtelesis.co.nz> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211129_110118_255074_6F7F2FF6 X-CRM114-Status: GOOD ( 12.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============0987255461327982709==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============0987255461327982709== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="KsO1SrJz6NmBFB0C" Content-Disposition: inline --KsO1SrJz6NmBFB0C Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Chris, sorry for the long delay. All looks good except for this: > @@ -806,6 +954,7 @@ static int bcm_iproc_i2c_xfer_wait(struct bcm_iproc_i= 2c_dev *iproc_i2c, > /* flush both TX/RX FIFOs */ > val =3D BIT(M_FIFO_RX_FLUSH_SHIFT) | BIT(M_FIFO_TX_FLUSH_SHIFT); > iproc_i2c_wr_reg(iproc_i2c, M_FIFO_CTRL_OFFSET, val); > + iproc_i2c_lockup_recover(iproc_i2c); > return -ETIMEDOUT; > } > =20 > @@ -814,6 +963,7 @@ static int bcm_iproc_i2c_xfer_wait(struct bcm_iproc_i= 2c_dev *iproc_i2c, > /* flush both TX/RX FIFOs */ > val =3D BIT(M_FIFO_RX_FLUSH_SHIFT) | BIT(M_FIFO_TX_FLUSH_SHIFT); > iproc_i2c_wr_reg(iproc_i2c, M_FIFO_CTRL_OFFSET, val); > + iproc_i2c_lockup_recover(iproc_i2c); > return ret; > } I2C specs suggest recovery at the beginning of a transfer when SDA is detected low. Not at the end of a transfer. Happy hacking, Wolfram --KsO1SrJz6NmBFB0C Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmGlI3EACgkQFA3kzBSg KbbDzQ//cwibsOuDJHpe5xXhY+J5NHxJ10LpS8bcVXHwhuwxf3WiyiNgFxpymoJi UU2t/vIsS13UMGbRI2sDino8dIURnQC2a0p59FlCQUMeYXKef7uPew+idxKHvqV6 t5gP5ihKCZvEa8y9037qe/635eW4+TkwWV9srgPxG61cRNogG8oIIyNwqbyUfqZC 2dkwVC7liLDINxWUEmQdHh6uzwtEklvUYBnJgvwf5kkKyiaFHehP8vrb3yvJKhhz eZPdPZWHKV1Mw1wzYmZulqyG/Ic4fDwmSCmL0fPZXVumypA5tqFj89NYQMJ9u4h9 2nZDtZC3pMts9XHVJrJfpkQu1ZOQ3GUyrixhWtpMyUx5dw7Fw4Olg+CBxlwwSoE4 odx7BuqK3e5A21QMWqyhe/+HPosYOCbesXumJyu9BcAuG6ztOW027nOhCuY+I8yS WLYwjE0IKCtEiHI9AhUCIDFxRUC1serwSo9L+EYZ0uQHUsbGixcCNz528QTykl51 W18kqGABzlhm5+jov/BPft7daHafdjBpdGO3HUb+EHxSqgZJrRZBKbIdGZO9o0sv 14EZr1oXCQMiSCNJ5bBoMdcXU7f93inX9TMjTvoQ10DNReopMZKVpwrTVZ2XXwxA 0F6RzcWwSeOThH/HYgjeTMPkl8SyBTtep8KbMhbOS5wiDPMxOYM= =qV9d -----END PGP SIGNATURE----- --KsO1SrJz6NmBFB0C-- --===============0987255461327982709== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============0987255461327982709==--