From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 64EC2C433EF for ; Tue, 30 Nov 2021 11:48:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=H5jczrxiUQXZxFy4iHaxi2PaYODjzkWhy9Ly1lzTTXo=; b=WM9apUyy6q+AA3 vOgyu9aWPf0D5V8ZIB7yZhC3Q/F23W37hp5LOc/5eo6Urj3As01gWnZ5DJfdqBXG0VhvXTyZ+N1qm Lz2K9i6wNTnZT/rByCbQQylSd+6k51Lc53TsV0aykfahD39UbGMBXEXh65H3y+vkpI+BJJEbgfBxx 8cW3MMLz9rEa6wH7qq5EWdXPJh36JrTkYyfSnsVcJYAVSbH/PkmfoXjsQoNu3o0hfiNpiu937kaAx Cek1acI/0N5K8Kqh36B2KSNLPVu/61ducQgFeooAujv5P/tpMI7AEgInPEaWLY+WC2sEkK/QGYMnp zJkuqnoY7bAJwSVzgCFg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ms1bP-004vgG-RN; Tue, 30 Nov 2021 11:47:16 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ms1bK-004vet-BL for linux-arm-kernel@lists.infradead.org; Tue, 30 Nov 2021 11:47:12 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id AE5ACCE18C8; Tue, 30 Nov 2021 11:47:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BB4D0C58335; Tue, 30 Nov 2021 11:47:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1638272827; bh=k9WyNYGgTV92Nf8EhsdK/4a7BRg1HEKvlaZQo0J87Sg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qxreogXLDgZULP3/Us7kcZz2y+4YjJ9XPaqc2uhv0CZsWv+7HECN4Mdts51gr/0m0 9scCdnf0PDmoOzK1M2iiwKGIiXcv93WAS3GEyw2eYG6ZqIllx62FIw6na+LuNwjxDF /sQtThqqZ3ebzLJFIHc4lGY3ONV+OxopKKvniy90= Date: Tue, 30 Nov 2021 12:47:04 +0100 From: Greg Kroah-Hartman To: Neal Liu Cc: Felipe Balbi , Joel Stanley , Andrew Jeffery , Cai Huoqing , Tao Ren , Julia Lawall , kernel test robot , Sasha Levin , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, BMC-SW@aspeedtech.com Subject: Re: [PATCH v2 4/4] usb: aspeed-vhub: support test mode feature Message-ID: References: <20211130104256.3106797-1-neal_liu@aspeedtech.com> <20211130104256.3106797-5-neal_liu@aspeedtech.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211130104256.3106797-5-neal_liu@aspeedtech.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211130_034710_781040_2EAE0A1C X-CRM114-Status: GOOD ( 18.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Nov 30, 2021 at 06:42:56PM +0800, Neal Liu wrote: > Support aspeed usb vhub set feature to test mode. > > Signed-off-by: Neal Liu > --- > drivers/usb/gadget/udc/aspeed-vhub/dev.c | 18 ++++++++++++++---- > drivers/usb/gadget/udc/aspeed-vhub/hub.c | 22 ++++++++++++++++------ > 2 files changed, 30 insertions(+), 10 deletions(-) > > diff --git a/drivers/usb/gadget/udc/aspeed-vhub/dev.c b/drivers/usb/gadget/udc/aspeed-vhub/dev.c > index d918e8b2af3c..4462f4b73b04 100644 > --- a/drivers/usb/gadget/udc/aspeed-vhub/dev.c > +++ b/drivers/usb/gadget/udc/aspeed-vhub/dev.c > @@ -110,15 +110,25 @@ static int ast_vhub_dev_feature(struct ast_vhub_dev *d, > u16 wIndex, u16 wValue, > bool is_set) > { > + u32 val; > + > DDBG(d, "%s_FEATURE(dev val=%02x)\n", > is_set ? "SET" : "CLEAR", wValue); > > - if (wValue != USB_DEVICE_REMOTE_WAKEUP) > - return std_req_driver; > + if (wValue == USB_DEVICE_REMOTE_WAKEUP) { > + d->wakeup_en = is_set; > + return std_req_complete; > > - d->wakeup_en = is_set; > + } else if (wValue == USB_DEVICE_TEST_MODE) { If you return, no need for an else statement, right? > + val = readl(d->vhub->regs + AST_VHUB_CTRL); > + val &= ~GENMASK(10, 8); > + val |= VHUB_CTRL_SET_TEST_MODE((wIndex >> 8) & 0x7); > + writel(val, d->vhub->regs + AST_VHUB_CTRL); > > - return std_req_complete; > + return std_req_complete; > + } > + > + return std_req_driver; > } > > static int ast_vhub_ep_feature(struct ast_vhub_dev *d, > diff --git a/drivers/usb/gadget/udc/aspeed-vhub/hub.c b/drivers/usb/gadget/udc/aspeed-vhub/hub.c > index 93f27a745760..e52805fbdebd 100644 > --- a/drivers/usb/gadget/udc/aspeed-vhub/hub.c > +++ b/drivers/usb/gadget/udc/aspeed-vhub/hub.c > @@ -212,17 +212,27 @@ static int ast_vhub_hub_dev_feature(struct ast_vhub_ep *ep, > u16 wIndex, u16 wValue, > bool is_set) > { > + u32 val; > + > EPDBG(ep, "%s_FEATURE(dev val=%02x)\n", > is_set ? "SET" : "CLEAR", wValue); > > - if (wValue != USB_DEVICE_REMOTE_WAKEUP) > - return std_req_stall; > + if (wValue == USB_DEVICE_REMOTE_WAKEUP) { > + ep->vhub->wakeup_en = is_set; > + EPDBG(ep, "Hub remote wakeup %s\n", > + is_set ? "enabled" : "disabled"); > + return std_req_complete; > > - ep->vhub->wakeup_en = is_set; > - EPDBG(ep, "Hub remote wakeup %s\n", > - is_set ? "enabled" : "disabled"); > + } else if (wValue == USB_DEVICE_TEST_MODE) { Same here, no need for else. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel