From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 090EEC433F5 for ; Tue, 30 Nov 2021 12:21:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QmR4s9JlzIhpzDUiKh3wQWz2Fo9I85P4nDKx8Cg9890=; b=cQWgAwZ0soXW5y LUhQ0R9QD8XpWAfiY5xtP7NJkXk+TddVdylTHayiNv/d/TYi93Mg+NoprwihzJsI3ERY/E4gdKvyn 1C6qvZu9JO951cFFufrPOwH/PIgQi91KDLBnanwrswxopWN0vbK/yVFbDR1YR4Ve3h2ao+nLSn+fA wn2PPGaQNrZqsJA/zkkoZuuv43m1tQqvYmAfb6U5Jg9jEdxDxqumlJD7WrtnPKehhRugQ8lJ/aymH X5szpClKlUchrX5/OoSKN1/zI3eumjjwLaa0MfqlRtixXtLMZ7b6sCqaOs6DHoAEGxE7UjhwyeemO up2pNo0M15c9vHsSERnA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ms27L-0054os-BL; Tue, 30 Nov 2021 12:20:15 +0000 Received: from mail-vk1-xa34.google.com ([2607:f8b0:4864:20::a34]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ms27G-0054nD-Qw for linux-arm-kernel@lists.infradead.org; Tue, 30 Nov 2021 12:20:12 +0000 Received: by mail-vk1-xa34.google.com with SMTP id b192so13437729vkf.3 for ; Tue, 30 Nov 2021 04:20:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vanguardiasur-com-ar.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=VVEC9MyOR43khg1i5T22QR4aHRP9iObZnCLCzY2Cxbo=; b=n7rjdnb4XjbplJU1heJ9DsQqw/9v+Bl1JBdtfkTzF3oDmsQ27HI/vyc2NQRy4fuiEb rKf4Hge+6zsOxTPw0OkMp7tpBk3rOEqu7e5H2rRBp6OXCCkXOG9w7BxC3PvALQE79RkQ jgqpCvO3dhBxm+kvVr9XSjUoTdNL0q2bGCTOgivz/mjehawZflh8GwnSHv9h3YuPXaKO anmNsOsadNEm4HP2X69ZqxD2VisZTkQX67RHH3gaK8QVGbEn7uMdIWopa8VmvLE5HoAv 2qsMqiX2V2lLvxtuzubAQtYA4QQN2yYF1GGtWQ8hAdGZ62ask7X/ZNpxkSWsldExO92h 9krg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=VVEC9MyOR43khg1i5T22QR4aHRP9iObZnCLCzY2Cxbo=; b=gRAg4/Lw0f2Dj9fa14lMFZImI2iHXmli1DkFtGb+LFAgXeDQEl8R2ISAE1DreDbvME COTOMZOM6zcrLAuxoDKjhPCHvvqFrlWb0QmTsZQ8CMIUBTHjwsuMpvteDP2hBjR5Phhu DXnWGu+1fTS8L/UWcbXutzfTCH4KlgNieKfferK7oSe2PfewqIiGacx5NCiFWKbr/UGT 9/9Icg2IK0ijUUEOq+n0aYLlUYf54FBQr6X5cMxCSfWJhp4G7btk6ZcOMmo/r2uQuIhB MlmLrjSCWJVxEYb2o2iqIMhLnCgbSFsnsEc5V+MXUByj7FsNixFGqxmqF+g8I1A1ctT1 IB0w== X-Gm-Message-State: AOAM5306dl1evM+erkQH9xjZ6cDXQU7KqP5jzMIhELJ8X56YsO4rJpqU 9cE29iAVQSyrcdBcijTs1MJYrw== X-Google-Smtp-Source: ABdhPJx4pjcG+r16tI53s5Kfp7uWbm31oMJatWgIFBrtQICorJtMeQMcOZOMxsNpcGFmaeirrwxXLg== X-Received: by 2002:a05:6122:1788:: with SMTP id o8mr43886681vkf.8.1638274808616; Tue, 30 Nov 2021 04:20:08 -0800 (PST) Received: from eze-laptop (host208.201-253-22.telecom.net.ar. [201.253.22.208]) by smtp.gmail.com with ESMTPSA id h10sm10097739vsl.34.2021.11.30.04.20.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Nov 2021 04:20:07 -0800 (PST) Date: Tue, 30 Nov 2021 09:20:03 -0300 From: Ezequiel Garcia To: Jernej Skrabec Cc: linux-media@vger.kernel.org, nicolas.dufresne@collabora.com, mchehab@kernel.org, robh+dt@kernel.org, mripard@kernel.org, wens@csie.org, p.zabel@pengutronix.de, andrzej.p@collabora.com, gregkh@linuxfoundation.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH v2 5/9] media: hantro: move postproc enablement for old cores Message-ID: References: <20211129182633.480021-1-jernej.skrabec@gmail.com> <20211129182633.480021-6-jernej.skrabec@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211129182633.480021-6-jernej.skrabec@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211130_042010_895255_0D03CCAF X-CRM114-Status: GOOD ( 22.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Nov 29, 2021 at 07:26:29PM +0100, Jernej Skrabec wrote: > Older G2 cores, like that in Allwinner H6, seem to have issue with > latching postproc register values if this is first thing done in job. > Moving that to the end solves the issue. > > Signed-off-by: Jernej Skrabec Reviewed-by: Ezequiel Garcia Thanks! > --- > drivers/staging/media/hantro/hantro.h | 2 ++ > drivers/staging/media/hantro/hantro_drv.c | 9 ++++++++- > 2 files changed, 10 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/media/hantro/hantro.h b/drivers/staging/media/hantro/hantro.h > index 83ed25d9657b..06d0f3597694 100644 > --- a/drivers/staging/media/hantro/hantro.h > +++ b/drivers/staging/media/hantro/hantro.h > @@ -75,6 +75,7 @@ struct hantro_irq { > * @num_regs: number of register range names in the array > * @double_buffer: core needs double buffering > * @legacy_regs: core uses legacy register set > + * @late_postproc: postproc must be set up at the end of the job > */ > struct hantro_variant { > unsigned int enc_offset; > @@ -98,6 +99,7 @@ struct hantro_variant { > int num_regs; > unsigned int double_buffer : 1; > unsigned int legacy_regs : 1; > + unsigned int late_postproc : 1; > }; > > /** > diff --git a/drivers/staging/media/hantro/hantro_drv.c b/drivers/staging/media/hantro/hantro_drv.c > index 770f4ce71d29..33bf78be145b 100644 > --- a/drivers/staging/media/hantro/hantro_drv.c > +++ b/drivers/staging/media/hantro/hantro_drv.c > @@ -130,7 +130,7 @@ void hantro_start_prepare_run(struct hantro_ctx *ctx) > v4l2_ctrl_request_setup(src_buf->vb2_buf.req_obj.req, > &ctx->ctrl_handler); > > - if (!ctx->is_encoder) { > + if (!ctx->is_encoder && !ctx->dev->variant->late_postproc) { > if (hantro_needs_postproc(ctx, ctx->vpu_dst_fmt)) > hantro_postproc_enable(ctx); > else > @@ -142,6 +142,13 @@ void hantro_end_prepare_run(struct hantro_ctx *ctx) > { > struct vb2_v4l2_buffer *src_buf; > > + if (!ctx->is_encoder && ctx->dev->variant->late_postproc) { > + if (hantro_needs_postproc(ctx, ctx->vpu_dst_fmt)) > + hantro_postproc_enable(ctx); > + else > + hantro_postproc_disable(ctx); > + } > + > src_buf = hantro_get_src_buf(ctx); > v4l2_ctrl_request_complete(src_buf->vb2_buf.req_obj.req, > &ctx->ctrl_handler); > -- > 2.34.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel