From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1E004C433EF for ; Wed, 1 Dec 2021 16:06:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6pYqto2vU99HyjCc4GoeZ5VvSW/JExxpPab5UmbL754=; b=k3VMu/3oNEc9xS ugTWfZH2ZQjc8Q+wFpnqWDwizqfdJh3CuS4tIs0Q3ESzV4E9NIhy2PWLRSZUhPLkgk0QIskl0ypRj Rlgg/gKIuhO+wF3lRQCscRhKksKS0qnV98DL2Dh1DjReEGEpe9QhrYaDs4MInPDOEaaIhW0pjOF14 PrxYaluzPBp7UCvPtwp+jsbnkbMOwq9ZcCjcHiCE4gwl1QH/kZMqgNo8OqWX8tSa97cKAAE7SzyP6 Y6O+CfvOBsjldHR6Ej+KsWxOp3URBPfZ1TrDjkeGOFwcsi3+tYtybT4gjFF0IeuHdVntfoKkJwc9z DUcn6UiHw77elN4uBB+w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1msS6b-009JDv-U8; Wed, 01 Dec 2021 16:05:14 +0000 Received: from mga14.intel.com ([192.55.52.115]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1msS6S-009JBT-It; Wed, 01 Dec 2021 16:05:05 +0000 X-IronPort-AV: E=McAfee;i="6200,9189,10185"; a="236713693" X-IronPort-AV: E=Sophos;i="5.87,278,1631602800"; d="scan'208";a="236713693" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Dec 2021 08:02:53 -0800 X-IronPort-AV: E=Sophos;i="5.87,278,1631602800"; d="scan'208";a="654828841" Received: from smile.fi.intel.com ([10.237.72.184]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Dec 2021 08:02:50 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1msS3H-0012Uu-9X; Wed, 01 Dec 2021 18:01:47 +0200 Date: Wed, 1 Dec 2021 18:01:46 +0200 From: Andy Shevchenko To: Lorenzo Pieralisi Cc: bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Florian Fainelli , Rob Herring , Bjorn Helgaas , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Jim Quinlan , Nicolas Saenz Julienne Subject: Re: [PATCH v2 1/1] PCI: brcmstb: Use BIT() as __GENMASK() is for internal use only Message-ID: References: <20211115112000.23693-1-andriy.shevchenko@linux.intel.com> <163837398126.3058.11030158077196581603.b4-ty@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <163837398126.3058.11030158077196581603.b4-ty@arm.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211201_080504_680452_6AF6A32B X-CRM114-Status: GOOD ( 16.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Dec 01, 2021 at 03:53:21PM +0000, Lorenzo Pieralisi wrote: > On Mon, 15 Nov 2021 13:20:00 +0200, Andy Shevchenko wrote: > > Use BIT() as __GENMASK() is for internal use only. The rationale > > of switching to BIT() is to provide better generated code. The > > GENMASK() against non-constant numbers may produce an ugly assembler > > code. On contrary the BIT() is simply converted to corresponding shift > > operation. > > > > Note, it's the only user of __GENMASK() in the kernel outside of its own realm. > > > > [...] > > Applied to pci/brcmstb, thanks! > > [1/1] PCI: brcmstb: Use BIT() as __GENMASK() is for internal use only > https://git.kernel.org/lpieralisi/pci/c/6ec6eb949d Thanks, but there is another patch which changes the logic a bit and cleans up more. From: Florian Fainelli Subject: [PATCH] PCI: brcmstb: Do not use __GENMASK -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel