From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 519ACC433F5 for ; Wed, 1 Dec 2021 22:36:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=G82dKCEcrldPOfy5FplEM5lUuAq65a9Zvox4yvNW0HM=; b=fGla/1i4dyvfkA SwF5I1loNmZUzvw6IC+IMsdBfut4AjCBJ5DpipK/Urz+V3JrSuYcPTr1CBMfAnbksuFWwEzO0fDdO VJIPlwjfo/Of5lm0XcJokb4raN29JjpwJM7Y9oCgmZklmIJyGE+2CBscE6cufE0/VdJzWTlzBsIN0 +CHraSpsK7ICxDmRs/p5513xh406Dd1+VCJF95tuWwyBg8++ZUIyemaJoLRswiNb2kycxJMr7nB5M Yh15pxi1mbKzsT6B6ugSKnJUz2FaAOWmtM1IAFC0xUg0pRq4/wqXQLZTkintaSU7sbZTc+tfdN9ya 2TTdky59yDuQQMINW1iQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1msYBo-00AHhr-RS; Wed, 01 Dec 2021 22:35:01 +0000 Received: from mail-oi1-f182.google.com ([209.85.167.182]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1msYBk-00AHh2-VI for linux-arm-kernel@lists.infradead.org; Wed, 01 Dec 2021 22:34:58 +0000 Received: by mail-oi1-f182.google.com with SMTP id r26so51621671oiw.5 for ; Wed, 01 Dec 2021 14:34:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=1cxGpGuXFYT7z9IMgpvEZhppfpCtenqGacj+Q88IAEE=; b=Ax4UPQT9gPAjguGFxCLnHRJZPQl/wcnHSH72orlXe03JPd/Rt6R1ZrrefsxhwFzJAu 8GY4Wzx+e8abdol3bIMHo/nAQaE1lmPpviIvMUqvtIPvjkFmxtXGhWsWzuhZbpyLo1dT 6wNHOleqvYHvE46fGgA2d01hgD/UGJ5YaRBYnLSIed7hgPtYixRDRI8AO+SPI5nmDYLP iVziAEKaHJZ4X8LkwVuEMQLFbTuoqJP1QPy7OlgHyltzLQln204SmvfJlteJy2oAyfpi X1tBkfskhVYu1eusTXp2M7Zl/7RDFktwJvyxOgLc3WCCO9QrwQY14gMg38pKg67cdb3n 4MAQ== X-Gm-Message-State: AOAM532Eph4AgThMk79vxCJupbrhIDsQ2CkY5vAiaBrPA8K1N+6Z3ip6 U49OamEtVUgcna9Bt1aqHQ== X-Google-Smtp-Source: ABdhPJzYVbv04PWEmrUTCr7W5O/7iNRMV3i5k8Bm9QEVICIoEC+6CgArt/iFDuAT12MH7ix6AtarcQ== X-Received: by 2002:aca:d608:: with SMTP id n8mr1145835oig.89.1638398095643; Wed, 01 Dec 2021 14:34:55 -0800 (PST) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id bf17sm655019oib.27.2021.12.01.14.34.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Dec 2021 14:34:55 -0800 (PST) Received: (nullmailer pid 2914345 invoked by uid 1000); Wed, 01 Dec 2021 22:34:54 -0000 Date: Wed, 1 Dec 2021 16:34:54 -0600 From: Rob Herring To: Olivier MOYSAN Cc: linux-kernel@vger.kernel.org, Liam Girdwood , Olivier Moysan , Maxime Coquelin , fabrice.gasnier@foss.st.com, alain.volmat@foss.st.com, alsa-devel@alsa-project.org, amelie.delaunay@foss.st.com, linux-stm32@st-md-mailman.stormreply.com, Mark Brown , Alexandre Torgue , devicetree@vger.kernel.org, arnaud.pouliquen@foss.st.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 1/4] ASoC: dt-bindings: stm32: i2s: add audio-graph-card port Message-ID: References: <20211125144053.774-1-olivier.moysan@foss.st.com> <20211125144053.774-2-olivier.moysan@foss.st.com> <1637875562.357461.2858318.nullmailer@robh.at.kernel.org> <237f56b3-0597-2526-a182-f1fbdd327338@foss.st.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <237f56b3-0597-2526-a182-f1fbdd327338@foss.st.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211201_143457_038766_16CF60A4 X-CRM114-Status: GOOD ( 26.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Nov 26, 2021 at 11:25:27AM +0100, Olivier MOYSAN wrote: > Hi Rob, > > On 11/25/21 10:26 PM, Rob Herring wrote: > > On Thu, 25 Nov 2021 15:40:50 +0100, Olivier Moysan wrote: > > > The STM2 I2S DAI can be connected via the audio-graph-card. > > > Add port entry into the bindings. > > > > > > Signed-off-by: Olivier Moysan > > > --- > > > Documentation/devicetree/bindings/sound/st,stm32-i2s.yaml | 5 +++++ > > > 1 file changed, 5 insertions(+) > > > > > > > Running 'make dtbs_check' with the schema in this patch gives the > > following warnings. Consider if they are expected or the schema is > > incorrect. These may not be new warnings. > > > > Note that it is not yet a requirement to have 0 warnings for dtbs_check. > > This will change in the future. > > > > Full log is available here: https://patchwork.ozlabs.org/patch/1559750 > > > > > > audio-controller@4000b000: 'port' does not match any of the regexes: '^port@[0-9]', 'pinctrl-[0-9]+' > > arch/arm/boot/dts/stm32mp157a-dk1.dt.yaml > > arch/arm/boot/dts/stm32mp157c-dk2.dt.yaml > > > > This warning is not a new one. > > The i2s2 node in stm32mp15xx-dkx.dtsi would require the following binding: > port: > $ref: audio-graph-port.yaml# > unevaluatedProperties: false > > However the spi binding requires to introduce a unit address: > patternProperties: > '^port@[0-9]': > $ref: audio-graph-port.yaml# > unevaluatedProperties: false > > The warning can be removed by re-ordering the bindings patches in the serie, > as "additionalProperties: true" makes the check more tolerant on extra > properties. That's never right. > The patch "ASoC: dt-bindings: stm32: i2s: add audio-graph-card port" can > even be merely dropped. > So, I suggest to resend the serie without audio-graph-card patch. Only if you aren't using audio-graph-card. > > Does it sound too permissive to you ? I think perhaps you need to combine the schemas into 1. Or you need to restructure your dtsi files such that you only add spi specific properties when spi mode is enabled and only add i2s specific properties when i2s mode is enabled. Or use the /delete-property/ directive. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel